potential Instability when filters throw about broccoli-sane-watcher HOT 8 CLOSED

I made an update a while back that should now just do a grunt fail on parsing errors. It's published as 0.0.10 of es6-import-validate, running npm update should pull the latest version for the broccoli task.

from broccoli-sane-watcher.

@jgable this seems to be happening across more filters. Maybe it is a plugin problem not the watcher?

from broccoli-sane-watcher.

Sure, but es6-import-validate shouldn't fall on its face when parsing fails.

from broccoli-sane-watcher.

@jgable understood.

from broccoli-sane-watcher.

@stefanpenner I did some poking and found the point that was never being reached after a build error. It appears to be here.

As a quick and dirty hack, I added a reject like so:

  this.sequence = this.sequence.then(function () {
    return timeout.then(build);
  }, function() {
    return timeout.then(build);
  });

And lo and behold, the build came back. I don't know what that means, but I thought it might be helpful.

from broccoli-sane-watcher.

@WMeldon i think this watcher is just working correctly, but exposed that some filters/writes are buggy.

We should likely make this watcher log, but absorb build errors.

from broccoli-sane-watcher.

@stefanpenner I'd agree with that. Base level things like this need to be very liberal in what they accept. Especially with a new ecosystem like broccoli, higher level plugins are going to be a little rough around the edges.

from broccoli-sane-watcher.

I know what it is, I'll push a fix shortly.

from broccoli-sane-watcher.