brightspaceui / icons Goto Github PK

With the extra <span> tag, the height of d2l-icon can be impacted by the line-height, which is related to the font-size.

PolymerElements/iron-iconset-svg#54

@dlockhart Did you know about this? It was merged 2 days ago.

There has been a growing use of d2l-image-action without text to have an "icon-button". So, create a WC for this purpose, so there isn't any difficulty with or text that doesn't need to be displayed.

A recent iron-iconset-svg improvement implemented a use-global-rtl-attribute which is meant to improve performance of RTL icons by only checking the direction of the document once.

We should investigate opting into this flag.

Both push/pr builds are being run for PR commits. This can make the tests run longer, since SauceLabs only allows 6 concurrent sessions, so one build is blocked when the other runs.

Solution: Either turn off PR builds, or push builds.
https://travis-ci.org/BrightspaceUI/icons/settings

Alternatively, only open PRs from forks. (Currently, forked PR builds won't work because the SAUCE_USERNAME is encrypted)

Often we'll want a screen-reader friendly description to go along with an icon.

For example recently I was using the dot icon in the recent grades widget to indicate if a grade item is new or not. I created a sibling d2l-offscreen element to d2l-icon with shows/hide logic that matches the d2l-icon. It is fine, but it would have been nicer to do something like <d2l-icon offscreen-text="New item" ... >. Beyond being simpler as a consumer, in this case I actually also want the off screen text and icon to be tightly coupled.

I'm happy to add this and will do so, but I wanted to confirm if this is a good thing to add or not before doing the work (which is not a lot of course).

Currently the size of the icon is based off the d2l tiers, and it will default to 18px otherwise. But sometimes a custom icon needs to be used or a different size for the D2L icons is needed.

Looking to upgrade some of our components to v4 of d2l-icons, specifically for d2l-icon-button.

We currently set an aria-label on our v3 d2l-icon-buttons. When I upgrade to v4 we no longer get a announcements in NVDA for these labels.

It looks like d2l-icon-button sets a title attribute on the nested button but this is not exposed as a property and I don't think it is used by screen readers anyway.

Let me know if we should allow and aria-label attribute to be passed through to the nested button and if so I'll create a PR.

Hi BrightSpaceUI team,

Just recently, I wrote the blog Top 3 Polymer icon sets for your web app featuring d2l-icons set. You have a freaking cool icon set.

Feel free to drop a comment down below the comment section or in this tweet.

Cheers,
Binh

We have a workaround in place for a defect in iron-iconset-svg that's been resolved in the Polymer 2.x version.

When icons gets upgraded for Polymer 2.x, we can remove the workaround.

The grabber and grabber-small tier-1 icons have been replaced by dragger. We should remove the old ones in the next major release.

The color transition for d2l-icon-button and d2l-icon-link on hover/focus isn't getting applied. Seems to be related to the transition CSS property being applied to something with the class ..d2l-icon-button-icon, but nothing has that class.