Comments (5)
+1 to solving this for sighted users as well -- I'm guessing they also have a hard time knowing what an orange dot means.
I think design has some larger ideas around tooltips beyond just the title
attribute. Specifically it'd be great to show the tooltip on-focus (for focusable things) to help out keyboard-only users. Also, the implementation of tooltips will likely fall outside of <d2l-icon>
, especially if we want to use tooltips from other components like buttons and menus.
from icons.
I think the attribute could just be called title
. The fact that it's offscreen is sort of an internal implementation detail. If all browsers properly supported, it would actually be possible to apply a <title>
element as first child of an svg
, which although also an internal detail, would not be offscreen at all. In addition, it would display a tooltip, which can be helpful for sighted users.
from icons.
I think Nick D. has done some design for the tooltips. We might be able to make some headway on that. :)
from icons.
Sure I'll close this in favor of the tool tip work that will be superior to any offscreen solution. I just tested using title right now and it worked well enough for me (in NVDA at least) so I prefer the simpler solution (that might also help some sighted users). Thanks!
from icons.
Cool. aria-label="whatever you want"
may work well too, although no tooltip.
from icons.
Related Issues (13)
- Only build PRs once HOT 1
- Remove IE/Edge workaround for SVG focus in Polymer 2.x version
- Investigate using the new "use-global-rtl-attribute" flag HOT 1
- Question: Should d2l-icon-button support aria-label attribute on the nested button? HOT 6
- Your icon set was featured in a Vaadin blog HOT 1
- Remove "grabber" icons HOT 1
- Height can be affected by font-size
- Create d2l-icon-button and d2l-icon-link
- let size be customizable
- Use the iron-icon rtl mirroring HOT 3
- Fix color transition on icon-button and icon-link HOT 1
- Some icons in ShadowDOM are flipped from the incorrect origin HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icons.