Giter Club home page Giter Club logo

bitcoin-cored's Issues

A 'sizeof' for a pointer issue

Hi all,
There is a sizeof issue found by Qihoo360 CodeSafe Team.
Details as bellow:

bitcoin-cored/src/test/serialize_tests.cpp

Line 426 in 76c8a07

FLATDATA(charstrval), txval);

the argument of macro 'FLATDATA' is charstrval which is a pointer defined here:

bitcoin-cored/src/test/serialize_tests.cpp

Line 407 in 76c8a07

const char *charstrval("testing charstr");

in the expand of macro 'FLATDATA' here:

bitcoin-cored/src/serialize.h

Lines 361 to 362 in 76c8a07

#define FLATDATA(obj) \
REF(CFlatData((char *)&(obj), (char *)&(obj) + sizeof(obj)))

the parameter 'obj' will be used in sizeof operator.
do we really need the size of a pointer of should it be the size of the string (like strlen, or sizeof of a char array )?

Can you guys confirm this?

Cheers
Qihoo360 CodeSafe Team

¬issue but ... $accessibility woe.

Describe the issue

Requesting a web-wallet or paper-wallet repo creation for quick /on-the-fly "pitch-up-quic" adoption 🚀boosting.

Can you reliably reproduce the issue?

Hoping we do not have to anymore in near future.
🖤

Orphaning of blocks causes

Orphaning of blocks causes

Can you reliably reproduce the issue?

yes

If so, please list the steps to reproduce below:

  1. Chaintips are 123 w/ hash abc, 124 - bcd, 125 - cde with 125 being chaintip
  2. Another consecutively mines 125 w/hash xyz, 126 - def. Then broadcasts heights 125 & 126
  3. The reorg of the original block 125 triggers an assertion.

Expected behaviour

Transactions from orphaned block should be added to mempool if not present in the subsequent blocks of the longest chain. Orphaned block should be replaced as per longest chain with similar amount of work completed.

Actual behaviour

clashicd & clashic-qt triggers assertion and core dumps

Screenshots.

assertionfailure

What version of bitcoin-core SQ are you using?

v0.16.2-3c0f858

The code in question is from

Which was backported from Bitcoin ABC:
Bitcoin-ABC/bitcoin-abc@f18009a#diff-8304b3e94624036c3673f31eeb7e9de0

Which was backported from Bitcoin:
bitcoin/bitcoin#9208

Originally authored by @sdaftuar

Machine specs:

n/a

Any extra information that might be useful in the debugging process.

excerpts from debug log
https://pastebin.com/Vg2ECWfX

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.