Giter Club home page Giter Club logo

Comments (2)

clashicly avatar clashicly commented on July 21, 2024

@sdaftuar There was no issue with this code in v0.16.1 release and I know it is in Bitcoin Core (BTC) and Bitcoin ABC (BCH). It seems with 1-min blocks and lower difficulty on BTCC, we are seeing upto 2 orphans a day. Could you review your code to see how this is happening?

from bitcoin-cored.

corelyone avatar corelyone commented on July 21, 2024

The build from the pull request ran without issues on mainnet on several nodes without issues for a week through 3-10 orphans.

This is the log of the node that threw assertion and went down:

2018-09-04 18:04:43 UpdateTip: new best=0000000000000011c35b2024ba181a7ad74e574c8fe1427197ee72d4cd81ef9a height=613919 version=0x20000000 log2_work=86.962908 tx=245732535 date='2018-09-04 18:04:35' progress=1.000000 cache=0.1MiB(602txo)
2018-09-04 18:04:59 UpdateTip: new best=0000000000000019f097cfc214aed61159410488ec703ea4f26e0a31105ad000 height=613920 version=0x20000000 log2_work=86.962908 tx=245732536 date='2018-09-04 18:04:44' progress=1.000000 cache=0.1MiB(603txo)
2018-09-04 18:05:13 UpdateTip: new best=0000000000000011c35b2024ba181a7ad74e574c8fe1427197ee72d4cd81ef9a height=613919 version=0x20000000 log2_work=86.962908 tx=245732535 date='2018-09-04 18:04:35' progress=1.000000 cache=0.1MiB(603txo)
2018-09-04 18:05:13 UpdateTip: new best=000000000000001bf443dcaa2056bbb62352c358da63627107d63ba539c8428d height=613920 version=0x20000000 log2_work=86.962908 tx=245732536 date='2018-09-04 18:04:45' progress=1.000000 cache=0.1MiB(604txo)
2018-09-04 18:05:13 UpdateTip: new best=000000000000002b445cfd9a0d9e152d3c8eb59cb012003ac9098d9a2241593e height=613921 version=0x20000000 log2_work=86.962908 tx=245732537 date='2018-09-04 18:04:56' progress=1.000000 cache=0.1MiB

This is the log of the node that was patched and kept going:

2018-09-04 18:04:56 UpdateTip: new best=0000000000000019f097cfc214aed61159410488ec703ea4f26e0a31105ad000 height=613920 version=0x20000000 log2_work=86.962908 tx=245732536 date='2018-09-04 18:04:44' progress=1.000000 cache=0.1MiB(261txo)
2018-09-04 18:05:10 UpdateTip: new best=0000000000000011c35b2024ba181a7ad74e574c8fe1427197ee72d4cd81ef9a height=613919 version=0x20000000 log2_work=86.962908 tx=245732535 date='2018-09-04 18:04:35' progress=1.000000 cache=0.1MiB(261txo)
2018-09-04 18:05:10 UpdateTip: new best=000000000000001bf443dcaa2056bbb62352c358da63627107d63ba539c8428d height=613920 version=0x20000000 log2_work=86.962908 tx=245732536 date='2018-09-04 18:04:45' progress=1.000000 cache=0.1MiB(262txo)
2018-09-04 18:05:10 UpdateTip: new best=000000000000002b445cfd9a0d9e152d3c8eb59cb012003ac9098d9a2241593e height=613921 version=0x20000000 log2_work=86.962908 tx=245732537 date='2018-09-04 18:04:56' progress=1.000000 cache=0.1MiB(263txo)
2018-09-04 18:05:10 socket recv error Connection reset by peer (104)
2018-09-04 18:05:22 receive version message: [216.146.251.13:41842] /Bitcoin Core SQ:0.16.2(EB8.0)/: version 80030, blocks=613921, us=204.44.85.47:10333, peer=35370
2018-09-04 18:05:22 peer 35370 uses CASH magic in its headers
2018-09-04 18:05:32 receive version message: [216.146.251.8:1760] /Bitcoin Core SQ:0.16.2(EB8.0; BTCC)/: version 80030, blocks=613887, us=204.44.85.47:10333, peer=35371
2018-09-04 18:05:32 peer 35371 uses CASH magic in its headers
2018-09-04 18:05:34 peer=35372 using obsolete version 70015; disconnecting
2018-09-04 18:05:34 ProcessMessages(version, 111 bytes) FAILED peer=35372
2018-09-04 18:05:42 UpdateTip: new best=000000000000000b73995cbac8c6051c5708f8245943566d465fbb34108ab279 height=613922 version=0x20000000 log2_work=86.962908 tx=245732538 date='2018-09-04 18:05:19' progress=1.000000 cache=0.1MiB(264txo)

You can see 2 versions of height 613920, no notifications or errors, just keeps going like nothing has happened
surprised there is no notification that there was an orphan
Same on another patched node, just keeps going:

2018-09-04 18:04:40 UpdateTip: new best=0000000000000011c35b2024ba181a7ad74e574c8fe1427197ee72d4cd81ef9a height=613919 version=0x20000000 log2_work=86.962908 tx=245732535 date='2018-09-04 18:04:35' progress=1.000000 cache=0.1MiB(260txo)
2018-09-04 18:04:41 peer=34970 using obsolete version 70015; disconnecting
2018-09-04 18:04:41 ProcessMessages(version, 117 bytes) FAILED peer=34970
2018-09-04 18:04:50 peer=34971 using obsolete version 70015; disconnecting
2018-09-04 18:04:50 ProcessMessages(version, 111 bytes) FAILED peer=34971
2018-09-04 18:04:56 UpdateTip: new best=0000000000000019f097cfc214aed61159410488ec703ea4f26e0a31105ad000 height=613920 version=0x20000000 log2_work=86.962908 tx=245732536 date='2018-09-04 18:04:44' progress=1.000000 cache=0.1MiB(261txo)
2018-09-04 18:04:58 peer=34972 using obsolete version 70015; disconnecting
2018-09-04 18:04:58 ProcessMessages(version, 117 bytes) FAILED peer=34972
2018-09-04 18:05:10 UpdateTip: new best=0000000000000011c35b2024ba181a7ad74e574c8fe1427197ee72d4cd81ef9a height=613919 version=0x20000000 log2_work=86.962908 tx=245732535 date='2018-09-04 18:04:35' progress=1.000000 cache=0.1MiB(261txo)
2018-09-04 18:05:10 UpdateTip: new best=000000000000001bf443dcaa2056bbb62352c358da63627107d63ba539c8428d height=613920 version=0x20000000 log2_work=86.962908 tx=245732536 date='2018-09-04 18:04:45' progress=1.000000 cache=0.1MiB(262txo)
2018-09-04 18:05:10 UpdateTip: new best=000000000000002b445cfd9a0d9e152d3c8eb59cb012003ac9098d9a2241593e height=613921 version=0x20000000 log2_work=86.962908 tx=245732537 date='2018-09-04 18:04:56' progress=1.000000 cache=0.1MiB(263txo)
2018-09-04 18:05:11 peer=34973 using obsolete version 70015; disconnecting

from bitcoin-cored.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.