containers-on-aws-workshop's People
Forkers
sergioescala sebastianms cepheia norberto-enomoto estairt diraol henriquesgnc wiltonpaulo viniciusgava edgarsandi gustavobrito-gavb juanlamadrid20 rafaelsilvaa10 vinicius-martinez brentley vingarcia nicolasqp mario2h enr1c091 medarz nikiforosbotis potter0815 jluismm2311 heve1989 xtianr3ds erik-etsushi gmagella sofiaisha vcach ghanima crypto-br vncrdo flamelcanto iair mebuffet rubensdevito jpoley borgesag israelrico007 thiagomcouto ignitz robersonfaria rarylson aissarmurad tiagoreichert douglasresende renemartinezb86 prabhakm klausfis merlingino ldecaro vvilelaj w00fx jriverox fabriciolmaia filipe-guimaraes davidneff frantecbh fabriciofconde kavichu georgi-petkov song4evr jalawala pbg99 alcefilho alexandrust88containers-on-aws-workshop's Issues
Typo on /containers-on-aws-workshop/00-Application/app/index.html
It says "bellow"
It should say "below"
Clarity on the "Pushing our tested images to ECR" instructions
I think it would be easier to state that the user should run the commands that appear after creating the repo using the console
Misleading link on "5. Cloning the workshop repository" under "Environment Setup"
It says: " you can go to the next chapter: 3. Deploying An ECS Cluster."
It should say "you can go to the next chapter: 2. Creating your Docker image."
The redirect of the image is OK.
Typo on readme.md
"bellow" should be "below"
Broken Link
File: https://github.com/bemer/containers-on-aws-workshop/tree/master/02-CreatingDockerImage
The link to "Setup Environment tutorial" in the following sentence is broken:
In this tutorial, we assume that you completed the Setup Environment tutorial and:
Target is:
https://github.com/bemer/containers-on-aws-workshop/blob/master/01-SetupEnvironment
Should be:
https://github.com/bemer/containers-on-aws-workshop/blob/master/01-EnvironmentSetup/
You should change the network mode of the ECS lab part
It uses bridge mode. I think that for the purposes of this lab, we can use awsvpc mode. This way, users can leverage this networking mode capabilities, benefits and speed
Region mismatch may confuse users and lead them into mistakes
The workshop is supposed to be region agnostic (ex: CF templates are provided for different regions).
But, in some pages, there are lines that supposes the user is in the us-east-1
region. In addition to this, in the page 05-ContinuousDelivery
, there are lines that supposes the user is in the us-east-2
region. This may confuse users.
Moreover, if the user copy/paste these lines, things will gonna be wrong, and it will hard to new-come users troubleshoot the errors.
Add CPU units when creating task definition
When creating the task definition for the EC2-type task on Chapter3, it only states:
"In the Task execution IAM role select Create new role and under Task size add 128 in the Task memory (MiB) field" and when clicking add container, you are prompted with an error stating you should declare the CPU Units.
I think you can change that sentence to:
"
"Under Task execution IAM role, select "Create new role"
Then, under Task Size use 128 and CPU units use 256
"
Typo on 01-EnvironmentSetup
You have Clou9 instead of Cloud9
Missing note at the end of "02-CreatingDockerImage"
There are no comments after the user reviews that the docker image is now on the repo. I´d recommend to add a note in the end of "02-CreatingDockerImage" that says:
Now we will create an ECS cluster to deploy our Docker image stored on ECR. Go to "03-DeployEcsCluster"
What do you think?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.