beaunouvelle / faceaware Goto Github PK

Would be cool to also zoom to the face so that the head+neck+shoulders is visible. Great for Avatars.

Just downloaded the example and I'm not able to run it on my phone!

"Use of unresolved identifier 'DispatchQueue'"

Am I missing anything?

@BeauNouvelle How can we use this magic in SwiftUI's Image view?

When I scroll the images are set not on proper cells, then when i stop scrolling it reloads and puts back the correct image.

How can I know the image FaceAware finished ? Use Block ?

Hey there,

First of all, thanks for making this open source! I wanted to ask if you're planning to make this available via Cocoapods?

Thanks

With SDWebImage , when displaying images asynchronously, does not recognise face for some images. Please rectify this.

Can I use this for tvOS?

Here is an example of an image that do not work

I wanted to test your library out to see if it would work for an app I am developing, but it looks like you built the entire example app in Xcode 8 Beta using iOS 10. You really shouldn't release public libraries under Betas. Would love to see this re-built in the current release version of Xcode.

Cheers!

WeakSelf(imageView) [imageView sd_setImageWithURL:[NSURL URLWithString:url] completed:^(UIImage * _Nullable image, NSError * _Nullable error, SDImageCacheType cacheType, NSURL * _Nullable imageURL) { weakimageView.image = image; weakimageView.focusOnFaces = YES; }];

When I scroll the TableView, This code will be performed.( I used SDWebImage to set ImageView image and Then focusOnFaces )
And the memory report The memory used so high.

What can do to reduce memory ?

1. When focusOnFaces is set.
2. When layoutSubviews is called.

Face detection is already quite expensive on resources, and to double up on that just isn't acceptable, especially with the number of apps out there now using this library.

If the frame changes aspect ratio, the visible image layer isn't recomputed with the new aspect ratio.

This is easiest to see on with a full-screen view that handles rotation on a long thin device like an iPhone 5, when you rotate from portrait to landscape the preserved pixels from the original image should be different between the two modes.

As the title says Xcode 9 gives me a nice title purple exclamation mark telling me that FaceAware is using a method where UIImageView.image is not run on the main thread.

RT~ wonderful kit!

Does it provide legacy Swift version support ?

Hi,

First of all — cool library, thanks for sharing it!

I’d like to use the Swift 2.3 version, what version should I refer to on my cocoa pods?

Thanks!

Hi @BeauNouvelle

Any idea why would I see the following issue: when focusOnFaces is set On I get a strange issue where the image is being seen for a brief moment, then it disappears and the re-apears. It all happens very fast but the issue is noticeable and happens every time.

Any thoughts maybe?