I'm trying to run sf and rgeos revdep checks with forthcoming GEOS 3.9.0, which presents itself as "3.9.0dev". This fails in old_sf_geos():

1. Error: works with self-intersections: sf (@test-fix_geo_problems.R#94)
2. Error: works with other problems: sf (@test-fix_geo_problems.R#106)

These fork on GEOS < 3.8.0 for good reason, but do not try to strip trailing string extensions to the declared version number. This only matters if you care about protecting yourselves from the radical changes coming in GEOS 3.9.0. Your code presupposes that the version number is normalised, which it will be when 3.9.0 is released, but then it will be too late to modify code ahead of time. The rgeos tests earlier in the same file all pass, so I think the irritant is just expecting the sf GEOS version string to be normalised.

Would be great if you could also pull in this dataset
https://catalogue.data.gov.bc.ca/dataset/hydrology-hydrometric-watershed-boundaries

No Project Lifecycle Badge found in your readme!

Hello! I scanned your readme and could not find a project lifecycle badge. A project lifecycle badge will provide contributors to your project as well as other stakeholders (platform services, executive) insight into the lifecycle of your repository.

What is a Project Lifecycle Badge?

It is a simple image that neatly describes your project's stage in its lifecycle. More information can be found in the project lifecycle badges documentation.

What do I need to do?

I suggest you make a PR into your README.md and add a project lifecycle badge near the top where it is easy for your users to pick it up :). Once it is merged feel free to close this issue. I will not open up a new one :)

To flesh out some plotting capabilities of bcmaps I wonder if it might be useful to have an "external to bc" layer. For example, we typically may plot the province using either bc_bound() or bc_bound_hres() like this:

If we had an outside_bc_border() layer like this:

We could combine them in instances where don't want BC floating on its own in space:

Is this something we'd want in bcmaps? Or is it better to leave up to a user to create?

Here is how I created the layer. I am still struggling with how to create a perfectly square box on a projected surface. Also I am currently sourcing the data from the raster package but this may not be a tenable long term solution to store over in bcmaps.rdata:

library(here)
library(raster)
library(bcmaps)
library(sf)
library(dplyr)
library(ggplot2) #dev



# Load spatial layers -----------------------------------------------------

data_path <- here("data")

canada_border <- raster::getData('GADM', country="CAN", path = data_path, level=1) 

usa_border <- raster::getData('GADM', country="USA", path = data_path, level=1) 

## Square box on projected surface
coords = list(matrix(c(-142, 61,
                       -138, 47,
                       -114, 47,
                       -110, 61,
                       -142, 61),
                ncol = 2,
                byrow = TRUE))

outside_bc_box <- st_polygon(coords) %>%
  st_sfc(crs = 4326) %>%
  transform_bc_albers() 


# Spatial manipulations ---------------------------------------------------

canada_border <- st_as_sf(canada_border) %>%
  transform_bc_albers()

usa_border <- st_as_sf(usa_border) %>%
  transform_bc_albers()


outside_bc_border <- rbind(canada_border, usa_border) %>%
  st_intersection(outside_bc_box) %>%
  filter(!NAME_1 == "British Columbia")


# Plots -------------------------------------------------------------------

ggplot() +
  geom_sf(data = bc_bound_hres(), fill = "purple") +
  theme_void()

ggplot() +
  geom_sf(data = outside_bc_border) +
  theme_void()

ggplot() +
  geom_sf(data = bc_bound_hres(), fill = "purple") +
  geom_sf(data = outside_bc_border) +
  theme_void()

Add Grizzly Bear Population Units to bcmaps + bcmapsdata — map layer is licensed OGL-British Columbia.

https://www.r-project.org/nosvn/R.check/r-oldrel-macos-x86_64/bcmaps-00check.html

If bcmaps.rdata is loaded (which isn't necessary, but inevitable), and you try something like:

get_layer(bc_bound)

it can look for the object bc_bound and all sorts of strange things can happen

add an argument to be able to specify the projection and have the output reprojected. By default it should be bcalbers and cded is not. Otherwise the output of the cded functions do not play nicely with the other bcmaps spatial objects.

ws <- bcdc_query_geodata("51f20b1a-ab75-42de-809d-bf415a0f9c62", crs = bcalb) %>%
  filter( WATERSHED_GROUP_CODE == "PARS") %>%
  collect() %>% st_as_sf()
dem.ws <- cded_raster(aoi = ws)
crs(dem.ws)
st_crs(ws)

A helpful addition to the package would be to have the basemaps from BCGW accessible through the package either at the different scales, or with an autoscale function if feasible.

I can see:

• fsa
• mapsheets_50K

There might be others too. I just entails updating the csv and then running create_internal_data.R.

Prepare for release:

• devtools::build_readme()
• Check current CRAN check results
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• urlchecker::url_check()
• Update cran-comments.md
• Polish NEWS

Submit to CRAN:

• usethis::use_version('patch')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version()

For example, regional_districts_analysis could be a function that downloads the data and builds the object. Would be a bit slow, and require internet access. Tradeoff on speed vs file size

Return for bcmaps::available_layers() is a list of map layer names and titles and then a list of shortcut_function() names—which are the same as the map layer name. Remove return of shortcut names and update documention.

I can see:

• fsa
• mapsheets_50K

There might be others too. I just entails updating the csv and then running create_internal_data.R.

and/or a link to a worked example

Thanks

As per email from Edzer:

sf, under consideration at CRAN, will
generate a NOTE in bcmaps checks:

• checking dependencies in R code ... NOTE
  Missing or unexported object: ‘sf::st_make_valid’
  consequently any code that will try to use sf::st_make_valid will break
  for the new sf, because this function has been moved to
  lwgeom::st_make_valid (as all other functions that use liblwgeom).
  package lwgeom is on CRAN, with binary OSX and Windows versions.

TL;DR

Topics greatly improve the discoverability of repos; please add the short code from the table below to the topics of your repo so that ministries can use GitHub's search to find out what repos belong to them and other visitors can find useful content (and reuse it!).

Why Topic

In short order we'll add our 800th repo. This large number clearly demonstrates the success of using GitHub and our Open Source initiative. This huge success means its critical that we work to make our content as discoverable as possible; Through discoverability, we promote code reuse across a large decentralized organization like the Government of British Columbia as well as allow ministries to find the repos they own.

What to do

Below is a table of abbreviation a.k.a short codes for each ministry; they're the ones used in all @gov.bc.ca email addresses. Please add the short codes of the ministry or organization that "owns" this repo as a topic.

That's in, you're done!!!

How to use

Once topics are added, you can use them in GitHub's search. For example, enter something like org:bcgov topic:citz to find all the repos that belong to Citizens' Services. You can refine this search by adding key words specific to a subject you're interested in. To learn more about searching through repos check out GitHub's doc on searching.

Pro Tip 🤓

• If your org is not in the list below, or the table contains errors, please create an issue here.

• While you're doing this, add additional topics that would help someone searching for "something". These can be the language used javascript or R; something like opendata or data for data only repos; or any other key words that are useful.

• Add a meaningful description to your repo. This is hugely valuable to people looking through our repositories.

• If your application is live, add the production URL.

Ministry Short Codes

NOTE See an error or omission? Please create an issue here to get it remedied.

Is it worth thinking about the future use cases of bcmaps versus bcdata? For map layers available with bcdata should users use that package to ensure always grabbing the most up-to-date versions (without any tinkering with bcmapsdata)? Perhaps bcmaps becomes the home for open layers from the 🇨🇦 open data catalogue, maps not available via WMS/WFS, and a set of helper functions (e.g. bc_neighbours())? Thoughts @ateucher @boshek?

Just updated my R to 3.5.1, and bcmaps is not available. Let me know if there's anything I can do to help.

Hello,

I'm trying to reproject a sf object (IAF_tnsct_sf - originally in epsg 4326) into Albers but the geometry seems off by 1000 and the x coords are positive when I do so. Any suggestions on how to fix this?

Thanks,
Joanna

OGR data source with driver: ESRI Shapefile
Source: "/Users/joburgar/Google Drive/20190629_iaf_jburgar/gis_1701scbat_iaf/03_t3_bioacoustics", layer: "abm_iaf_transect"
with 8 features
It has 16 fields
Integer64 fields read as strings: OID_ SymbolID
Warning message:
In readOGR(dsn = "./03_t3_bioacoustics", layer = "abm_iaf_transect") :
Z-dimension discarded

class(IAF_tnsct) # sp class
[1] "SpatialLinesDataFrame"
attr(,"package")
[1] "sp"

convert to sf object

IAF_tnsct_sf <- st_as_sf(IAF_tnsct)
class(IAF_tnsct_sf) # sf class
[1] "sf" "data.frame"

st_crs(IAF_tnsct_sf) # EPSG: 4326
Coordinate Reference System:
EPSG: 4326
proj4string: "+proj=longlat +datum=WGS84 +no_defs"
extent(IAF_tnsct_sf)
class : Extent
xmin : -123.0646
xmax : -121.3979
ymin : 49.00224
ymax : 49.34879

IAF_tnsct_sf_alb <- transform_bc_albers(IAF_tnsct_sf)
st_crs(IAF_tnsct_sf_alb) # EPSG: 3005
Coordinate Reference System:
EPSG: 3005
proj4string: "+proj=aea +lat_1=50 +lat_2=58.5 +lat_0=45 +lon_0=-126 +x_0=1000000 +y_0=0 +ellps=GRS80 +towgs84=0,0,0,0,0,0,0 +units=m +no_defs"
extent(IAF_tnsct_sf_alb)
class : Extent
xmin : 1214444
xmax : 1336605
ymin : 448779
ymax : 487261.3

Archive.zip

Hi,
This is a great package and I'm starting to use it more often.
I'm posting here to get input on mapping sub-regions of BC using ggplot with the bc_bound_hres().
Currently for quickly mapping I convert the lat/lon of my study area to UTM and enter in coord_sf(), e.g.:
ggplot() + geom_sf(bc_bound_hres(), fill = "grey", colour = "black") + coord_sf(xlim = c(600000, 800000), ylim = c(745000, 1000000))
If it is possible to set limits in lat/lon it would be faster and more intuitive, but I haven't figured out how best to do that yet. Pardon if there is an obvious way of doing this.
Cheers!

No Project Lifecycle Badge found in your readme!

Hello! I scanned your readme and could not find a project lifecycle badge. A project lifecycle badge will provide contributors to your project as well as other stakeholders (platform services, executive) insight into the lifecycle of your repository.

What is a Project Lifecycle Badge?

It is a simple image that neatly describes your project's stage in its lifecycle. More information can be found in the project lifecycle badges documentation.

What do I need to do?

I suggest you make a PR into your README.md and add a project lifecycle badge near the top where it is easy for your users to pick it up :). Once it is merged feel free to close this issue. I will not open up a new one :)

If there are missing values in the poly_field argument, the function will throw back a "cannot get an Extent object from argument y" error.

Use this layer: https://catalogue.data.gov.bc.ca/dataset/province-of-british-columbia-boundary-terrestrial

Access this way:
bcdc_get_data('30aeb5c1-4285-46c8-b60b-15b1a6f4258b', resource = '3d72cf36-ab53-4a2a-9988-a883d7488384')

This is a great addition and will really speed up the process when building maps 100 times when trouble shooting. I think it may be worthwhile to put 'layer file size' when given the option to download a layer. I have no idea how large they are but if they are 100 megs it may start impacting local HD space (for those of us with small SSD). Great work!

Started here

https://catalogue.data.gov.bc.ca/dataset/7b4fef7e-7cae-4379-97b8-62b03e9ac83d

This data is the TRIM DEM converted to the Canadian Digital Elevation Data (CDED)format.

The individual .dem resources/files are available by map tile folder, provisioned within multiple .zip & .zip.md5 folders.

'cc @dfilatow

All data are stored in 'EPSG:3005' but sf's representation of CRSs is changing. Calling sf::st_set_crs() in get_layer() will ensure current crs representation is always used.

Link to layer on DataBC: https://catalogue.data.gov.bc.ca/dataset/water-survey-of-canada-sub-sub-drainage-areas

A slightly less easily nameable dataset - possibly wsc_drainages

For consistency, ensure all proj4strings contain epsg:3005.

devtools::install_github("bcgov/bcmaps", build_vignettes = TRUE) as presented is before the bcmaps.rdata step so when R attempts to build the vignettes it looks for bcmaps.rdata which isn't install yet then fails.

Some data are directly drawn from the BC data catalogue using bcdata and therefore still have the bcdc_sf class:

library(bcmaps)
#> Loading required package: sf
#> Linking to GEOS 3.8.0, GDAL 3.0.4, PROJ 6.3.1

class(bc_cities())
#> bc_cities was updated on 2020-08-26
#> [1] "bcdc_sf"    "sf"         "tbl_df"     "tbl"        "data.frame"

We should strip that first class.

layers: bc_bound_hres, 2x watercourses

options:

• function(s) to download, process, and cache from Canada
• bundle in package (probably not feasible due to size)
• host as assets in a GH release similar to BEC and TSA

This layer should be renamed to better distinguish it from wsc_boundaries(). Actual prefix is pending additional research.

No Project Lifecycle Badge found in your readme!

Hello! I scanned your readme and could not find a project lifecycle badge. A project lifecycle badge will provide contributors to your project as well as other stakeholders (platform services, executive) insight into the lifecycle of your repository.

What is a Project Lifecycle Badge?

It is a simple image that neatly describes your project's stage in its lifecycle. More information can be found in the project lifecycle badges documentation.

What do I need to do?

I suggest you make a PR into your README.md and add a project lifecycle badge near the top where it is easy for your users to pick it up :). Once it is merged feel free to close this issue. I will not open up a new one :)

Pending the release of geom_sf a theme for bcmaps would be useful.

Examples (but not exactly what we after) include:

• https://andybeger.com/2012/08/25/scale-and-north-arrow-for-maps-in-r/
• https://github.com/paleolimbot/prettymapr

Hello Andy @ateucher, Stephanie @stephhazlitt and Sam @boshek ,
I encountered an issue when I was using bec() and tsa() functions. The error message was:

library(bcmaps)
library(bcmapsdata)
a <- bec()
Error in download_file_from_release(fname, fpath, release = release, force = force) : 
  No assets matching filename tsa.rds in latest release.

The session inform was:

`
R version 3.6.0 (2019-04-26)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18362)

Matrix products: default

locale:
[1] LC_COLLATE=English_Canada.1252 LC_CTYPE=English_Canada.1252
[3] LC_MONETARY=English_Canada.1252 LC_NUMERIC=C
[5] LC_TIME=English_Canada.1252

attached base packages:
[1] stats graphics grDevices utils datasets methods
[7] base

other attached packages:
[1] bcmapsdata_0.3.2 bcmaps_0.18.0 sf_0.8-0

loaded via a namespace (and not attached):
[1] Rcpp_1.0.3 class_7.3-15 rappdirs_0.3.1
[4] grid_3.6.0 R6_2.4.1 jsonlite_1.6
[7] DBI_1.1.0 magrittr_1.5 e1071_1.7-3
[10] units_0.6-5 KernSmooth_2.23-15 httr_1.4.1
[13] curl_4.3 tools_3.6.0 compiler_3.6.0
[16] classInt_0.4-2
`
Any idea where the problem is? Please let me know if you need more information for debuging. Thank you very much.

Yong

your personal access token using libcurl/7.64.1 r-curl/4.3 httr/1.4.1 was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/repositories/107592256/releases

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated.

Depending on your API usage, we'll be sending you this email reminder once every 3 days for each token and User-Agent used in API calls made on your behalf.
Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.

Prepare for release:

• devtools::build_readme()
• Check current CRAN check results
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• revdepcheck::revdep_check(num_workers = 4)
• urlchecker::url_check()
• Update cran-comments.md
• Polish NEWS

Submit to CRAN:

• usethis::use_version('major')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version()
• Tweet

Just noticed that the Natural Resource Districts layer (called with the bcmaps function bcmaps::nr_districts()) is an old version of the districts. The data catalogue has a newer version (found here: https://catalogue.data.gov.bc.ca/dataset/natural-resource-nr-district).

The only difference is that the Vanderhoof and Fort St. James districs have been merged into a single district named Stuart Nechako.

Great package as always - my go to for quick access to pretty maps!

Hello,
was very excited to see this repo. I read through the list, but didn't find support for boundaries for health service system units (please see http://www2.gov.bc.ca/gov/content/data/geographic-data-services/land-use/administrative-boundaries/health-boundaries).
I am a postdoctoral researcher, starting to look at surveillance and monitoring at provincial level and searching for the maps the correspond to these boundaries. I am specifically looking for something that can work in R and ggplot universe.

Need to add a force argument here:

So that we can force download a layer if needed. Good to provide the option.

@ateucher is force the right name for that argument?

From CRAN:

Checking this on Linux creates and leaves behind

~/.local/share/bcmaps

in violation of the CRAN Policy's

Packages should not write in the user’s home filespace (including
clipboards), nor anywhere else on the file system apart from the R
session’s temporary directory (or during installation in the location
pointed to by TMPDIR: and such usage should be cleaned up). Installing
into the system’s R installation (e.g., scripts to its bin directory)
is not allowed.

Limited exceptions may be allowed in interactive sessions if the
package obtains confirmation from the user.

For R version 4.0 or later (hence a version dependency is required or
only conditional use is possible), packages may store user-specific
data, configuration and cache files in their respective user
directories obtained from tools::R_user_dir(), provided that by
default sizes are kept as small as possible and the contents are
actively managed (including removing outdated material).

Can you please change as necessary, ideally using the
tools::R_user_dir() mechanism where available?

Please fix before 2021-01-26 to safely retain your package on CRAN.

We are using rappdirs::user_data_dir(), which on Unix uses ~/.local/share/<appname>.

Perhaps we should use tools::R_user_dir() (R >= 4.0) or rappdirs::user_cache_dir() which uses ~/.local/cache/<appname>?

From the help for tools::R_user_dir(), it creates an R subfolder in the user/cache directory (~/.local/cache/R/<appname> - hopefully rappdirs can do the same for R < 4.0.

Attempt to use bcdata to get them and cache

They should show up in available_layers and have alias functions that look the same as all the others.

E.g. "bec" should show up in the output of available_layers(), bec() should work, and get_layer("bec") should work.

UPDATE 2020-09-21: I've posted R CMD check output for another package. Please discard this issue.

Hi, I run revdep checks where I force packages to use 'multisession' futures instead of 'sequential' by default. This will help assert that the package work in parallel processing. When I did this for your package, the following error popped up:

$ export R_FUTURE_PLAN=multisession
$ R CMD check https://cran.r-project.org/src/contrib/bcmaps_0.18.1.tar.gz
...