Comments (8)
purkhusid
commented on June 25, 2024
I also encountered this when updating some oci_image targets in our WORKSPACE file.
from target-determinator.
mark-thm
commented on June 25, 2024
Good call -- can also confirm I'm seeing this for oci_pull defined repos in MODULE.bazel.
from target-determinator.
illicitonion
commented on June 25, 2024
I've been debugging this, bazelbuild/bazel#20757 is what I've worked out so far.
from target-determinator.
illicitonion
commented on June 25, 2024
I can't repro this with oci_pull - if you don't think the above linked issue encapsulates what you're seeing, can you post a minimal repro repo somewhere I can debug in?
from target-determinator.
mark-thm
commented on June 25, 2024
Here's a minimal repro on Bazel 7.1.1: https://github.com/mark-thm/td-81
Running target-determinator HEAD~1 with t-d 0.26.0 produces no changed targets -- the hash for the image base was changed, though.
from target-determinator.
mark-thm
commented on June 25, 2024
Running bazel cquery 'deps(//:test)' seems to produce different results between the commits:
5101a964cf6257720ac70242d03349b328d7585d (first commit)
//:test (7170974)
@ubuntu//:ubuntu (7170974)
@bazel_tools//tools/sh:toolchain_type (7170974)
@rules_oci//oci/private:image.sh (null)
@@aspect_bazel_lib~//lib:jq_toolchain_type (7170974)
@@bazel_tools~sh_configure_extension~local_config_sh//:local_sh (7170974)
@@rules_oci~~oci~oci_crane_darwin_arm64//:crane_toolchain (7170974)
@platforms//os:windows (bcfe008)
@rules_oci//oci:registry_toolchain_type (7170974)
@rules_oci//oci:crane_toolchain_type (7170974)
@@rules_oci~~oci~oci_crane_darwin_arm64//:registry_toolchain (7170974)
@@aspect_bazel_lib~~ext~jq_darwin_arm64//:jq_toolchain (7170974)
@local_config_platform//:host (bcfe008)
@rules_oci//oci/private:empty.tar (null)
@platforms//os:os (bcfe008)
@platforms//os:osx (bcfe008)
@@rules_oci~~oci~oci_crane_darwin_arm64//:crane (null)
@@aspect_bazel_lib~~ext~jq_darwin_arm64//:jq (null)
@@rules_oci~~oci~oci_crane_darwin_arm64//:launcher.sh (null)
@platforms//cpu:aarch64 (bcfe008)
@@rules_oci~~oci~ubuntu_single//:ubuntu_single (7170974)
@platforms//cpu:cpu (bcfe008)
@@aspect_bazel_lib~//lib:copy_to_directory_toolchain_type (7170974)
@@rules_oci~~oci~ubuntu_single//:blobs/sha256/52882761a72a60649edff9a2478835325d084fb640ea32a975e29e12a012025f (null)
@@rules_oci~~oci~ubuntu_single//:oci-layout (null)
@@rules_oci~~oci~ubuntu_single//:blobs/sha256/2af372c1e2645779643284c7dc38775e3dbbc417b2d784a27c5a9eb784014fb8 (null)
@@rules_oci~~oci~ubuntu_single//:index.json (null)
@@rules_oci~~oci~ubuntu_single//:blobs/sha256/a8b1c5f80c2d2a757adc963e3fe2dad0b4d229f83df3349fbb70e4d12dd48822 (null)
@@aspect_bazel_lib~~ext~copy_to_directory_darwin_arm64//:copy_to_directory_toolchain (7170974)
@@aspect_bazel_lib~~ext~copy_to_directory_darwin_arm64//:copy_to_directory (null)
2342255c560181e19246b2f7046542970a486430 (second commit)
//:test (7170974)
@ubuntu//:ubuntu (7170974)
@bazel_tools//tools/sh:toolchain_type (7170974)
@rules_oci//oci/private:image.sh (null)
@@aspect_bazel_lib~//lib:jq_toolchain_type (7170974)
@@bazel_tools~sh_configure_extension~local_config_sh//:local_sh (7170974)
@@rules_oci~~oci~oci_crane_darwin_arm64//:crane_toolchain (7170974)
@platforms//os:windows (bcfe008)
@rules_oci//oci:registry_toolchain_type (7170974)
@rules_oci//oci:crane_toolchain_type (7170974)
@@rules_oci~~oci~oci_crane_darwin_arm64//:registry_toolchain (7170974)
@@aspect_bazel_lib~~ext~jq_darwin_arm64//:jq_toolchain (7170974)
@local_config_platform//:host (bcfe008)
@rules_oci//oci/private:empty.tar (null)
@platforms//os:os (bcfe008)
@platforms//os:osx (bcfe008)
@@rules_oci~~oci~oci_crane_darwin_arm64//:crane (null)
@@aspect_bazel_lib~~ext~jq_darwin_arm64//:jq (null)
@@rules_oci~~oci~oci_crane_darwin_arm64//:launcher.sh (null)
@platforms//cpu:aarch64 (bcfe008)
@@rules_oci~~oci~ubuntu_single//:ubuntu_single (7170974)
@@rules_oci~~oci~ubuntu_single//:blobs/sha256/bf3dc08bfed031182827888bb15977e316ad797ee2ccb63b4c7a57fdfe7eb31d (null)
@platforms//cpu:cpu (bcfe008)
@@aspect_bazel_lib~//lib:copy_to_directory_toolchain_type (7170974)
@@rules_oci~~oci~ubuntu_single//:blobs/sha256/49b384cc7b4aa0dfd16ff7817ad0ea04f1d0a8072e62114efcd99119f8ceb9ed (null)
@@rules_oci~~oci~ubuntu_single//:oci-layout (null)
@@rules_oci~~oci~ubuntu_single//:index.json (null)
@@aspect_bazel_lib~~ext~copy_to_directory_darwin_arm64//:copy_to_directory_toolchain (7170974)
@@rules_oci~~oci~ubuntu_single//:blobs/sha256/d21429c4635332e96a4baae3169e3f02ac8e24e6ae3d89a86002d49a1259a4f7 (null)
@@aspect_bazel_lib~~ext~copy_to_directory_darwin_arm64//:copy_to_directory (null)
diff
21a22
> @@rules_oci~~oci~ubuntu_single//:blobs/sha256/bf3dc08bfed031182827888bb15977e316ad797ee2ccb63b4c7a57fdfe7eb31d (null)
24c25
< @@rules_oci~~oci~ubuntu_single//:blobs/sha256/52882761a72a60649edff9a2478835325d084fb640ea32a975e29e12a012025f (null)
---
> @@rules_oci~~oci~ubuntu_single//:blobs/sha256/49b384cc7b4aa0dfd16ff7817ad0ea04f1d0a8072e62114efcd99119f8ceb9ed (null)
26d26
< @@rules_oci~~oci~ubuntu_single//:blobs/sha256/2af372c1e2645779643284c7dc38775e3dbbc417b2d784a27c5a9eb784014fb8 (null)
28d27
< @@rules_oci~~oci~ubuntu_single//:blobs/sha256/a8b1c5f80c2d2a757adc963e3fe2dad0b4d229f83df3349fbb70e4d12dd48822 (null)
29a29
> @@rules_oci~~oci~ubuntu_single//:blobs/sha256/d21429c4635332e96a4baae3169e3f02ac8e24e6ae3d89a86002d49a1259a4f7 (null)
from target-determinator.
illicitonion
commented on June 25, 2024
This will be fixed in Bazel 7.2.0 by bazelbuild/bazel#21939 - I've just verified with your repro :)
from target-determinator.
mark-thm
commented on June 25, 2024
Thanks! Sorry it took so long to put something together.
from target-determinator.
Related Issues (20)
- Consider exposing an aspect CLI plugin HOT 1
- Add documentation to build target-determinator & driver from source HOT 1
- Should driver rebuild non-test targets? HOT 1
- Add --keep_going flag HOT 3
- [driver] bazel-opts are not passed to test command
- targets incompatible with the current platform are selected HOT 5
- bazel-opts are not passed to bazel-config command HOT 2
- deadlock in hashTarget -> build.Target_RULE -> hashRule HOT 6
- With Bazel 6 and bzlmod configured rules_python, target determinator complains of invalid characters HOT 2
- Bazel errors with --transitions=lite
- target-determinator does not evaluate aliases as changed HOT 2
- Enhancement: make it possible to print debug logs of what's being hashed
- Invalid options syntax error HOT 2
- Possible circular configurations? HOT 6
- When using with bzlmod rules_python encounter error with Bazel 6.4.0
- Provide an option to override bazel command HOT 2
- Support -enforce-clean=enforce-clean for when the "before" location is unclean HOT 2
- --enforce-clean accepts a tri-state value but only has boolean behaviour HOT 1
- TargetHashCache has already been frozen HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from target-determinator.