Comments (3)
illicitonion
commented on September 27, 2024
2
I've released this flag as v0.15.0: https://github.com/bazel-contrib/target-determinator/releases/tag/v0.15.0
from target-determinator.
illicitonion
commented on September 27, 2024
Thanks for trying out target-determinator and providing this feedback!
I think it makes sense to expose a --bazel-opts flag, just like --bazel-startup-opts to allow specifying your own flags.
I don't think we should specially add support for --keep_going, because target-determinator aims to be "always correct", and definitely can't guarantee correctness in the face of query errors.
But adding the ability for users to specify their own flags makes sense - I can put together a PR doing this soon.
from target-determinator.
amit-mittal
commented on September 27, 2024
Thanks for the prompt response! That makes sense. I'll try it again as soon as the change is in.
from target-determinator.
Related Issues (20)
- Should driver rebuild non-test targets? HOT 1
- [driver] bazel-opts are not passed to test command
- targets incompatible with the current platform are selected HOT 5
- bazel-opts are not passed to bazel-config command HOT 2
- deadlock in hashTarget -> build.Target_RULE -> hashRule HOT 6
- With Bazel 6 and bzlmod configured rules_python, target determinator complains of invalid characters HOT 2
- Bazel errors with --transitions=lite
- target-determinator does not evaluate aliases as changed HOT 2
- Enhancement: make it possible to print debug logs of what's being hashed
- Invalid options syntax error HOT 2
- Possible circular configurations? HOT 6
- When using with bzlmod rules_python encounter error with Bazel 6.4.0
- Provide an option to override bazel command HOT 3
- In Bazel 7 diffs involving 3rd party deps seem to be ignored HOT 9
- Support -enforce-clean=enforce-clean for when the "before" location is unclean HOT 2
- --enforce-clean accepts a tri-state value but only has boolean behaviour HOT 1
- TargetHashCache has already been frozen HOT 3
- Unclean checkout problem HOT 5
- Interest in making this `go install`-able? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from target-determinator.