Comments (1)
Non-test targets are correctly identified by
target_determinator
but appear skipped by the driver.
They should end up being built; if you bazel test //some:binary //some:test
, bazel should build both targets, but only run the second test - your build should fail if //some:binary
fails to build. Do you have an example you can share where this isn't the case?
I wonder if it would be better to split the targets by build / test targets.
In general I wouldn't recommend that, as you'll lose parallelism - some of the build and test could otherwise be done in parallel, and now will be forced to be serialised.
For our CI, I'm thinking of using
target_determinator
to get all the targets, then writing our own driver that does both build / test (not just test).
target-determinator was very intentionally written as a building block to make it easy to integrate into your own custom driver, because in my experience most organisations have subtly different desires from their workflows - honestly the bundled driver
was meant more as an example of how to do this rather than something most people would pick up off the shelf, but in the hopes that it's sufficient for many smaller organisations' use-cases without needing further customisation. If it's broken in some way (and I would count "doesn't fail in the case of build failures" as broken), I'd be very happy to write or review a fix, but it's also intended that folks can build their own more complex logic around it if they prefer :)
from target-determinator.
Related Issues (20)
- Add documentation to build target-determinator & driver from source HOT 1
- Add --keep_going flag HOT 3
- [driver] bazel-opts are not passed to test command
- targets incompatible with the current platform are selected HOT 5
- bazel-opts are not passed to bazel-config command HOT 2
- deadlock in hashTarget -> build.Target_RULE -> hashRule HOT 6
- With Bazel 6 and bzlmod configured rules_python, target determinator complains of invalid characters HOT 2
- Bazel errors with --transitions=lite
- target-determinator does not evaluate aliases as changed HOT 2
- Enhancement: make it possible to print debug logs of what's being hashed
- Invalid options syntax error HOT 2
- Possible circular configurations? HOT 6
- When using with bzlmod rules_python encounter error with Bazel 6.4.0
- Provide an option to override bazel command HOT 2
- In Bazel 7 diffs involving 3rd party deps seem to be ignored HOT 8
- Support -enforce-clean=enforce-clean for when the "before" location is unclean HOT 2
- --enforce-clean accepts a tri-state value but only has boolean behaviour HOT 1
- TargetHashCache has already been frozen HOT 2
- Unclean checkout problem HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from target-determinator.