barbagroup / aeropython Goto Github PK

This needs to be changed. We should not use a variable 'pi' to mean a panel, because this keyword should be reserved for 3.1415...

In Lessons 7 (method of images) and 8 (source sheet), the methods velocity and stream_function should return the 2D arrays of the velocity field and streamfunction, instead of storing them as attributes of the object.

The method should return the contribution of a source point on a given Cartesian mesh-grid; no need to store the velocity field and streamfunction.

For example:

Instead of

def stream_function(self, X, Y):
        self.psi = (self.strength / (2 * math.pi) *
                    numpy.arctan2((Y - self.y), (X - self.x)))

write

def stream_function(self, X, Y):
        psi = (self.strength / (2 * math.pi) *
                  numpy.arctan2((Y - self.y), (X - self.x)))
        return psi

Change name 'panel' into 'panels'.

Because it is a list of panels, not just one.

Now that display() is a built-in, we don't need calls like from IPython.display import display

See: http://blog.jupyter.org/2017/05/31/release-of-ipython-5-4-6-1-and-rlipython-2/

This isn't really an issue, but a suggestion you may like. In HyperPython, I used markdown cells to insert images; i.e.

![caption](./figures/figure.png)

This avoids the need to have a code cell above the image (the image appears in place of the markdown cell). However, it only works if the figures are in the directory from which the notebook was launched or one of its subdirectories. For this reason, I moved the lessons to the root directory so nobody would make the mistake of launching the notebook from a directory below that. Alternatively, you could have

/aeropython/lessons/resources/

Make sure that all mathematical equations are correctly rendered with nbviewer (links provided in the README of the repository).