badisi / ngx-safe-subscribe Goto Github PK

Package is not bundled while building an Angular app for production

Version:
1.0.2 & 2.0.5

How to reproduce:
ng serve --prod

Results:
[error in console]: TypeError: Object(...)(...).safeSubscribe is not a function

npm ERR! code E404
npm ERR! 404 Not Found: @badisi/ngx-safe-subscribe

Hello Badisi,

Great code, thanks for sharing!

I am having an issue when using a setter for a Component's property.

_myElement: myElement;

@Output()
myElementChange = new EventEmitter<myyElement>();

@Input()
get myElement() {
	return this._myElement;
}

set myElement(newVal: myElement) {    
	if (this._myElement === newVal) { return; }
	this._myElement = newVal;
	this.cd.markForCheck();
	this.myElementChange.emit(this._myElement);
}

When calling this.myElementChange.emit(this._myElement);, the console shows the "should implement OnDestory..." warning.

Any thoughts on how to handle safeSubscribe in this situation?