Add dir-name about fs HOT 9 CLOSED

Gave it a try here https://github.com/pesterhazy/presumably/blob/master/posts/howto-babashka.md#find-project-folder

from fs.

I mentioned dirname in the docs of parent now.

from fs.

OK, PR welcome for dir-name (as we have file-name, I think the hyphen would be ok?)

Note that seq works on the result of fs/path to split the components, but we could add this as a built-in.

I believe we already have split-list as split-paths in fs.

from fs.

Note that seq works on the result of fs/path to split the components, but we could add this as a built-in.

Oh, I didn't realize this. Thanks for explaining! And there turns out to be fs/components, which works like split-path except for the return type. Sorry I didn't look thoroughly enough before filing an issue. I missed it in API.md, probably because other file path APIs had primed me to look for different function names. (Maybe it needs a Ctrl+f-friendly note like "Use this to split a path.")

While I can't right now, I will PR dir-name when I can. (I agree it needs a hyphen.)

from fs.

On second thought: dir-name is already kind of there as: (-> file fs/parent str). parent is the Java terminology of getting the parent directory from a file and str is the way of turning a file or path into a string. Not sure if we need to add (defn dir-name [file] (-> file fs/parent str))?

We could also add a cheat sheet of bash terminology -> fs terminlogy.

cc @pesterhazy

from fs.

except for the return type

You can fix this by doing (map str ...).

from fs.

Oops, I missed not one but two of the two functions I wanted. :-) With fs/parent there is no need for fs/dir-name. If nobody disagrees, I suggest closing the issue.

We could also add a cheat sheet of bash terminology -> fs terminlogy.

This is a great idea. Thanks for starting one, @pesterhazy.

from fs.

parent is alright, but one has to be careful: (parent "hello.clj") returns nil, while dirname "hello.clj" is '.'

from fs.

We could change that perhaps

from fs.