suggestion: fs/find-up about fs HOT 5 CLOSED

I've seen another variation of find-up recently which had slightly other requirements than the proposed version. That confirmed me in my feelings that this function shouldn't yet be in fs itself, but just implemented in user space since there is no commonly agreed understanding of what this function should do.

from fs.

Another approach could just be to split this function into multiple smaller primitives, like fs/parents after which it's pretty easy to find matching files in each directory above:

(require '[babashka.fs :as fs])

(defn absolute-parent [x]
  (some-> x fs/absolutize fs/parent str))

(def parent-dirs (take-while some? (iterate absolute-parent (absolute-parent "."))))

(def git-ignores (keep #(let [git-ignore (fs/path % ".gitignore")]
                          (when (fs/exists? git-ignore) (str git-ignore))) parent-dirs))
(prn git-ignores)

from fs.

What about passing an explicit directory from where to search up?
I have a function in clj-kondo where I needed that: https://github.com/clj-kondo/clj-kondo/blob/8d1531b23485815ab26a7da10eac9950ecc2338d/src/clj_kondo/impl/core.clj#L199-L218

Some alternatives: lazy sequence of all matches going up, could also be another function find-up-all or so.

from fs.

What about passing an explicit directory from where to search up?

Indeed. Will draft something, also to see the edgecases...

Some alternatives: lazy sequence of all matches going up, could also be another function find-up-all or so.

Could be possible with (iterate #(fs/find-up "foo" %) (fs/cwd)) but otherwise dedicated fn indeed.

from fs.

This kind of feels like an inverse to fs/glob to me.

Perhaps something like this could do the trick:

(fs/glob-up "." "**/deps.edn" {:max-depth 3})
;; "." => start at the current directory
;; "**/deps.edn" => match deps.edn files in all directories searched
;; {:max-depth 3} => go a maximum of 3 levels up

I'd expect fs/glob-up to only match in parent directories. So

(fs/glob-up (fs/path (fs/expand-home "~") "dev" "babashka" "fs") "**/*.edn" {:max-depth 2})

should match all EDN files in ~/dev/babashka/fs, ~/dev/babashka and ~/dev.

I'm not quite sure about the name :max-depth, but I don't have any other options.

from fs.