UnsupportedOperationException when using `copy-tree` with zip file path as source about fs HOT 5 OPEN

I still would like to use copy-tree to extract resources from a jar

copy-tree has been written with normal files in mind.

Have you tried the unzip function? jar files are basically just zip files

from fs.

Thank you for the feedback. Yes, I know the unzip function, but it does not allow to extract a sub tree from the zip/jar file.

A possibility for sub-tree extraction could be an option named sub-tree-root (or similar) to unzip, or, more generically, to have 2 options :include-entry? and resolve-entry to control the behaviour of unzip. For the normal case, these 2 options would be

{:include-entry? (constantly true)
 :resolve-entry (fn [^Path output-path ^Path entry-path]
                  (.resolve output-path entry-path))}

and for sub tree extraction, they would be (where sub-tree-root is the Path to be extracted)

{:include-entry? (fn [^Path entry-path]
                   (fs/starts-with? entry-path sub-tree-root))
 :resolve-entry  (fn [^Path output-path ^Path entry-path]
                   (.resolve output-path (.relativize sub-tree-root entry-path)))}

from fs.

Sounds like an idea. With zip we already have the option :path-fn which resolves a path to a zip entry. In hindsight :path->entry would have been a better name (and we can support this new name while deprecating the old one).

Then we could have: :unzip-entry? and :entry->path to do what you suggest above.

from fs.

nice.
should I give a try at a PR?

from fs.

yes please!

from fs.