Giter Club home page Giter Club logo

simplemap's People

Contributors

arnaudbroes avatar contactashish13 avatar ekojr avatar michaeltorbert avatar stanislavsa avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

simplemap's Issues

Make sure we comply with Google Maps API usage guidelines

This is from a contact form submission on May 26th, 2016 from Chase Anderson ([email protected]):

I received an email from a Google maps support rep. They advised a few problems with the maps api usage in the plugin. I wanted to share their feedback with you here. Please let me know if you plan on supporting changes according to their information:

Please note you can remove the sensor paramter as it is no longer required. Also the version you specified is wrong, and this parameter isn't mandatory. You can check the documentation to learn more about versioning https://developers.google.com/maps/documentation/javascript/versions.

Verify we're enqueuing scripts using the correct method

This is in relation to Premium Support Forum post here - http://support.simplemap-plugin.com/discussions/problems/2478-map-not-loading

Specifically, the map is broken because of a jQuery issue in the custom theme. The developer of the custom theme responded with this:

Our theme can't use the default jquery provided by WordPress, and we have de-registered this one and registered a new one from CDN using the same key "jquery"

The issue with the SimpleMap plugin is because they enqueue the scripts using the "template_redirect" hook, which is run right after our deregistered hook is placed, so the script has as dependency the "jquery" file, and because of the step of execution there is no "jquery" on the dependency manager, so their scripts are not enqueued

This is not best WordPress practice, you should use proper hooks

More / better hooks

More / better hooks - add one for the Search form content before it's generated

Fix compatibility issue with WPML

I received this email from Yuk at WPML:

We are currently retesting compatibility of your plugin with WPML. We have found common issue related to showing locations from all languages.

Usually this can be easily fixed by adding 'suppress_filters' => false, to your post query.

Please take a look and fix this so I can send WPML an updated version of SimpleMap to test.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.