Giter Club home page Giter Club logo

Comments (6)

wpsmort avatar wpsmort commented on July 28, 2024

I believe there should be code for this in SimpleMap v2.5.

from simplemap.

EkoJR avatar EkoJR commented on July 28, 2024

I also added new style classes to allow users more control over the customization.

  • location_search_prev_page - Used with the Prev link
  • location_search_next_page - Used with the Next link
  • location_search_page_num - Used with the Page Number Text

Thinking about it now, may need to cancel PR #229 to add additions to Light & Dark CSS files. Even if there is no styling, would it be best to make those additions to .css files?

from simplemap.

wpsmort avatar wpsmort commented on July 28, 2024

@EkoJR We should use the standard classes for CSS which can be found here - https://codex.wordpress.org/Pagination. You should be able to test with Twenty Sixteen or Twenty Seventeen themes and the styling should be the same as the rest of the pagination in the theme.

I tested PR #231 but the Next and Prev links didn't do anything and there were no JS errors in the browser console.

from simplemap.

wpsmort avatar wpsmort commented on July 28, 2024

@EkoJR I have tested this and found that when you click on Prev or Next nothing happens
Also, the number of locations displayed per page should be taken from the Number of Results to Display in SimpleMap > General Options. So if I set that option to No Limit or anything higher than the number of locations I have then no pagination should be displayed.

For example, if I have 5 locations and I set Number of Results to Display to 10 then there should be no pagination because there's only 5 locations which is less than the 10 set in Number of Results to Display.

from simplemap.

wpsmort avatar wpsmort commented on July 28, 2024

@EkoJR I tested this and the pagination works fine now. However, the search no longer outputs only matching locations, instead it seems to output locations outside of the search criteria. For example, if I have 6 locations within 10 miles of ZIP code 27540 and I search based on that criteria, the paginated search results actually outputs 10 locations which include locations in other States and other countries.

from simplemap.

wpsmort avatar wpsmort commented on July 28, 2024

This is tested and is working fine. This is ready for a code review. The branch with the latest commits is https://github.com/EkoJr/simplemap/tree/issue-5

from simplemap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.