Comments (6)
I believe there should be code for this in SimpleMap v2.5.
from simplemap.
I also added new style classes to allow users more control over the customization.
- location_search_prev_page - Used with the Prev link
- location_search_next_page - Used with the Next link
- location_search_page_num - Used with the Page Number Text
Thinking about it now, may need to cancel PR #229 to add additions to Light & Dark CSS files. Even if there is no styling, would it be best to make those additions to .css files?
from simplemap.
@EkoJR We should use the standard classes for CSS which can be found here - https://codex.wordpress.org/Pagination. You should be able to test with Twenty Sixteen or Twenty Seventeen themes and the styling should be the same as the rest of the pagination in the theme.
I tested PR #231 but the Next and Prev links didn't do anything and there were no JS errors in the browser console.
from simplemap.
@EkoJR I have tested this and found that when you click on Prev or Next nothing happens
Also, the number of locations displayed per page should be taken from the Number of Results to Display in SimpleMap > General Options. So if I set that option to No Limit or anything higher than the number of locations I have then no pagination should be displayed.
For example, if I have 5 locations and I set Number of Results to Display to 10 then there should be no pagination because there's only 5 locations which is less than the 10 set in Number of Results to Display.
from simplemap.
@EkoJR I tested this and the pagination works fine now. However, the search no longer outputs only matching locations, instead it seems to output locations outside of the search criteria. For example, if I have 6 locations within 10 miles of ZIP code 27540 and I search based on that criteria, the paginated search results actually outputs 10 locations which include locations in other States and other countries.
from simplemap.
This is tested and is working fine. This is ready for a code review. The branch with the latest commits is https://github.com/EkoJr/simplemap/tree/issue-5
from simplemap.
Related Issues (20)
- Add Read More link to search results
- Add option to enter Google Maps Geocode API HOT 5
- Locations are no longer geocoded when inserted HOT 11
- SImplemap not loading any locations HOT 6
- Simple Map stopped working on our website?? not sure what to do . 2.5.0.1 version of simple maps is We updated our app, our WP version is 5.0.1 we are on HOT 1
- Simple Map locater not working HOT 4
- Premium Support button not working HOT 2
- Remove lang directory and its contents
- Add option to display search form below map
- Locations not geocoded when API Key has application restrictions in place HOT 2
- Maps API and Geocode API don't support same restrictions
- Add license key field for EDD
- Integrate EDD code to validate license key
- EDD support for Tender app or switch to bbPress HOT 1
- Migrate old licenses to EDD
- International Zip Codes Not Matching Correct Locations HOT 1
- Set default category
- Fix mixed content resources loaded over HTTP
- Add a Back button to the single location page HOT 1
- Remove all buy now links and change support details HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simplemap.