athieriot / drone-artifactory Goto Github PK

View Code? Open in Web Editor NEW

10.0 10.0 12.0 5.43 MB

Drone plugin for publishing build artifacts to Artifactory

License: Apache License 2.0

JavaScript 95.64% Makefile 0.78% Standard ML 3.58%

drone-artifactory's People

Contributors

Stargazers

Watchers

Forkers

mircobordoni a-buck dstgermain mceyberg ccwillia ganeshksankar automaticgiant k0nserv amarbright aninditamajumdar renatoribeiro-hotmart prasadareti143

drone-artifactory's Issues

Simplify configuration required to upload maven artifacts

Hi there,

I was wondering if we could simplify the use of the artifactory plugin for uploading maven artifacts. With maven I could run:

mvn deploy

Maven would look at the pom, build the jar and upload the pom.xml and jar to artifactory.

With the artifactory plugin, I have to specify:

artifactory:
      url: my_companies_artifactory.com
      username: $$username
      password: $$password
      pom: pom.xml
      force_upload: true
      files:
        - pom.xml
        - target/*.jar

Could the plugin be updated so theoretically all that is required is:

artifactory:
      url: my_companies_artifactory.com
      username: $$username
      password: $$password
      pom: pom.xml
      force_upload: true

or if the jar is packaged to a non standard location
perhaps:

artifactory:
      url: my_companies_artifactory.com
      username: $$username
      password: $$password
      pom: pom.xml
      force_upload: true
      jar: target/custom_directory/executable.jar

This would reduce the risk of anyone forgetting to upload the pom.xml along with the artifact as well as making it easier to use.

I would be happy to have a go at implementing this if you think it's a worthwhile thing to do.

Lack of DRONE_VERSION

So I think the DRONE_VERSION environment variable was removed from Drone at some point between 0.5 and 0.8. This causes the plugin to go down the pre 0.5 code path and fail despite the fixes in #19 and #20. I've asked in the issue that requested the variable be introduced. harness/drone#1415

Examples of using the plugin

I am fairly new to drone, and i am struggling with using this plugin, either i can get drone to run successfully but completely skip anything related to the artifactory plugin, or it gives me an obscure error.

For example, if my entire .drone.yml looks like this:

pipeline:
  artifactory:
    image: athieriot/drone-artifactory
    url: [url]
    username: $$USERNAME
    password: $$PASSWORD
    pom: pom.xml
    repo_key: [repo_key]
    files:
      - target/*.jar
      - target/*.war
      - dist/**/*.min.js

the output of the drone run is:

username@80e6500b67fa:MobileAPI-- (joe_artifactory)$ drone exec
Running Matrix job #0

if i have my entire .drone.yml file looking like this:

pipeline:
  test:
    image: maven:alpine
    commands:
     - mvn --quiet --batch-mode test
     
  publish_war:
    image: maven:alpine
    commands:
      - mvn --batch-mode clean install
  deploy_war:
    plugin:
      artifactory:
        image: athieriot/drone-artifactory
        url: [url]
        username: $$USERNAME
        password: $$PASSWORD
        pom: pom.xml
        force_upload: true
        repo_key: [repo_key]
        files:
          - /root/.m2/repository/com/company/DEV/something-services/1/somehting-services-1.war

then everything prior to the deploy_war step runs successfully. What am I missing?

athieriot / drone-artifactory Goto Github PK

drone-artifactory's People

Contributors

Stargazers

Watchers

Forkers

drone-artifactory's Issues

Simplify configuration required to upload maven artifacts

Lack of DRONE_VERSION

Examples of using the plugin

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent