Giter Club home page Giter Club logo

Comments (5)

athieriot avatar athieriot commented on June 17, 2024

Hi there,

It's quite a good idea. Let's me resume. Would it be enough to:

  • If you specify a pom by property, upload it automatically as if it were a file.
  • Changing the default files value to be [target/*.jar]

I would like to keep the files property instead of jar if you don't mind cause I use the plugin a lot for war as well and all sorts of -sources- and -doc-

What we could do as well is to accept a single entry for it as well as a list.

What do you think?

from drone-artifactory.

a-buck avatar a-buck commented on June 17, 2024

Hi @athieriot, thanks for the comments. I think that's reasonable. I'd like to have a go at this but will wait till your pull request is merged as i think conflicts would be likely due to the amount of refactoring

Thanks!

from drone-artifactory.

athieriot avatar athieriot commented on June 17, 2024

Thank you !

from drone-artifactory.

a-buck avatar a-buck commented on June 17, 2024

Hi @athieriot, I've raised pull request #7

On reflection I don't think it's worth adding a default value for target/*.jar....it's not functionality i need at the moment either. What do you think? I think it's a bit of a specific scenario and assumes that the user is using maven rather than being build tool agnostic.

from drone-artifactory.

athieriot avatar athieriot commented on June 17, 2024

If it's something you don't really need then I think you are right.

Even, I would be quite curious to see if the plugin, in its current state, is working fine with non-Maven artefacts

from drone-artifactory.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.