[Question][Deployment] Webhook: <no value> is allowed for required? about incubator-devlake HOT 2 CLOSED

Hey @thiDucTran! I'm here to help you with any questions or issues you have. Let's work together to solve the problem.

Yes, it is expected behavior for the pipeline_id, repo_url, and commit_sha parameters in the webhook plugin for deployments to allow <no value> or null.

• The pipeline_id field is marked as required and cannot be null or empty.
• The repo_url and commit_sha fields are not marked as required, but at least one of them must be provided.

Here is the relevant code snippet:

if request.DeploymentCommits == nil {
    if request.CommitSha == "" || request.RepoUrl == "" {
        return errors.Convert(fmt.Errorf("commit_sha or repo_url is required"))
    }
    // create a deployment_commit record
    deploymentCommit := &devops.CicdDeploymentCommit{
        DomainEntity: domainlayer.DomainEntity{
            Id: GenerateDeploymentCommitId(connection.ID, request.PipelineId, request.RepoUrl, request.CommitSha),
        },
        // other fields...
    }
    // other logic...
}

This ensures that while pipeline_id is mandatory, repo_url and commit_sha can be null or empty, but at least one of them must be provided ^[1].

To continue the conversation, mention @dosu.

from incubator-devlake.

nevermind..seems that it is inserting the literal value <no value> into the DB I am dynamically grabbing these values via annotations ...and not doing it correctly..but instead of passing "" or null ..it is passing in the literal value <no value>

from incubator-devlake.