Giter Club home page Giter Club logo

Comments (1)

dosubot avatar dosubot commented on July 3, 2024 2

Hey there, @usharerose! I'm here to assist you with any bugs, questions, or contributions you have in mind. Let me know how I can help while we wait for a human maintainer.

To ensure that the GitLab plugin normalizes account-related ID values for the Convert MR Assignees and Convert MR Reviewers subtasks in the Domain Layer data, the code should use the didgen.NewDomainIdGenerator function. This function generates domain-specific IDs for the merge requests, which are then used to create normalized PullRequestAssignee and PullRequestReviewer objects.

Here is the relevant code snippet that demonstrates this normalization process for both assignees and reviewers:

mrIdGen := didgen.NewDomainIdGenerator(&models.GitlabMergeRequest{})

converter, err := helper.NewDataConverter(helper.DataConverterArgs{
    RawDataSubTaskArgs: *rawDataSubTaskArgs,
    InputRowType:       reflect.TypeOf(models.GitlabAssignee{}),
    Input:              cursor,
    Convert: func(inputRow interface{}) ([]interface{}, errors.Error) {
        mrAssignee := inputRow.(*models.GitlabAssignee)
        domainPrAssigne := &code.PullRequestAssignee{
            PullRequestId: mrIdGen.Generate(data.Options.ConnectionId, mrAssignee.MergeRequestId),
            AssigneeId:    mrAssignee.AssigneeId,
            Name:          mrAssignee.Name,
            UserName:      mrAssignee.Username,
        }
        return []interface{}{
            domainPrAssigne,
        }, nil
    },
})

converter, err := helper.NewDataConverter(helper.DataConverterArgs{
    RawDataSubTaskArgs: *rawDataSubTaskArgs,
    InputRowType:       reflect.TypeOf(models.GitlabReviewer{}),
    Input:              cursor,
    Convert: func(inputRow interface{}) ([]interface{}, errors.Error) {
        mrReviewer := inputRow.(*models.GitlabReviewer)
        domainPrReviewer := &code.PullRequestReviewer{
            PullRequestId: mrIdGen.Generate(data.Options.ConnectionId, mrReviewer.MergeRequestId),
            ReviewerId:    mrReviewer.ReviewerId,
            Name:          mrReviewer.Name,
            UserName:      mrReviewer.Username,
        }
        return []interface{}{
            domainPrReviewer,
        }, nil
    },
})

In this code:

  • mrIdGen := didgen.NewDomainIdGenerator(&models.GitlabMergeRequest{}) creates a new domain ID generator for GitLab merge requests.
  • mrIdGen.Generate(data.Options.ConnectionId, mrAssignee.MergeRequestId) and mrIdGen.Generate(data.Options.ConnectionId, mrReviewer.MergeRequestId) generate normalized domain-specific IDs for each merge request assignee and reviewer, respectively.
  • The generated PullRequestId is then used to create PullRequestAssignee and PullRequestReviewer objects, ensuring that the ID values are normalized in the Domain Layer data [1][2].

Additionally, the ConvertAccounts function in the Convert Users subtask demonstrates a similar normalization process for GitLab accounts, ensuring consistency across different types of data [3].

To continue talking to Dosu, mention @dosu.

from incubator-devlake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.