If I create an AMTagView, set the accessoryImage, set the text with setupWithText, and then add the tag to the tag list view, the frame of the tag gets shortened so that the text label is truncated.

The problem is in addTagView, where it recalculates the frame size for the tag. This recalculation doesn't take into account a possible accessory image.

Hi @andreamazz

First congrats for the project and thanks for sharing.

I started to try this code and would like to know how to limit the number o tags in the tag list view ? For example for only 4 tags. In the current project the view generates a scroll view and so tags keep filling the view. In My case I would like to limit the number of tags to two "lines" of tags at maximum. So the tag list view wouldn't need a scroll view.

Would this change too much your current code ? Could you describe briefly how to implement that using the current code ?

Thanx again and cheers!

Anyone meet it?

Hello and first of all thank you for your work here. I implemented this in a project I am working on and did a pod update and received this error on compile:

I just have implemented your awesome lib into our project. However, it's supporting only iOS7. Can you please add the support of iOS6 as well. Thank you very much. Looking forward your response.

Is there any solution to center the tags horizontally instead of the Left or Right alignment?

Things I'd like if you're adding tests for this project during Cocoapod's Test Jam

Tooling: Specta/Expecta

Areas to look at:

• Improve coverage
• Add coveralls.io

the rearrangeTags inside the layoutSubviews causes the scrollview to lag when it tries to go to the last row.
plus while scrolling it calls continuously the rearrangeTags.
if you remove the rearrangeTags it works as it should

Hi @andreamazz

I tried without success to link this project to Parse backend.
In one view I would like to add the tags and save them to Parse with a save button and in another view, load them from Parse.

Any suggestion ?

I have an AMTagListView configured with auto layout in a storyboard. The AMTagListView resizes properly on device rotation, but the array of AMTagViews contained therein do not rearrange to expand from portrait to horizontal.

I am assuming that rearrangeTags would be the first place to poke around. Is this correct?
Any help you could provide would be greatly appreciated.

Thanks in advance

Thanks for the great work. I just met a problem when I add this library to my project. There will be parse error like "unknown type name 'NSString'", I have no idea why this happen. Any suggestion?

Instead of tagListView.addTags:(["my tag", "some tag"]) it should be tagListView.addTags(["my tag", "some tag"]).

A wished request.

Is it possible to estimate the height of an AMTagListView if needed to show all tags which could be increased/decreased dynamically?

Hi,
I was trying to use two AMTagListView, for example ,AMTagListView1 and AMTagListView2,

when I click one AMTagListView1 , removeTag on AMTagListView1, and add this tag to AMTagListView2, but it's not working properly, can you have a check with this issue?

Thanks

Hello and thanks for the open source lib.
I have one question regarding the tagColor property.
Is there a way to change it in real time?
i mean i have set it up using:

[[AMTagView appearance] setTagColor:...];

but when i change the theme of my app i would like for it to change along with all other components. Can i do that without recreating the whole object?

thanks

The problem seems to be that setupWithText runs before setAccessoryImage gets called.

Would be nice if there was on touch up listener with a delegate call back

Hi
I start using your library in one of our project. I checked the API but could not find if we can arrange tags from bottom to top inside tag view. any help will be appreciated!

Its really great control.
But i would like to know which tags user has finally decided to keep it on screen.

How to know didSelcted Index?

Client should be able to specify a horizontally or vertically scrolling tag list view.

Many times me and our team open form where we using AMTagViewList with textfield. And always when we need input new tag we tap to AMTagViewList (this happening automaitcally, by instinct), not to textfield upper. Maybe we add button to add tag in AMTagListView ?

I'm trying to notify some app class when a tag was deleted by user. I didn't find any event triggered when this happens so don't see you can detect it.

I could do the change and create a pull request in case it's not implemented and you think it could help other people.

Thanks

Hey!

I have list of my tags. Every tag has 2 states: selected and deselected. I'm tracking selection of my tags in separate NSMutableArray. Of course when those 2 states have different colors (reversed). I noticed that I had send setNeedsLayout message to AMTagView object to redisplay textColor properly:

    self.selectedTags = [NSMutableArray array];

    [self.tagListView addTags:@[@"my tag", @"some tag"]];
    [self.tagListView setTapHandler:^(AMTagView *view) {

        BOOL contains = [self.selectedTags containsObject:[view tagText]];
        contains ? [self.selectedTags removeObject:[view tagText]] : [self.selectedTags addObject:[view tagText]];  // is there better way to track selected tags?

        if (contains) {
            [view setInnerTagColor:[UIColor whiteColor]];
            [view setTextColor:[UIColor redColor]];
        } else {
            [view setInnerTagColor:[UIColor redColor]];
            [view setTextColor:[UIColor whiteColor]];
        }
        [view setNeedsLayout]; // <-- here have to do it manually
    }];

My question is: Maybe it could be worth to override setTextColor method in AMTagView?

- (void)setTextColor:(UIColor *)textColor {
    _textColor = textColor;
    [self setNeedsLayout];
}

Hi !
I have an issue in rearrangeTags on this line : [self addSubview:obj];

Sometimes I got this exception :
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSArrayM insertObject:atIndex:]: object cannot be nil'

But when I do this to debug :

if (obj != nil) {
            NSLog(@"add %@", obj.tagText);
            [self addSubview:obj];
        }

the NSLog print the good tagText and I got the same error so I don't understand...
Thanks for your help !

Developer should be able to use custom tag view, built from scratch, without subclassing AMTagView. This feature could bring much more flexibility to the library.

Hi, slick control!

I used pod try AMTagListView and chose option 2. I built using Xcode 6.1.1 (6A2008a), and ran using an iPhone 5s (8.1) simulator.

When hitting enter, the UITextField does empty, and the tag is created, but it never appears on screen.
After peeking under the hood I found this offending line of code:

Is there a reason for this line? After removing it things work properly, but I feel shady just removing lines of code without fully understanding the entire project.

Awesome control btw, thanks for sharing it! :D

Hello,
when it is expected to have support for iOS 9 / xcode 7 and Swift 2?
Thanks for the great library!

I don't know how I do this, but this is real mistake :)

In iPhone 5, XCode 5.1.1 and iOS 7.1.1, there are White horizontal line in middle of the tag as per the image below:

would you mind to provide a simple Swift example. I keep running into all kind of issues trying to add the control (likely because I'm a noob). Thx in advance.

It would be nice to be able to specify an array of images. Because I needed this for my current project, I hacked something up here: https://github.com/andreamazz/AMTagListView/compare/master...emmerge:multiple_images?expand=1 If this is of general interest, I can turn this into something that would be backwards compatible with the single accessory image for a pull request.

hi
i used Tags insde view inside table cell, but i can't select cell from table to get details (push to another view). and if i tap on cell (outSide of tagsView) work fine.

It would be nice If tags can have multiline support just like labels, then this issue will be fixed. Is this feature already available?

I would like to increase the height of each tag in the taglistview..

one way would be to increase the font size, but I would like to keep the font size at 12points but have the height be 30points.. any idea?

In order to identify the tags in the tapHandler callback, it's sometimes necessary for some meta-information that we don't want to display. It would be nice to be able to attach a black-box object to the tag that can be accessed in the tap handler.

#3 This issue's solution tells that you can get the content size after you've created the tag list view, but I have a situation where I need it before. Can you please write a method which calculates that? I tried to look into your files, but there are a couple of interesting lines over there.

Is there any way to do borders instead of fill color?

Lets say I have a below setup:

• An AMTagListView named as tagListView.
• An AMTagView named as tag1. The text for the tag is "Custom" and it has an accessory image. Below is the code for tag creation and adding it to tagListView:

AMTagView *tag1 = [[AMTagView alloc] initWithFrame:CGRectZero];
[tag1 setAccessoryImage:[UIImage imageNamed:@"close"]];
[tag1 setupWithText:@"Custom"];
[self.tagListView addTagView:tag1];

So when the tag list view shows up on screen, the frame of the tag1: {{10, 39}, {82, 29}}

I wrote a tap handler which does nothing but just resets the text to same text. Code below:

[self.tagListView setTapHandler:^(AMTagView *view) {
     [view setTagText:[NSString stringWithFormat:@"%@", view.tagText]];
}];

If I check the frame after setTagText, it shows up as {{211, 0}, {106, 30}}

This happens because when we use addTagView to add tag to the tagListView, the addTagView method recalculates the width of the tag as shown below:

- (UIView<AMTag> *)addTagView:(UIView<AMTag> *)tagView andRearrange:(BOOL)rearrange {
    if ([tagView isKindOfClass:[AMTagView class]]) {
        UIFont *font = [[[tagView class] appearance] textFont];
        CGSize size = [((AMTagView *)tagView).tagText sizeWithAttributes:@{NSFontAttributeName: font}];
        CGPoint padding = [[[tagView class] appearance] textPadding];
        float tagLength = [[[tagView class] appearance] tagLength];
        size.width = (int)size.width + padding.x * 2 + tagLength;
        size.height = (int)size.height + padding.y;
        size.width = MIN(size.width, self.frame.size.width - self.marginX * 2);
        tagView.frame = (CGRect){{0, 0}, {size.width, size.height}};`
    }
[self.tags addObject:tagView];

We use setupText: or setTagText: to modify the text for the tag that has already been added. Since the tag has already been added, we don't use addTagView: method and hence the above calculation doesn't happen.

As a workaround, I am adding and removing the tag after modifying the text so that it maintains the same padding.

Is this the expected behavior?

Would it be possible to add this to a UITableViewCell?

It would be great if there was a way to show tags in horizontal direction with number of rows.

Brief intro

My app uses your control on each view controller in UIPageViewController. Recently, I detected that there’s a memory leak when scrolling in PageViewController.

I’ve used CRChecker to detect possible retain cycles and troublesome controls, and the analysis indeed shows that your control definitely has this problem.

Possible sources

After brief source inspection I detected few possible sources:

• - [AMTagListView setup] contains this code:

  self.orientationNotification = [center addObserverForName:UIDeviceOrientationDidChangeNotification object:nil queue:nil usingBlock:^(NSNotification *note) {
      [self rearrangeTags];
  }];
      self.tagNotification = [center addObserverForName:AMTagViewNotification object:nil queue:nil usingBlock:^(NSNotification *notification) {
      if (self == notification.userInfo[@"superview"]) {
          if (_tapHandler) {
              self.tapHandler(notification.object);
          }
      }
  }];
  

• - [AMTagListView rearrangeTags] contains this one:

  [self.tags enumerateObjectsUsingBlock:^(AMTagView* obj, NSUInteger idx, BOOL *stop) {
  size = obj.frame.size;
  [self.subviews enumerateObjectsUsingBlock:^(UIView* obj, NSUInteger idx, BOOL *stop) {
      if ([obj isKindOfClass:[AMTagView class]]) {
          maxY = MAX(maxY, obj.frame.origin.y);
      }
  }];
  
  [self.subviews enumerateObjectsUsingBlock:^(UIView* obj, NSUInteger idx, BOOL *stop) {
      if ([obj isKindOfClass:[AMTagView class]]) {
          if (obj.frame.origin.y == maxY) {
              maxX = MAX(maxX, obj.frame.origin.x + obj.frame.size.width);
          }
      }
  }];
  
  // Go to a new line if the tag won't fit
  if (size.width + maxX > (self.frame.size.width - self.marginX)) {
      maxY += size.height + self.marginY;
      maxX = 0;
  }
  obj.frame = (CGRect){maxX + self.marginX, maxY, size.width, size.height};
      [self addSubview:obj];
  }];
  

There is link to self in both - [NSNotificationCenter addObserverForName:object:queue:usingBlock] and [NSArray enumerateObjectsUsingBlock:].
And blocks always retain all captured variables.

So now we have a strong reference to AMTagListView that keeps that object in memory until the block object is deallocated.

Possible solution

You should pass weak pointers to self, instead of strong ones.

But …

I’m not sure that the problem is limited to these two cases, so you should check your code further for any other possible sources of memory leaks.

Firstly, thank you soo much for this great library. It's exactly what I need!!

I wouldn't like to have any 'tail' element for any of the AMTagView objects. How do I do this?

This issue (as can be shown in the image attached) was not reproduced on other iOS8 devices (4S,5,5S)