alfredbaudisch / godotphoenixchannels Goto Github PK

I might be very wrong about this, so please school me if I need it! :D

This signal:

_error = channel.connect("on_join_result", self, "_on_Channel_join_result")

Doesn't seem to be firing at all.
I've been able to work around it by manually triggering from the on_channel_event signal.

I believe it has something to do with the _join_ref.
I wonder if the join is called multiple times, redefining the _join_ref and then it fails to match when the first call responds?

My network implementation:

https://github.com/Comyune/game-drifter/blob/b5cc26a024d460ccfd47d0bc351051fb26fcea7e/godot-project/Network.gd

Here is some context from my live streams of the issue:

• https://youtu.be/0JiaN38gO7c?t=4692

• https://youtu.be/0JiaN38gO7c?t=4076

• https://youtu.be/W3m7-6FV0KE?t=23485

Basic demo

• Socket
• Channel
• Presence
• Push event
• Free channel and socket node
• Remove old demo

What do you think is required before this can be published to the Godot AssetLib?

I'm happy to help if you'd like someone to add unit tests to what is already there perhaps... or additional testing & docs!

• "void" functions
• The parameters of some functions do not have declared types yet

The code in branch 4.0 has formatting/styling inconsistencies, like parameter commas without spacing added by the Godot 4.0 project converter:

https://github.com/alfredbaudisch/GodotPhoenixChannels/blob/4.0/Phoenix/Scripts/Channel.gd#L45: func _init(socket,topic : String,params : Dictionary = {},presence = null):

Make it consistent with the rest of the code.

Including push timeout

• Channel join error and join error rejoin
• Socket connect error
• Channel push error

The demo implemented with #16 showcases the features of the library, but not exactly a game.

I am unable to get the demo to connect: _on_Socket_error: {message:connection error}