adobe / aio-apps-action Goto Github PK

It is unclear that this is a CI action, or a Github action, and NOT a runtime action.
Suggestions: aio-apps-gh-action, aio-apps-ci-cd, aio-apps-devops, ..?

Expected Behaviour

Test PR on windows os.

Actual Behaviour

I get the error below:

• [email protected]
  added 511 packages from 350 contributors in 38.737s
  C:\windows\system32\cmd.exe /D /S /C "C:\npm\prefix\aio.cmd app test"
  child_process.js:127
  p.open(fd);
  ^

Error: EBADF: bad file descriptor, uv_pipe_open
at Object._forkChild (child_process.js:127:5)
at setupChildProcessIpcChannel (internal/bootstrap/pre_execution.js:334:30)
at prepareMainThreadExecution (internal/bootstrap/pre_execution.js:57:3)
at internal/main/run_main_module.js:7:1 {
errno: -4083,
code: 'EBADF',
syscall: 'uv_pipe_open'
}
» Error: Command failed with ENOENT: jest --passWithNoTests ./test
» spawn jest ENOENT
Error: The process 'C:\npm\prefix\aio.cmd' failed with exit code 2

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Trigger GitHub action on Windows os

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

The following steps all output warnings about unexpected inputs:

• Setup CLI (example)
• Auth (example)
• Build (example)
• Deploy (example)

Looks like these inputs need to be defined in this repo's action.yml (See GH docs here)

When users deploy an extension using this action, they have to supply IMS Auth

Right now the action is only set up to support jwt credentials as it explicitly uses the private key and still uses the meta_scopes parameter when setting up the context in ims

We should add support for using OAuth credentials with this action since jwt has been deprecated

Right now, using the SCOPE environment variable is not intuitive. When requesting one scope, users can submit a single value. However, when requesting multiple scopes, users have to create a secret in their repository where the scopes they'd like to request are enclosed in brackets and double-quoted:

GitHub Secret

["scope1", "scope2"]

Not only should this be documented, but users should be able to create their SCOPE secret with a variety of syntaxes. The following are all reasonable:

• scope1,scope2
• 'scope1','scope2'
• ['scope1','scope2']

Expected Behaviour

Actual Behaviour

With new extension support app deploy needs token to update endpoints. Although token is set by GH action auth command but CI/CD workflow to deploy aio app fails with token validation (as no token expiry info is available in CI env)

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

Steps to Reproduce

1. Create a Firefly Project aio app init and check options: actions, web assets and CI/CD.
2. Push your project on Github
3. Edit README.md and open a PR

The PR checks will fail because of

Also I noticed that the E2E tests won't run by default. What do you recommend if devs want to include E2E tests into the pipeline ?

Unit tests are missing.

Expected Behaviour

Workflows for test and deploy succeed

Actual Behaviour

Workflows for test and deploy fail on auth step.

https://github.com/hannessolo/test-aio-working-directory/actions/runs/4480318641/jobs/7875446748

Reproduce Scenario (including but not limited to)

1. Create a new app: aio app init test-app --standalone-app
2. Select only actions as the modules
3. Check that the github workflow files were added
4. Push the code to a new repository on github
5. Add secrets as documented here https://developer.adobe.com/app-builder/docs/guides/deployment/ci_cd_for_firefly_apps/#github-secrets
6. Re-run the workflow if needed
7. See that it failed https://github.com/hannessolo/test-aio-working-directory/actions/runs/4480318641/jobs/7875446748

Logs taken while reproducing problem

https://github.com/hannessolo/test-aio-working-directory/actions/runs/4480318641/jobs/7875446748

1. The auth command is not documented. Please also add text to say that this is used to generate an IMS token to publish to the extension registry. See https://github.com/adobe/generator-aio-app/blob/97619bfd0f7a5fe3c635f415043e7c4d2297a045/generators/add-ci/.github/workflows/deploy_stage.yml#L30-L40 (but with noPublish: true you won't need to have this command in your Github Actions workflow)
2. The deploy command noPublish input is not documented. Please also add text to say that these extra parameters https://github.com/adobe/generator-aio-app/blob/97619bfd0f7a5fe3c635f415043e7c4d2297a045/generators/add-ci/.github/workflows/deploy_stage.yml#L52-L57 are needed for publishing to the Extension Registry (but with noPublish: true you won't need them)

Expected Behaviour

Code is executed once on ubuntu-latest.

Actual Behaviour

os matrix is used, implying that other os' could be added, which will cause the code to run more than once.
The actual action code checks if it is running in ubuntu and will 'do less' if it is not, but it should just not happen.

@zeit/ncc is no longer maintained. Please use @vercel/ncc instead.

Since parsedScopes or the default scope will be an array. Currently fixing this issue in #48

Can you confirm my understanding here @MichaelGoberling, @sandeep-paliwal ? Thanks

When running the current GH workflow to deploy an app, there's warning

Error: The `set-env` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

see https://github.com/icaraps/test-firefy-gh-workflow/runs/1357966726#step:6:8

It might come from an underlaying dependency https://github.com/actions/toolkit/search?q=set-env.

Expected Behaviour

App gets deployed with CI CD.

Actual Behaviour

Deployment fails with error "imsOrgId must be defined"

Reproduce Scenario (including but not limited to)

1. Create a standalone app using aio CLI that has action only

Steps to Reproduce

1. Create a standalone app with action only
2. Make sure github workflow yml is configured as per documentation
3. Deploy using github CI CD

Platform and Version

Sample Code that illustrates the problem

Attached screenshots of code structure and how deployment yml looks like.

Logs taken while reproducing problem