adobe / aio-apps-action Goto Github PK
View Code? Open in Web Editor NEWGitHub action to perform aio app build test deploy workflows
Home Page: https://www.adobe.io
License: Apache License 2.0
GitHub action to perform aio app build test deploy workflows
Home Page: https://www.adobe.io
License: Apache License 2.0
With new extension support app deploy needs token to update endpoints. Although token is set by GH action auth command but CI/CD workflow to deploy aio app fails with token validation (as no token expiry info is available in CI env)
Right now, using the SCOPE environment variable is not intuitive. When requesting one scope, users can submit a single value. However, when requesting multiple scopes, users have to create a secret in their repository where the scopes they'd like to request are enclosed in brackets and double-quoted:
GitHub Secret
["scope1", "scope2"]
Not only should this be documented, but users should be able to create their SCOPE secret with a variety of syntaxes. The following are all reasonable:
scope1,scope2
'scope1','scope2'
['scope1','scope2']
aio app init
and check options: actions, web assets and CI/CD.The PR checks will fail because of
Also I noticed that the E2E tests won't run by default. What do you recommend if devs want to include E2E tests into the pipeline ?
It is unclear that this is a CI action, or a Github action, and NOT a runtime action.
Suggestions: aio-apps-gh-action
, aio-apps-ci-cd
, aio-apps-devops
, ..?
When running the current GH workflow to deploy an app, there's warning
Error: The `set-env` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
see https://github.com/icaraps/test-firefy-gh-workflow/runs/1357966726#step:6:8
It might come from an underlaying dependency https://github.com/actions/toolkit/search?q=set-env.
When users deploy an extension using this action, they have to supply IMS Auth
Right now the action is only set up to support jwt credentials as it explicitly uses the private key and still uses the meta_scopes parameter when setting up the context in ims
We should add support for using OAuth credentials with this action since jwt has been deprecated
@zeit/ncc is no longer maintained. Please use @vercel/ncc instead.
App gets deployed with CI CD.
Deployment fails with error "imsOrgId must be defined"
Attached screenshots of code structure and how deployment yml looks like.
auth
command is not documented. Please also add text to say that this is used to generate an IMS token to publish to the extension registry. See https://github.com/adobe/generator-aio-app/blob/97619bfd0f7a5fe3c635f415043e7c4d2297a045/generators/add-ci/.github/workflows/deploy_stage.yml#L30-L40 (but with noPublish: true
you won't need to have this command in your Github Actions workflow)deploy
command noPublish
input is not documented. Please also add text to say that these extra parameters https://github.com/adobe/generator-aio-app/blob/97619bfd0f7a5fe3c635f415043e7c4d2297a045/generators/add-ci/.github/workflows/deploy_stage.yml#L52-L57 are needed for publishing to the Extension Registry (but with noPublish: true
you won't need them)Line 149 in ff82a68
Since parsedScopes
or the default scope will be an array. Currently fixing this issue in #48
Can you confirm my understanding here @MichaelGoberling, @sandeep-paliwal ? Thanks
Code is executed once on ubuntu-latest.
os matrix is used, implying that other os' could be added, which will cause the code to run more than once.
The actual action code checks if it is running in ubuntu and will 'do less' if it is not, but it should just not happen.
Unit tests are missing.
Workflows for test and deploy succeed
Workflows for test and deploy fail on auth step.
https://github.com/hannessolo/test-aio-working-directory/actions/runs/4480318641/jobs/7875446748
aio app init test-app --standalone-app
https://github.com/hannessolo/test-aio-working-directory/actions/runs/4480318641/jobs/7875446748
Test PR on windows os.
I get the error below:
Error: EBADF: bad file descriptor, uv_pipe_open
at Object._forkChild (child_process.js:127:5)
at setupChildProcessIpcChannel (internal/bootstrap/pre_execution.js:334:30)
at prepareMainThreadExecution (internal/bootstrap/pre_execution.js:57:3)
at internal/main/run_main_module.js:7:1 {
errno: -4083,
code: 'EBADF',
syscall: 'uv_pipe_open'
}
» Error: Command failed with ENOENT: jest --passWithNoTests ./test
» spawn jest ENOENT
Error: The process 'C:\npm\prefix\aio.cmd' failed with exit code 2
Trigger GitHub action on Windows os
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.