zyanfx / genuinechannels Goto Github PK

This will cause problems with MSI installers not installing the DLL on updates if the default update process is used: it only compares DLL versions.
Expected: DLL version should be in sync with NuGet package version.

Reported here: GenuineChannels#1

Hi,
We've discovered an issue if you disable logging during a remoting call using
Belikov.GenuineChannels.Logbook.GenuineLoggingServices.StopLogging();

ie, if you call a method on the server object that calls the StopLogging method, there is a null reference exception.

I've managed to trace this to GenuineUniversalServerTransportSink.HandleIncomingMessage

It gets the binaryLogWriter at the beginning of the method, and then after passing the call to the _nextChannelSink, it attempts to use this.ITransportContext.BinaryLogWriter which is now null.

adding
binaryLogWriter = message.ITransportContext.BinaryLogWriter;

just before
switch (serverProcessing)
fixes the issue

Looks like DXM should be portable (no BinaryFormatter/RealProxy/etc).
Can it be extracted to a PCL project? .NET Core? Xamarin?

If yes, then it might be worth breaking GC Nuget into parts like this:

• GC.Core — portable part
• GC.Remoting — legacy part
• GC.WCF — channel wrappers for WCF and whatnot
• etc.

Add unit tests to make sure that malicious payloads are detected.

GC library is currently decoupled from SharpZipLib.
But does it connect fine to the original .NET 2.0 version of GC?

If in a IPv6 environment it happened the gtcp Uri might look like that:
gtcp://[fec0:0:0:ffff::1%251]:1235

Uri parts are:
Scheme: gtcp
Host: fec0:0:0:ffff::1%1
Port: 1235

As described in RFC 6874 (https://tools.ietf.org/html/rfc6874)
If used within a URI, a literal IPv6 address is always embedded between "[" and "]" and
Zone IDs have to be URL encoded ("%" ==> "%25").

✈️ 👽 ⚛ 🏆 ☣️ 📖 🐛 💡 🚅 🌵 🐫 📷 🎥 ♣️ 🦀 ☸️ 🗡 🇩🇪 🌳 🎲 ♦️ 📃 🎓 ✴️ ✳️ 💎 🐐 👻 🐬 🐙 🕷 🎸 ♥️ 🌺 📥 ℹ️ 📱 🇮🇹 🏮 🎃 👺 🏯 👖 🕹 🃏 🕋 🔑 🗝 ⌨️ 👘 🏷 🍃 📒 🚈 🔒 🍭 ➿ 🍀 🔍 🍖 🎖 🏅 🍈 🎤 🌌 📴 🗻 ⛰ 🚵 🚠 🏔 🍄 💪 🎹 🎵 🎼 🏞 👔 ❎ 🌃 🔩 ⭕️ 🌊 🅾️ 🍢 ✡️ 👹 🏢 🌾 🛢 👌 🆗 🚔 ☂️ 📙 🌄 🐂 📦 📟 🖌 ☮️ 🖊 ✏️ ☎️ 🖨 ❓ 🌜 🐇 🐎 ♻️ 🎀 🎑 🍙 🤖 🚀 🎢 🚨 🇷🇺 🏉 🎽 🈂️ 🍶 🏫 🎒 ✂️ 🦂 💺 🌱 ☘ 📶 🎿 ⛷ 💀 ☠️ ⛸ 🛩 🌤 🌥 🐌 🐍 ❄️ ⛄️ ☃️ 🏟 ⭐️ ⚽️ 👾 ♠️ ❇️ 🎇 🎾 💬 🚤 🕸 🌞 💦 🔣 🌮 🍵 📞 🔭 ⛺️ 💭 🎫 ⏲ 🎟 🗼 🍅 🚜 🚋 🚥 🖲 👕 🌷 🦃 🐢 📺 🔀 ☔️ ⛱ ☂️ 🦄 ⚱ 🍹 🚦 👰 📳 📹 🎮 🌋 🆚 🖖 🌘 🌖 🚾 🏋️ 🐳 🐋 ☸️ ♿️ 🎐 🌬 🍷 🐺 🔧 ✍️ 🛠 ⚡️ 0️⃣ 💤

When FIPS is enabled on windows 10, the communication stops,
is GC support FIPS ?

thanks