Giter Club home page Giter Club logo

goodreads-profile-workflow's Issues

Last 5 books doesn't get choosed correct

I configured a "Last 5 Books I've Read" section but the books which appear are not actually the books which are the last 5 books but books which I read lying further in the past. What are the criterias for the algorithm for picking the last 5 books?

TypeError: Cannot read properties of undefined (reading 'channel')

Hi Simon,

Very cool idea with the Goodreads workflow! Thank you for your work there.

I wanted to use it to spice up my own GitHub README but experienced the following error when running the job manually:

TypeError: Cannot read properties of undefined (reading 'channel')

Screenshot from GitHub Actions:
image

This is my workflow in .github/workflows/goodreads-profile-workflow.yml:

name: Latest book list from a goodreads
on:
  schedule:
    - cron: "* * * * 1"
  workflow_dispatch:
jobs:
  update-readme-with-goodreads-books:
    name: Update this repo's README with what you're currently reading
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: zwacky/[email protected]
        with:
          goodreads_user_id: "89343805"
          shelf: "currently-reading"

These are my lines in my README.md file:

<h3>๐Ÿ“š Books I'm currently reading:</h3>
<!-- GOODREADS-LIST:START -->
<!-- GOODREADS-LIST:END -->

My Goodreads ID is correct. Maybe it has something to do with my profile settings on Goodreads?

Thank you in advance for any pointers on how to getting it to run! :)

Build for v1.2.0 is broken

Please let me first state that I am not a Javascript developer.

Node 12 has a problem with the generated build file dist/index.js. I have pasted here the GitHub Action error ouput:

Run zwacky/goodreads-profile-workflow@main
  with:
    goodreads_user_id: 117462291
    shelf: read
    template: - [$title]($url) by $author
    comment_tag_name: GOODREADS-READ-SHELF
    sort_by_fields: >user_rating,>average_rating
    max_books_count: 10
    readme_file_path: ./README.md
    output_only: false
/home/runner/work/_actions/zwacky/goodreads-profile-workflow/main/dist/index.js:6
`):(this.indentate=function(){return""},this.tagEndChar=">",this.newLine=""),this.options.supressEmptyNode?(this.buildTextNode=Xo,this.buildObjNode=Jo):(this.buildTextNode=Wr,this.buildObjNode=Yr),this.buildTextValNode=Wr,this.buildObjectNode=Yr}Fe.prototype.parse=function(e){return this.j2x(e,0).val};Fe.prototype.j2x=function(e,r){let t="",n="",s=Object.keys(e),i=s.length;for(let u=0;u<i;u++){let o=s[u];if(typeof e[o]!="undefined")if(e[o]===null)n+=this.indentate(r)+"<"+o+"/"+this.tagEndChar;else if(e[o]instanceof Date)n+=this.buildTextNode(e[o],o,"",r);else if(typeof e[o]!="object"){let c=this.isAttribute(o);c?t+=" "+c+'="'+this.options.attrValueProcessor(""+e[o])+'"':this.isCDATA(o)?e[this.options.textNodeName]?n+=this.replaceCDATAstr(e[this.options.textNodeName],e[o]):n+=this.repl

But, If I run the file localy using node 14 I don't see such error.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.