zsoldosp / django-act-as-auth Goto Github PK

see TODO at https://github.com/PaesslerAG/django-act-as-auth/blob/master/djactasauth/views.py#L29

entering username superuser/someuser/ raises ValueError('too many values to unpack',)

suspicious places from the stacktrace

• djactasauth/backends.py:64 in _authenticate
• auth_username, act_as_username = username.split(self.sepchar)
• forms.ActAsAuthenticationForm.full_clean - when calling super

probably simply raising a validation error would be sufficient rather, backend._authenticate should return None see #15

and instead of modifying _authenticate, we could modify is_act_as_username to check for exactly one sepchar

from django.views.decorators.debug import sensitive_post_parameters

@Eorhim - it looks like you attempted to push 0.5.3 to Pypi but it didn't take. Is this something that needs extra help? I ask because the lack of Django 2.2 is a pain. (Yes, I can reference the git repo instead of Pypi, but that's not a long-term solution.)