zkincaid / sv-opam Goto Github PK

When installing ntl from this opam repository for duet into a local opam switch, the installation of the ntl package fails:

simmo@roentgenium:~/Desktop/duet/duet/_opam/.opam-switch/build/ntl.20200321 (modern)$ dune install
Entering directory '/home/simmo/Desktop/duet/duet'
Error: The following <package>.install are missing:
- _build/default/duet.install
- _build/default/pa.install
- _build/default/srk/srk.install
Hint: try running: dune build @install

The problem is that the hand-written opam file for it uses dune incorrectly here:

Namely, this call of dune install will also find the dune-project file above in the filesystem and execute it there instead of the build directory of the local opam switch. A correct call of dune via opam needs to use --root or really just -p (which contains the former) to prevent the automatic detection of uppermost dune project. As-is, installation of ntl escapes its build directory, which it definitely should not.

Even though this is fixable with an additional -p argument, the correct way would be to replace hand-written opam files with ones generated by dune itself: https://dune.readthedocs.io/en/stable/opam.html#generating-opam-files. That guarantees that the opam file calls dune correctly.
Weirdly, ntl's own dune-project and opam file are completely empty: https://github.com/zkincaid/ocaml-ntl/tree/modern. Which is why I'm opening the issue here, where the incorrect command is given, instead of on ntl itself.