Support ``verification_url`` mispelling in the device auth response about oidc HOT 6 CLOSED

Hi, sorry for the late reply. I gave it another thought:

Changing the response type is a breaking change, and we want to prevent that on v3 / main. I think the best solution is indeed the one you proposed earlier, and then we clean that up and use the oauth2.DeviceAuthResponse in v4 / next branch.

We are open for a PR.

from oidc.

🎉 This issue has been resolved in version 3.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from oidc.

Hi, no I have nothing against it.

As the oauth2 implementation was released shortly after ours, I was actually thinking if we can somehow reuse some of their definitions and cleanup our code. Perhaps the response object would be a good start.

from oidc.

Indeed the DeviceAuthResponse struct looks very similar with your DeviceAuthorizationResponse and it sounds safe enough to start by leveraging on it. To go further, the whole DeviceAuth method itself would be even interesting to look at and check the differences with your implementation. I'm not sure theyŕe equal but look similar.

from oidc.

I can create a PR just reusing the oauth2.DeviceAuthResponse if you have no objection.

from oidc.

Thanks for the answer, I had the same feeling. I'll do a PR tomorrow ;)

from oidc.