If I use Windows I don't have / but . I must consider it in file path

I've selected scheduling.py:observing_target_list(config) for refactoring, which is a unit of 81 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

It's very useful to add Neocp velocity and direction to Neocp Confirmation list. They must be scraped from
https://www.minorplanetcenter.net/iau/NEO/toconfirm_tabular.html

or

https://newton.spacedys.com/neodys/include/neodys_cgi-bin/ephem_page.pl

Add a menu voice to obtain ephemeris of a given object

It will be very useful to add Twilight times to know when to operate. Maybe it's also useful Moon Phase, Moon rising and Moon set

I've selected interface.py:scheduling_menu(config) for refactoring, which is a unit of 16 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

Now Neocp coordinates are in decimal degrees. It's better if they are in H:M:S format

I've selected interface.py:observatory_config_menu(config) for refactoring, which is a unit of 33 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

The config file path is only for *nix OSes like Linux or MacOS. It can't be used for Windows path. Is there a library useful for it?

It will be awesome to add type hinting in all project

Simply clean all documentation and add and configure Sphinx

It's very useful to know especially moon's ephemeris. Astroplan is good for this purpose

Docstrings must be completed to try and configure Sphinx

It doesn't initialize artificial horizon values

It'll be awesome to have some GUI. I'm thinking to PySimpleGUI https://pysimplegui.readthedocs.io/en/latest/

It's a good idea to use QTable in Observing target list for better performance and personalization.
https://docs.astropy.org/en/stable/table/

I've selected scheduling.py:weather(config) for refactoring, which is a unit of 37 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

When I launch make html in docs folder the output is like this

Running Sphinx v1.8.5
loading pickled environment... done
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 0 source files that are out of date
updating environment: [] 0 added, 1 changed, 0 removed
Downloading https://hpiers.obspm.fr/iers/bul/bulc/Leap_Second.dat                                                                                               
|==========================================================================================================================| 1.3k/1.3k (100.00%)         0s
Downloading https://www.ietf.org/timezones/data/leap-seconds.list [Done]
WARNING: IERSStaleWarning: leap-second file is expired. [astropy.utils.iers.iers]

WARNING: autodoc: failed to import module 'asteroidpy' from module 'asteroidpy'; the following exception was raised:
No module named 'astroquery'
WARNING: autodoc: failed to import module 'configuration' from module 'asteroidpy'; the following exception was raised:
No module named 'astroquery'
WARNING: autodoc: failed to import module 'interface' from module 'asteroidpy'; the following exception was raised:
No module named 'astroquery'
WARNING: autodoc: failed to import module 'scheduling' from module 'asteroidpy'; the following exception was raised:
No module named 'astroquery'
WARNING: autodoc: failed to import module 'asteroidpy'; the following exception was raised:
No module named 'astroquery'
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] modules                                                                                                                                
generating indices... genindex
writing additional pages... search
copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded, 5 warnings.

The HTML pages are in build/html.

AsteroidPy must be translated in Italian language

README.md is really outdated and incomplete.

I've selected interface.py:scheduling_menu(config) for refactoring, which is a unit of 64 lines of code and 7 branch points. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Simple Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the number of branch points (if, for, while, etc.) per unit to 4.
• Why❓
  Keeping the number of branch points low makes units easier to modify and test.
• How 🔧
  Split complex units with a high number of branch points into smaller and simpler ones.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

I've selected interface.py:observatory_config_menu(config) for refactoring, which is a unit of 33 lines of code and 6 branch points. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Simple Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the number of branch points (if, for, while, etc.) per unit to 4.
• Why❓
  Keeping the number of branch points low makes units easier to modify and test.
• How 🔧
  Split complex units with a high number of branch points into smaller and simpler ones.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

AsteroidPy is ready for translation, there are pot files and all important strings are translatable. But Gettext is not configured.

TODO

• Integrate gettext
• Add language code support to configuration file
• Add language changing in config menu

Until now AsteroidPy is a simple python script. It will be easier to install and use as a pip package

TODO

• Write setup.py
• Write requirements.txt
• Install test
• Upload to Pypi repository
• Setup github action to upload automatically every new release

Until now the software asks for minimum altitude for neocp search. It's not needed because it gets artificial horizon as default

It will be a great help to configuration to download observatory coordinates when adding an MPC code to config file

DeltaT is not easy understandable in this form. Weather forecast API gives an init parameter to know when the time is starting

I've selected scheduling.py:observing_target_list(config,payload) for refactoring, which is a unit of 39 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

I've selected interface.py:observatory_config_menu(config) for refactoring, which is a unit of 33 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

When the program encounter network error it fails and crashes. I need some try-except to handle them without crashing

I've selected scheduling.py:observing_target_list(config,payload) for refactoring, which is a unit of 33 lines of code and 7 branch points. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Simple Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the number of branch points (if, for, while, etc.) per unit to 4.
• Why❓
  Keeping the number of branch points low makes units easier to modify and test.
• How 🔧
  Split complex units with a high number of branch points into smaller and simpler ones.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

I've selected scheduling.py:weather(config) for refactoring, which is a unit of 37 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

I've selected interface.py:scheduling_menu(config) for refactoring, which is a unit of 88 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

It'll be awesome to have a model of the horizon, so we can limit altitude differently in every direction

Describe the bug
When I search for ephemerids of an object it crashes completely

To Reproduce

1. Go to Object Ephemerids
2. Insert a known object like 12P

Expected behavior
It gives ephemerids of object

Traceback (most recent call last):
  File "/home/sirio/Projects/asteroidpy/env/bin/asteroidpy", line 33, in <module>
    sys.exit(load_entry_point('AsteroidPy', 'console_scripts', 'asteroidpy')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sirio/Projects/asteroidpy/asteroidpy/__init__.py", line 24, in main
    interface.interface(config)
  File "/home/sirio/Projects/asteroidpy/asteroidpy/interface.py", line 511, in interface
    main_menu(config)
  File "/home/sirio/Projects/asteroidpy/asteroidpy/interface.py", line 496, in main_menu
    scheduling_menu(config)
  File "/home/sirio/Projects/asteroidpy/asteroidpy/interface.py", line 465, in scheduling_menu
    object_ephemeris_menu(config)
  File "/home/sirio/Projects/asteroidpy/asteroidpy/interface.py", line 564, in object_ephemeris_menu
    ephemeris = scheduling.object_ephemeris(config, object_name, step)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sirio/Projects/asteroidpy/asteroidpy/scheduling.py", line 534, in object_ephemeris
    str(object_name).upper(), location=location, step=step, number=30
                                                      ^^^^
UnboundLocalError: cannot access local variable 'step' where it is not associated with a value

I've selected interface.py:main_menu(config) for refactoring, which is a unit of 16 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

https://github.com/nayafia/contributing-template/blob/master/CONTRIBUTING-template.md