zikula-modules / intercom Goto Github PK

If a private message has more than one recipients the recipients are not shown when viewing the message.

user auto completion fails in large DBs with many matches. E.g. I have over 100 users with "jon" in their name. user completion will return a bunch of names containing jon, but because of the 10 limit, it never gets to Jon.

So you can never "select" jon

So you can never send a PM to Jon.

Suggested fix:

Replace the REGEX in the DB query (getusers ajax function) with
LIKE 'Jon%'

This will produce far more logical results.

This has two usability advantage:

1. most people will actually start typing the first letters of a name (when you type 'jon' you expect to find 'Jon' or 'Jonathan222' but not 'dijonmustard'

2)the average user doesn't know anything about REGEX expressions, and when searching for 'T.C.' will be very confused to find 'Taco'.

If you're interested in testing with large number of users, I can send you my userdb (23,000 users)

otherwise, great module.

Stefaan
Attachments
Change History
comment:1 follow-up: ↓ 2 Changed 19 months ago by Stefaan

OK, just noticed that ticket #85 mentions the same problem, and the exact same fix. Sorry :-)

stefaan
comment:2 in reply to: ↑ 1 Changed 19 months ago by Stefaan

Replying to Stefaan:

OK, just noticed that ticket #85 mentions the same problem, and the exact same fix. Sorry :-)

stefaan

And that should be #92 not 85

Used comments are and replace is {* ... *}

Now calls to depreciated smarty plugin modcallhooks remains in compiled rendered code and generates arrors.

The statusview of used messages (indicators) doesn`t work as aspected

The InterCom?-block doesn't have a limit or maximum of displayed items. I think we should re-add some options.

removed in http://code.zikula.org/intercom/changeset/354

works not as aspected, is the pnmessages import really needed anymore?

I think about refactoring with MOST.

What do you think about?

Ajax-buttons need to be disabled after they have been pressed to avoid duplicate actions.

user should be able to choose if he wants to use the ajax usage or not

it not, the title of a message should link directly to the mail displaying page...

would be great because many of my users - as an example - have problems with these ajax functions
Attachments
Change History
comment:1 Changed 2 years ago by herr.vorragend

Milestone changed from not yet defined to 2.5

I am not a big fan of this idea.
I don't want to introduce useless modvars and user-attributes.

I will think about that issue later.

NOTICE (5): E_NOTICE: Undefined index: msg_preview in /Users/bart/Sites/zgw/ztemp/view_compiled/InterCom/user/pm--t_Andreas08-l_en.php line 14

index.php?module=intercom&type=user&func=forwardfrominbox&messageid=1

problem

If you want to show a Conversation History for one PM, but there is no way, because there is no ID of the replied PM. For example see the Facebook Messaging system.
analysis

Two missing columns in the DB
enhancement recommendation

Store also the ID of the replied PM in the DB. It makes also sense to store the ID of the "original" top PM for all replies. So when showing the PM History, the select can be done like this: show me all replies for a specific PMid.

index.php?module=intercom&type=user&func=readinbox&messageid=1

NOTICE (5): E_NOTICE: Undefined index: pnuserid in /.../ztemp/view_compiled/InterCom/user/readpm--t_Andreas08-l_en.php line 82
index.php?module=intercom&type=user&func=storepm&messageid=1

Eine erweiterung wäre schon, wenn zusätzlich zum normalen AN-Feld beim Verfassen einer Nachricht ein Feld per Ajax aufklappbar wäre, in welchem (vielleicht mit checkbox) vordefinert alle Freunde der Contactlist-Liste schon enthalten sind. So könnte man an Freunde schneller schreiben und müsste nicht über die Kontaktliste (suchen und blättern) erst auf den Senden-Link gehen. Manchmal sind Namen recht lang von benutzern oder vielleicht hat den Nicknamen einer nicht so im Kopf, da könnte das schon helfen.

It would be cool to display the actual message in the email-notification about new messages. You'd be able to see if it's important before you switch to the site to answer.

Fatal error: Undefined class constant 'registerArgsError' in /Users/bart/Sites/zgw/modules/InterCom/lib/InterCom/Api/User.php on line 236

index.php?module=intercom&type=user&func=storepm

Hi, archive feature in db is represented by stored property which is boolean.
This indicates that one message can be stored or not but it not tell us who stored the message.
So either the archive feature works:
only for inbox and for message sender and outbox messages cannot be stored
or stored message by sender user displays as stored for recipient which is very bad
or stored message is actually a copy of a message with only one user set - this is bad as well as stored message is not having the users data (sender/recipient whichever stored it)

My solution is to make this field 2 digit (1,0) figure so if sender archives the message then it will be 1x if recipient x1 both 11 none 00 then searching for sender will be "where stored = 10 or stored = 11"

what do you think of an automated refresh of the inbox page.
check via ajax if there are new messages and if there are new messages they are added to the existing messages with an popup "new mail" for some seconds.

http://praegnanz.de/weblog/eingesperrte-mails

for exampe the attribute myprofile_validuntil gets deleted when settinga for intercom are changed.

Here is a nice Bootstrap 3.0 template for displaying comments.

http://bootsnipp.com/snippets/featured/recent-comments-admin-panel

Display an Ajax pop-up and play a sound, when, in the same time you send the notification e-mail. The function checks each X minutes in the background if you have new PM.
It's great to be notified this way when you are online or when you just log in and have pending messages.
BTW Great module!
Attachments
Change History
comment:1 Changed 17 months ago by pnFilip

Or if you are against pop-up display a graphical event linked to a block like "Pending Content" does.

with mailer 2.0 you will have the possibility to add a priority to your email for the mail queue handling.

the sendmessage api function of the mailer module will accept a new parameter "priority" with value 1-10. 1=highest.
PN notifications should become a high priority to support fast user interaction.

maybe you can add "priority" with 2 for notifications. Otherwise default will be 5 for not adding a priority

The timestamp is in the db but it is not displayed.

email with "you have new message" should include the subject of the message optionally.

Also it would be great if the admin could choose between HTML and TEXT notification.

Using html notification the sender's avatar could be included. With the features of mailer 2.0 this might be interesting for more users...

Hi,
Since few days I'm working on refactoring InterCom to zk1.4 you can see progress on my fork. Module is install-able and most of basic features work including sending, reply, forward, store messages, inbox, outbox, user settings, admin settings, tools etc. Module upgrade is present but need to be checked. Most of module is re-factored to bootstrap (admin and user). Ajax and javascript is removed.

Please let me know what you think.
@shefik @craigh @Guite @phaidon

NOTICE (5): E_NOTICE: Undefined index: url in /Users/bart/Sites/zgw/modules/InterCom/lib/InterCom/Controller/User.php line 306

index.php?module=intercom&type=user&func=readinbox&messageid=1

bug description

InterCom?_userapi_createhook function returns wrong value
at the end of the function there is

return true;

bug analysis

in the pnModCallHooks function the hokks are called sequentiell and the return value (extravalue [the name of the module]) from one hook is put into the next hook as arg value.
fix recommendation

the return value must be

return $args['extrainfo'];

Trying to delete messages within the outbox failed by:

Fatal error: Undefined class constant 'registerArgsError' in /xxx/modules/InterCom/lib/InterCom/Api/User.php on line 242

A function that makes the sending of an email to all buddies of contactlist would be great. (without the spamfilter restrictions! spamfilter should be generally disabled when mails are sent to buddies...)

see here:
zikula/core#220

Intercom does send messages by blocked users anyway. Users who have blocked a specific user do still get PMs from this person and are being notified by eMail.

Following message ist shown to the blocked user who is trying to send a messesage to a user who blocked him:

http://www.pontiac-trans-sport.de/bilder/icom.jpg

Message says that PM not send, because he is blocked. Message says as well, that the PM is successfully send.

"No destination entered" when the user name is typed in but not selected/confirmed from the list.

For example, if you quickly type in "admin" and tab out of the field, you can fill out the rest of the message and send but you get the above error. Very non-intuitive for the average user that they have to select the user from a list even when it already matches perfectly. Technically, it's filled out correctly, but no value is for to_user is set in the _POST.
Attachments
Change History
comment:1 Changed 2 years ago by bronto

Cc bronto added

comment:2 Changed 2 years ago by bronto

I want to add that I personally would really value the ability to simply type in a username and have that work, without the list selection involved. I have an installation where direct communications with a class of users isn't allowed (they are students), and the list selector makes it really easy for someone to send a message to someone they aren't supposed to. This isn't so much a security consideration as it is not making it tempting to break the rules.

Description

Could it be possible to add the ability to attach files (images) to messages in InterCom???

Users are asking for this feature..
Attachments
Change History
comment:1 follow-up: ↓ 2 Changed 2 years ago by Landseer

Should be possible with MediaAttach? and some template changes. We will see...
comment:2 in reply to: ↑ 1 Changed 2 years ago by BlackChart

Replying to Landseer:

Should be possible with MediaAttach? and some template changes. We will see...

Is it possible to get a copy of MediaAttach? somewhere?

Wanted to create a milestone.

autoresponder seems to be activated for this user account...

Error:
Exit-Handler: DBUtil::insertObject: unable to find anything to insert in supplied object ...
Stack Trace:

(array) 0:
    (string) file = /home/../includes/DBUtil.class.php
    (integer) line = 1890
    (string) function = pn_exit
    (array) args:
        (string) 0 = DBUtil::insertObject: unable to find anything to insert in supplied object ... 
(array) 1:
    (string) file = //modules/InterCom/pnuserapi.php
    (integer) line = 40
    (string) function = insertObject
    (string) class = DBUtil
    (string) type = ::
    (array) args:
        (array) 0:
            (string) from_uid = 10495
            (string) to_uid = 3230
            (string) subject = Re: test
            (string) time = 2009-11-26 23:18:22
            (string) message = Hallo, danke für deine Mail, ich antworte dir, sobald ich wieder am Rechner sitze! Gruß
            (string) inbox = 1
            (string) outbox = 1
            (string) stored = 0
            (NULL) msg_id = (none) 
        (string) cr_date = 2009-11-26 23:18:22
        (string) cr_uid = 3230
        (string) lu_date = 2009-11-26 23:18:22
        (string) lu_uid = 3230 
    (string) 1 = intercom
    (string) 2 = msg_id