Please complete README to give the possibility to use the Framework in the right way

Description

There is a class member with the same name (not considering the case difference) as its enclosing class. <!--more--> This can cause confusion while reading the code later on keeping a track of what the field represents. It is strongly recommended to provide self-explanatory names so that someone who's reading …

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/PTC-W0052/occurrences/

Description

The global statement is used to specify that the assignment to that name is an assignment to the variable in the global (module) scope, rather than in the local scope. At the module level, this statement is redundant because the local scope and global scope are the same. It is …

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/PYL-W0604/occurrences/

Implement real test procedure for framework

Description

Using various XML methods to parse untrusted XML data is known to be vulnerable to XML attacks. Using the defusedxml module is recommended. Methods should be replaced with their defusedxml equivalents.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/BAN-B314/occurrences/

Need to create the mechanism to create and publish a python package, as explain by this Guide.

Description

Using various methods to parse untrusted XML data is known to be vulnerable to XML attacks. Replace vulnerable imports with the equivalent defusedxml package, or make sure defusedxml.defuse_stdlib() is called.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/BAN-B405/occurrences/

Description

Do not use a mutable like list or dictionary as a default value to an argument. Python’s default arguments are evaluated once when the function is defined. Using a mutable default argument and mutating it will mutate that object for all future calls to the function as well.

Occurrences

There are 3 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/PYL-W0102/occurrences/

Description

Docstring line lengths are recommended to be no greater than 79 characters.

Occurrences

There are 3 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/FLK-W505/occurrences/

Description

Class docstring is missing. If you want to ignore this, you can configure this in the .deepsource.toml file. Please refer to docs for available options.

Occurrences

There are 8 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/PY-D0002/occurrences/

Description

It is recommended not to use global statement unless it is really necessary. Global variables are dangerous because they can be simultaneously accessed from multiple sections of a program. This frequently results in bugs. This also make code difficult to read, because they force you to search through multiple functions …

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/PYL-W0603/occurrences/

Replace print to standard output with log mechanism.
I Suggest to use logging module

Please add comments in code, to better understand functionalities

Description

Using except without a specific exception can be error prone.

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/FLK-E722/occurrences/

Description

The expression or statement is pointless and will have no effect on the program on execution.

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/PYL-W0104/occurrences/

Description

Block comments should have one space before the pound sign # and the comment itself.

Occurrences

There are 9 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/FLK-E265/occurrences/

Prepare an automatic run for test suite

Description

A module has been imported but is not used anywhere in the file. The module should either be used or the import should be removed.

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/PYL-W0611/occurrences/

Description

Line length greater than configured max_line_length detected, defaults to 79 character. This limit can be configured docs

Occurrences

There are 8 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZigRazor/PyStateMachine/issue/FLK-E501/occurrences/

This is the log with the error raised by the workflow that is in the pypi-publish.yml file

Run python setup.py sdist bdist_wheel
running sdist
running egg_info
creating src/PyStateMachine.egg-info
writing src/PyStateMachine.egg-info/PKG-INFO
writing dependency_links to src/PyStateMachine.egg-info/dependency_links.txt
writing entry points to src/PyStateMachine.egg-info/entry_points.txt
writing requirements to src/PyStateMachine.egg-info/requires.txt
writing top-level names to src/PyStateMachine.egg-info/top_level.txt
writing manifest file 'src/PyStateMachine.egg-info/SOURCES.txt'
reading manifest file 'src/PyStateMachine.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'src/PyStateMachine.egg-info/SOURCES.txt'
running check
creating PyStateMachine-0.0.1
creating PyStateMachine-0.0.1/schema
creating PyStateMachine-0.0.1/src
creating PyStateMachine-0.0.1/src/PyStateMachine.egg-info
copying files to PyStateMachine-0.0.1...
copying LICENSE -> PyStateMachine-0.0.1
copying README.md -> PyStateMachine-0.0.1
copying setup.py -> PyStateMachine-0.0.1
copying schema/StateMachine.xsd -> PyStateMachine-0.0.1/schema
copying src/Action.py -> PyStateMachine-0.0.1/src
copying src/Actions.py -> PyStateMachine-0.0.1/src
copying src/Condition.py -> PyStateMachine-0.0.1/src
copying src/Conditions.py -> PyStateMachine-0.0.1/src
copying src/Event.py -> PyStateMachine-0.0.1/src
copying src/ReadStateMachine.py -> PyStateMachine-0.0.1/src
copying src/State.py -> PyStateMachine-0.0.1/src
copying src/StateMachine.py -> PyStateMachine-0.0.1/src
copying src/init.py -> PyStateMachine-0.0.1/src
copying src/PyStateMachine.egg-info/PKG-INFO -> PyStateMachine-0.0.1/src/PyStateMachine.egg-info
copying src/PyStateMachine.egg-info/SOURCES.txt -> PyStateMachine-0.0.1/src/PyStateMachine.egg-info
copying src/PyStateMachine.egg-info/dependency_links.txt -> PyStateMachine-0.0.1/src/PyStateMachine.egg-info
copying src/PyStateMachine.egg-info/entry_points.txt -> PyStateMachine-0.0.1/src/PyStateMachine.egg-info
copying src/PyStateMachine.egg-info/not-zip-safe -> PyStateMachine-0.0.1/src/PyStateMachine.egg-info
copying src/PyStateMachine.egg-info/requires.txt -> PyStateMachine-0.0.1/src/PyStateMachine.egg-info
copying src/PyStateMachine.egg-info/top_level.txt -> PyStateMachine-0.0.1/src/PyStateMachine.egg-info
Writing PyStateMachine-0.0.1/setup.cfg
creating dist
Creating tar archive
removing 'PyStateMachine-0.0.1' (and everything under it)
running bdist_wheel
running build
running build_py
creating build
creating build/lib
copying src/Condition.py -> build/lib
copying src/State.py -> build/lib
copying src/Actions.py -> build/lib
copying src/Event.py -> build/lib
copying src/init.py -> build/lib
copying src/Conditions.py -> build/lib
copying src/Action.py -> build/lib
copying src/ReadStateMachine.py -> build/lib
copying src/StateMachine.py -> build/lib
installing to build/bdist.linux-x86_64/wheel
running install
running install_lib
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/wheel
copying build/lib/Condition.py -> build/bdist.linux-x86_64/wheel
copying build/lib/State.py -> build/bdist.linux-x86_64/wheel
copying build/lib/Actions.py -> build/bdist.linux-x86_64/wheel
copying build/lib/Event.py -> build/bdist.linux-x86_64/wheel
copying build/lib/init.py -> build/bdist.linux-x86_64/wheel
copying build/lib/Conditions.py -> build/bdist.linux-x86_64/wheel
copying build/lib/Action.py -> build/bdist.linux-x86_64/wheel
copying build/lib/ReadStateMachine.py -> build/bdist.linux-x86_64/wheel
copying build/lib/StateMachine.py -> build/bdist.linux-x86_64/wheel
running install_data
creating build/bdist.linux-x86_64/wheel/PyStateMachine-0.0.1.data
creating build/bdist.linux-x86_64/wheel/PyStateMachine-0.0.1.data/data
creating build/bdist.linux-x86_64/wheel/PyStateMachine-0.0.1.data/data/schema
copying schema/StateMachine.xsd -> build/bdist.linux-x86_64/wheel/PyStateMachine-0.0.1.data/data/schema/
running install_egg_info
Copying src/PyStateMachine.egg-info to build/bdist.linux-x86_64/wheel/PyStateMachine-0.0.1-py3.9.egg-info
running install_scripts
adding license file "LICENSE" (matched pattern "LICEN[CS]E*")
creating build/bdist.linux-x86_64/wheel/PyStateMachine-0.0.1.dist-info/WHEEL
creating 'dist/PyStateMachine-0.0.1-py3-none-any.whl' and adding 'build/bdist.linux-x86_64/wheel' to it
adding 'Action.py'
adding 'Actions.py'
adding 'Condition.py'
adding 'Conditions.py'
adding 'Event.py'
adding 'ReadStateMachine.py'
adding 'State.py'
adding 'StateMachine.py'
adding 'init.py'
adding 'PyStateMachine-0.0.1.data/data/schema/StateMachine.xsd'
adding 'PyStateMachine-0.0.1.dist-info/LICENSE'
adding 'PyStateMachine-0.0.1.dist-info/METADATA'
adding 'PyStateMachine-0.0.1.dist-info/WHEEL'
adding 'PyStateMachine-0.0.1.dist-info/entry_points.txt'
adding 'PyStateMachine-0.0.1.dist-info/top_level.txt'
adding 'PyStateMachine-0.0.1.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Uploading distributions to https://upload.pypi.org/legacy/
dist/PyStateMachine-0.0.1-py3-none-any.whl (20.5 KB)
dist/PyStateMachine-0.0.1.tar.gz (20.2 KB)
username set by command options
password set by command options
username: ***
password:
Uploading PyStateMachine-0.0.1-py3-none-any.whl

0%| | 0.00/28.3k [00:00<?, ?B/s]
28%|██▊ | 8.00k/28.3k [00:00<00:00, 45.5kB/s]
100%|██████████| 28.3k/28.3k [00:00<00:00, 57.2kB/s]
Content received from server:

<title>400 Invalid value for classifiers. Error: Classifier 'License :: OSI Approved :: GNU GENERAL PUBLIC LICENSE' is not a valid classifier.</title>

400 Invalid value for classifiers. Error: Classifier 'License :: OSI Approved :: GNU GENERAL PUBLIC LICENSE' is not a valid classifier.

The server could not comply with the request since it is either malformed or otherwise incorrect.

Invalid value for classifiers. Error: Classifier 'License :: OSI Approved :: GNU GENERAL PUBLIC LICENSE' is not a valid classifier. HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/ Invalid value for classifiers. Error: Classifier 'License :: OSI Approved :: GNU GENERAL PUBLIC LICENSE' is not a valid classifier. Error: Process completed with exit code 1.

Someone can correct this?

This refer to the issue #31
and the pull request #47