zigorou / perl-jsv Goto Github PK

Perhaps mention this in your POD (in See Also section)?

Hi.

{type => 'string', format => 'date' } 

will pass validation for invalid date like 2017-02-29.

https://github.com/takkyuuplayer/perl-exercise/blob/master/t/jsv-validator.t#L222-L230

I think we should check date inside

What do you think?

I seem to get random validation results when validating a valid instance (sometimes the result is '1', sometimes it is '0'). If I remove the 'Palette' attribute - results are always consistent. Further, if I set Palette to invalid value (not present in enum list) - results are also consistently correct (negative). My schema:

{
"title": "My schema",
"type": "object",
"properties": {
"Data": {
"type": "object",
"properties": {
"Label": {
"type": "string"
},
"Range": {
"type": "object",
"properties": {
"Min": {
"type": "number"
},
"Max": {
"type": "number"
}
}
}
}
},
"Y Axis": {
"type": "object",
"properties": {
"Label": {
"type": "string"
},
"Range": {
"type": "object",
"properties": {
"Min": {
"type": "number"
},
"Max": {
"type": "number"
}
}
}
}
},
"Palette": {
"type": "object",
"enum": [
{
"label": "text1",
"legend": "text2"
}]
}
},
"definitions": {
"scale": {
"type": "string",
"enum": ["Linear", "Log"]
}
}
}

My Perl structure to validate:
{
'Y Axis' => {
'Range' => {
'Min' => 0.7,
'Max' => 700
},
'Label' => 'Height (hPa)'
},
'Data' => {
'Label' => 'label 1',
'Range' => {
'Max' => 0.7,
'Min' => 0.5
}
},
'Palette' => {
'label' => "text1",
'legend' => "text2"
}

                                      }

Code:

JSV::Validator->load_environments("draft4");
my $validator = JSV::Validator->new(environment => "draft4");
print $validator->validate($schema, $instance) ,"\n";

For example.

• With schema and target instance
• Nested schema stack
• And more...

Hi. I want to use JSV. Do you have any plans to publish on CPAN?

I'd expect a way to initialize a schema only once and validate many instances against it, e.g:

my $validator = JSV::Validator->compile($schema);
say $validator->validate($instance) for @instances;

As I read the code, a lot of initialization is done for each instance in JSV::Validator::validate and JSV::Context::validate.

Especially $opts handling isn't DRY. Maybe $opts become instance?

A number of tests started to fail on my smoker machines. Statistical analysis suggests that the problem is caused by recent Data::Walk versions:

****************************************************************
Regression 'mod:Data::Walk'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0000    158397264459701504.00
[1='eq_2.00']        -1.0000          0.0000    -75883399277069552.00

R^2= 1.000, N= 61, K= 2
****************************************************************

フォーム等のパラメータで 1 が "1" と解釈されちゃうのでその辺どうにかしたい。

Hey Toru. From the looks of your recent work on this module, it looks like you're converting the tests from the json-schema test suite to perl tests. Is this correct? How do I run these tests for your module?

I am working on a module that will allow you to run all of the tests from the test suite without the need to write a new perl test for each one. You define how your module does validation, which draft, and any tests to exclude, and it will run all the tests from the json files.

I'll let you know as soon as it is ready! As I'm doing this as part of my day job, I expect it won't be too far in the future.

errors returned by JSV::Result->get_error() have unescaped pointer expression.
According to http://tools.ietf.org/html/rfc6901#section-4 the following map should be used:
'~1' for '/'
'0' for ''

The error messages seem to be grouped into similar groups. E.g. all missing "required" properties.
But the JSV::Result does not have a method to extract the properties in question.

schema:

  'required' => [ 'firstName', 'lastName' ],
  'properties' => {
    'firstName' => { 'type' => 'string' },
    'lastName' => { 'type' => 'string' },
    'age' => { 
      'type' => 'integer', 
      'description' => 'Age in years',                                                         
      'minimum' => 0
    }
  },
  'type' => 'object'

object:

  { }

JSV::Result:

  bless( {
                 'errors' => [
                               {
                                 'schema' => {
                                               'required' => [
                                                               'firstName',
                                                               'lastName'
                                                             ],
                                               'properties' => {
                                                                 'firstName' => {
                                                                                  'type' => 'string'
                                                                                },
                                                                 'lastName' => {
                                                                                 'type' => 'string'
                                                                               },
                                                                 'age' => {
                                                                            'type' => 'integer',
                                                                            'description' => 'Age in years',
                                                                            'minimum' => 0
                                                                          }
                                                               },
                                               'type' => 'object'
                                             },
                                 'schema_pointer' => '',
                                 'pointer' => '',
                                 'keyword' => 'required',
                                 'message' => 'The instance properties has not required properties (missing: firstName, lastName)',
                                 'instance' => {},
                                 'schema_pointer_history' => []
                               }
                             ],
                 'error' => ''
               }, 'JSV::Result' );

The properties "lastName" and "firstName" should be stored somewhere in this result.

Sometimes get_error_map method raises UUV error.