zielin0 / hypicle Goto Github PK

Add isPubliclyListed() getter to the Guild and return false if undefined.

When a key throttle happens the global field is undefined.

getSoullWellLegendaries -> getSoulWellLegendaries

Still in api/player/minigames.handler.ts some of the getters return solid type without undefined and use "non-null assertion operator" (!) instead of "optional chaining operator" (?).

List of "non-null assertion operators" to fix:

• BedwarsMinigame.getLevel() - minigames.handler.ts#L110
• SkyWarsMinigame.getLevel() - minigames.handler.ts#L332

When a player has mvp+ rank the getHighestRank method displays NONE
https://github.com/Zielin0/hypicle/blob/master/api/player/player.handler.ts#L99

/home/ziel/dev/hypicle/api/player/player.handler.ts:219
    const { displayname, playername } = (await this.getPlayerData()).player;
            ^
TypeError: Cannot destructure property 'displayname' of '(intermediate value).player' as it is null.

This error occurs when the player object from Hypixel API is just null.

Add a getMembersCount() getter to api/guild/guild.handler.ts.