zeskeertwee / destiny-rs Goto Github PK

I started writing my own library like this one, then I found this, and it's done very similarly to how I was doing it (reqwest+serde/serde_json). I wanted to help update this with the new changes to the api. A way to contribute changes would be nice.

I saw a TODO comment in user::GeneralUser to add the context value to the struct, so I did along with it's corresponding struct, the UserToUserContext, and with one of it's value's sturcts, the IgnoreResponse. I'll be able to make a PR for it once PR #4 is merged.

If you care, here's the branch that will be in the PR: https://github.com/zperk13/destiny-rs/tree/user_context

I'm working on adding the missing properties to models::manifest_models::InventoryItem, and there's a lot of hashes. What I'm confused about is in the bungie docs, it says it's mapped to it's own type/object, but the hashes that are already there in the code are saying they're mapped to a varient of the models::manifest::ManifestKey enum with the same name.

Eg:

/// mapped to [`Collectible`](crate::models::manifest::ManifestKey::Collectible)
pub collectible_hash: Option<Hash>,

but the docs say collectible_hash is a hash of https://bungie-net.github.io/multi/schema_Destiny-Definitions-Collectibles-DestinyCollectibleDefinition.html#schema_Destiny-Definitions-Collectibles-DestinyCollectibleDefinition which is it's own type

It would be very interesting to implement a hash type that contains the type it'd get from the manifest (e.g. Hash<Race>) which would allow for easier interaction with the manifest, and prevent type issues when doing so.

Generating code from the openAPI spec (found here) could be very interesting, as it would allow for updating the library quickly after the spec is updated.