zerthick / playershopsrpg Goto Github PK

From reading through the commands, I get the impression that any money put in/earned in the shop stays in the Shops Balance and you have to withdrawl that money to get it into your actual balance? If this is the case, what happens to the money in the shop when the rent expires? Can players still access that money or is it lost forever?

I've had some people stuck in /shop select. Is there any way to stop using /shop select?
If not can there be a /shop cancel or /shop select cancel command?

Thank you.

I think this is an amazing plugin. I want to translate it. Could you add a message file for it?

Heyho,
I have recently Installed the latest Update to this amazing Plugin but ever since I am unable to add Items to any shop.
I have removed the message.config and old shop files as mentioned in the update post but it still keeps giving me the following message

[03:40:39] [Server thread/ERROR] [Sponge/]: Error occurred while executing command 'shop item add' for source EntityPlayerMP['LordMareron'/228, l='world', x=-1038.00, y=68.00, z=3070.78]: org.spongepowered.api.item.inventory.entity.PlayerInventory.queryAny([Lorg/spongepowered/api/item/inventory/ItemStack;)Lorg/spongepowered/api/item/inventory/Inventory;
java.lang.NoSuchMethodError: org.spongepowered.api.item.inventory.entity.PlayerInventory.queryAny([Lorg/spongepowered/api/item/inventory/ItemStack;)Lorg/spongepowered/api/item/inventory/Inventory;
at io.github.zerthick.playershopsrpg.utils.inventory.InventoryUtils.getItemCount(InventoryUtils.java:36) ~[InventoryUtils.class:?]
at io.github.zerthick.playershopsrpg.utils.inventory.InventoryUtils.removeItem(InventoryUtils.java:100) ~[InventoryUtils.class:?]
at io.github.zerthick.playershopsrpg.shop.Shop.addItem(Shop.java:286) ~[Shop.class:?]
at io.github.zerthick.playershopsrpg.cmd.cmdexecutors.shop.item.ShopAddItemExecutor.lambda$execute$11(ShopAddItemExecutor.java:51) ~[ShopAddItemExecutor.class:?]
at io.github.zerthick.playershopsrpg.cmd.cmdexecutors.AbstractShopTransactionCmdExecutor.executeTransaction(AbstractShopTransactionCmdExecutor.java:58) ~[AbstractShopTransactionCmdExecutor.class:?]
at io.github.zerthick.playershopsrpg.cmd.cmdexecutors.shop.item.ShopAddItemExecutor.execute(ShopAddItemExecutor.java:44) ~[ShopAddItemExecutor.class:?]
at org.spongepowered.api.command.args.ChildCommandElementExecutor.execute(ChildCommandElementExecutor.java:182) ~[ChildCommandElementExecutor.class:1.10.2-2281-5.2.0-BETA-2464]
at org.spongepowered.api.command.args.ChildCommandElementExecutor.execute(ChildCommandElementExecutor.java:182) ~[ChildCommandElementExecutor.class:1.10.2-2281-5.2.0-BETA-2464]
at org.spongepowered.api.command.spec.CommandSpec.process(CommandSpec.java:359) ~[CommandSpec.class:1.10.2-2281-5.2.0-BETA-2464]
at org.spongepowered.api.command.dispatcher.SimpleDispatcher.process(SimpleDispatcher.java:336) ~[SimpleDispatcher.class:1.10.2-2281-5.2.0-BETA-2464]
at org.spongepowered.common.command.SpongeCommandManager.process(SpongeCommandManager.java:291) ~[SpongeCommandManager.class:1.10.2-2281-5.2.0-BETA-2464]
at net.minecraft.command.ServerCommandManager.func_71556_a(SourceFile:1083) ~[bd.class:?]
at net.minecraft.network.NetHandlerPlayServer.func_147361_d(NetHandlerPlayServer.java:913) ~[me.class:?]
at net.minecraft.network.NetHandlerPlayServer.func_147354_a(NetHandlerPlayServer.java:892) ~[me.class:?]
at net.minecraft.network.play.client.CPacketChatMessage.func_148833_a(SourceFile:37) ~[im.class:?]
at net.minecraft.network.play.client.CPacketChatMessage.func_148833_a(SourceFile:9) ~[im.class:?]
at org.spongepowered.common.network.PacketUtil.lambda$onProcessPacket$0(PacketUtil.java:157) ~[PacketUtil.class:1.10.2-2281-5.2.0-BETA-2464]
at org.spongepowered.common.event.tracking.CauseTracker.switchToPhase(CauseTracker.java:162) [CauseTracker.class:1.10.2-2281-5.2.0-BETA-2464]
at org.spongepowered.common.network.PacketUtil.onProcessPacket(PacketUtil.java:156) [PacketUtil.class:1.10.2-2281-5.2.0-BETA-2464]
at net.minecraft.network.PacketThreadUtil$1.redirect$onProcessPacket$zjj000(SourceFile:539) [fl$1.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [fl$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_131]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_131]
at net.minecraft.util.Util.func_181617_a(SourceFile:45) [h.class:?]
at org.spongepowered.common.SpongeImplHooks.onUtilRunTask(SpongeImplHooks.java:241) [SpongeImplHooks.class:1.10.2-2281-5.2.0-BETA-2464]
at net.minecraft.server.MinecraftServer.redirect$onRun$zhp000(MinecraftServer.java:3932) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:668) [MinecraftServer.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:387) [ld.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:613) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:471) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_131]

As reading the page on how to setup a shop we tried to setup one up and it failed, no output was being gotten from the commands. But if i do /playershopsrpg:shop i would actually get output back from the commands

Dupe bug 1:

1. Make shop
2. Add whatever item
3. do /shop item remove # -10 and it will add 10 items with no cost

So adding the minus f's up the system. I thought it already checked for a minus I thought I read in some changelog. But I guess not.
I tested this myself and it works :/
http://recordit.co/2FQlAK4GXW
That is a recording of me doing it just now if that helps.

Tested on: spongeforge-1.10.2-2281-5.2.0-BETA-2407
Modpack: https://minecraft.curseforge.com/projects/foolcraft/files/2415352

Dupe bug 2:

1. create a shop
2. add an Item to sell to the Shop
3. restock the shop with /shop item add while holding the item in your hand

it doesnt take the item out of your inve when you add it to the shop, so just buy it back from your Own shop for a price of 0 and bam, you have double the items

But seeing as this is a API 6 issue and 1.11.2, I guess there not much to be done besides a whole new version.

Tested on: spongeforge-1.11.2-2315-6.1.0-BETA-2398
Modpack: https://minecraft.curseforge.com/projects/all-the-mods-2/files/2439222

If someone clicks to sell/buy an item to the shop and types a negative number instead of a positive number it will take the items from the stores stock instead of from the player.

As requested, i've brought this into the git hub issues section.

One of the issues i've noticed with the current version included, is that players are able to still use "/shop item buy" with full inventories. Resulting in them losing the money from the purchase, but not getting anything in return. this is especially true for admin shops.

I currently do not have a log of the events that occur during this as no errors are thrown out in my console.

Whenever I try to buy an item, it takes my currency (using latest version of Total Economy) from the database, but it tells me I don't have enough funds (after taking my money) and doesn't give me the item. Also when I try to deposit my funds into the shop's balance, it takes it but it says the balance is still 0. This is, like, illuminati stuff goin on here. I use Minecraft 1.11.2, Java 8.

As of PlayerShopsRPG-v1.1.0 & spongeforge-1.10.2-2281-5.2.0-BETA-2353, the following error is reported at boot

[16:43:50] [Server thread/ERROR] [Sponge]: Could not pass FMLServerStartedEvent to Plugin{id=playershopsrpg, name=PlayerShopsRPG, version=1.1.0, description=A region-based player shop plugin., authors=[Zerthick], source=/home/skyfactory30/./plugins/PlayerShopsRPG-v1.1.0.jar}
java.lang.NullPointerException
>       at io.github.zerthick.playershopsrpg.cmd.CommandRegister.registerCommands(CommandRegister.java:186) ~[CommandRegister.class:?]
>       at io.github.zerthick.playershopsrpg.PlayerShopsRPG.onServerStart(PlayerShopsRPG.java:136) ~[PlayerShopsRPG.class:?]
>       at org.spongepowered.common.event.listener.GameStartedServerEventListener_PlayerShopsRPG_onServerStart24.handle(Unknown Source) ~[?:?]
>       at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95) ~[RegisteredListener.class:1.10.2-2281-5.2.0-BETA-2353]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:313) [SpongeModEventManager.class:1.10.2-2281-5.2.0-BETA-2353]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:342) [SpongeModEventManager.class:1.10.2-2281-5.2.0-BETA-2353]
>       at org.spongepowered.mod.SpongeMod.onStateEvent(SpongeMod.java:234) [SpongeMod.class:1.10.2-2281-5.2.0-BETA-2353]
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
>       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_121]
>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_121]
>       at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
>       at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) [minecraft_server.1.10.2.jar:?]
>       at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) [minecraft_server.1.10.2.jar:?]
>       at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) [minecraft_server.1.10.2.jar:?]
>       at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) [minecraft_server.1.10.2.jar:?]
>       at com.google.common.eventbus.EventBus.post(EventBus.java:275) [minecraft_server.1.10.2.jar:?]
>       at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:243) [LoadController.class:?]
>       at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:221) [LoadController.class:?]
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
>       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_121]
>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_121]
>       at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
>       at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) [minecraft_server.1.10.2.jar:?]
>       at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) [minecraft_server.1.10.2.jar:?]
>       at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) [minecraft_server.1.10.2.jar:?]
>       at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) [minecraft_server.1.10.2.jar:?]
>       at com.google.common.eventbus.EventBus.post(EventBus.java:275) [minecraft_server.1.10.2.jar:?]
>       at net.minecraftforge.fml.common.LoadController.redirect$onPost$zzb000(LoadController.java:552) [LoadController.class:?]
>       at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:145) [LoadController.class:?]
>       at net.minecraftforge.fml.common.Loader.serverStarted(Loader.java:868) [Loader.class:?]
>       at net.minecraftforge.fml.common.FMLCommonHandler.handleServerStarted(FMLCommonHandler.java:297) [FMLCommonHandler.class:?]
>       at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:433) [MinecraftServer.class:?]
>       at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]

Have an crash report on new ver. of sponge with your mod. I hope it helps you to fix your mod soon)
Forge 2611
Sponge 7.1.0_2911

[19:40:36] [Server thread/ERROR] [Sponge]: Could not pass FMLServerStoppedEvent to Plugin{id=playershopsrpg, name=PlayerShopsRPG, version=2.1.0, description=A region-based player shop plugin., authors=[Zerthick], source=/var/www/www-root/data/mcservers/asgard/./mods/plugins/PlayerShopsRPG-2.1.0.jar}
java.lang.NullPointerException: null
	at io.github.zerthick.playershopsrpg.utils.config.ConfigManager.saveShops(ConfigManager.java:110) ~[ConfigManager.class:?]
	at io.github.zerthick.playershopsrpg.PlayerShopsRPG.onServerStop(PlayerShopsRPG.java:217) ~[PlayerShopsRPG.class:?]
	at org.spongepowered.common.event.listener.GameStoppedServerEventListener_PlayerShopsRPG_onServerStop37.handle(Unknown Source) ~[?:?]
	at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95) ~[RegisteredListener.class:1.12.2-2611-7.1.0-BETA-2911]
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:335) [SpongeModEventManager.class:1.12.2-2611-7.1.0-BETA-2911]
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:368) [SpongeModEventManager.class:1.12.2-2611-7.1.0-BETA-2911]
	at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:213) [SpongeImpl.class:1.12.2-2611-7.1.0-BETA-2911]
	at org.spongepowered.mod.SpongeMod.onStateEvent(SpongeMod.java:240) [SpongeMod.class:1.12.2-2611-7.1.0-BETA-2911]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_161]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_161]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_161]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_161]
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76) [minecraft_server.1.12.2.jar:?]
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.EventBus.post(EventBus.java:217) [minecraft_server.1.12.2.jar:?]
	at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:278) [LoadController.class:?]
	at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:256) [LoadController.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_161]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_161]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_161]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_161]
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76) [minecraft_server.1.12.2.jar:?]
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116) [minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.EventBus.post(EventBus.java:217) [minecraft_server.1.12.2.jar:?]
	at net.minecraftforge.fml.common.LoadController.redirect$onPost$zza000(LoadController.java:560) [LoadController.class:?]
	at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:148) [LoadController.class:?]
	at net.minecraftforge.fml.common.Loader.serverStopped(Loader.java:833) [Loader.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.handleServerStopped(FMLCommonHandler.java:507) [FMLCommonHandler.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:585) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_161]

i cant sell or item add item.
i got this error : org.spongepowered.api.item.inventory.entity.PlayerInventory.queryAny([Lorg/spongepowered/api/item/inventory/ItemStack;)Lorg/spongepowered/api/item/inventory/Inventory

Using spongeforge-1.11-2178-6.0.0-BETA-1999 and if I created an shop and wanna sell e.g. dirt for 0.1 coins per piece, it tells me for example "You do not have 5 dirt(s)." if i try sell 5 dirts and I have these in my inventory.

EDIT: It seems that I forgot to finish my title sorry.
Should have been "Wrong location shops database"

It seems that the plugins doesnt put the database in the correct location.
I for example have a custom folder set in the sponge configs where the configs for every plugin is put into. So I dont have all the configs from the mods mixed with the plugins. Now the normal configs are correctly put into that folder but it seems the database is set to the normal root/config/playershopsrpg folder. Any reason as to why this is so? And can this be set to the normal configs folder provides by sponge?

While updating a modpack I remove all configs to replace them for the new configs (for the new version) in the new release. Not knowing playershopsrpg was in there I deleted all my players shops :(. Which is why im asking for this feature/fix ^^

In version 2.0.4, when I use /shop item add, the items in-hand do not disappear or reduce, though the shop inventory for the item does increase.

I don't see any error messages in client or server consoles.

Other basic functionality like item create, and item removal (via manage) works OK.

When I revert to 2.0.3, the add command works normally again.

Hello,

Love this plugin but we're recently encountering an issue where some items we add to our shop that have nbt data or something like a tesla crate key will stop producing the correct version when bought from the store. This seems to happen at random times, some keys work forever, others only work for a few hours. I have a few examples but dont see any errors in the log to indicate whats gone wrong.

any ideas how to resolve this? I really would love to keep using this plugin!

just wanted to let you know that the permissions on https://github.com/Zerthick/PlayerShopsRPG/wiki/Permissions are not shown properly instead of ''commands'' its command'' example : playershopsrpg.commands.select
should be playershopsrpg.command.select. had some problems getting these to work until i tried it this way (using LuckyPerms)

I used h2 to check and see if anything was being written to the flat file database and it seems it isn't writing anything at all. I've included a copy of the database with my server after I have set up a shop. I also included my server log file for further review.

fml-server-latest.zip

data.mv.zip

When I`m starting server i get this messages on versions 2.1.0 and 2.1.1:

Sponge: 7.2.3

When I create a Shop it doesn't seem to take away the starting money of 3000$ from my balance.
Can you add a possibility to configure the starting value that's put in a shop?

Hi! I like your plugin very much. But my server is in mc 1.11. Have you a plan to update the plugin to API6 or API7? Thank you very much.

Would be awesome if the server admins could configure it to use a GriefPrevention subclaim instead of a shop selection, this would enforce players to create shops only where they have claimed, and the claims would be visualized using WorldEdit CUI

Hai It seems that someone put an item in a shop that the plugin doesnt like.
Any idea what it could be?
This is what i get on startup:
https://pastebin.com/kmCsDgNT

It would be awesome to add some type of admin shop support. Currently there is nothing out there that works well for Sponge API 5 & 6. For details, it's all open I just would like to see support to have unlimited refilling and no ownership of the shops.

Hi there,

can u add some messages even if u setup something as manager for the shop, like an message for "You have set the buy price for Bread to 5."
After setting up something for the shop, is it possible to get automatically back without type in /shop browse again? Would be great!

At least, if you destroy the shop, please add that the content drops on ground - currently the items will destroy :/

Thx and greetz,
Hannes aka. TheYololetsplay

Sponge vanilla api 5 latest version. and then a bunch of other plugins that i can get you a list of if you need it but i don't think you will.

If a player adds an enchanted book to the shop it works fine but then they try to add a different enchanted book and it wont let them. If they create a spot for silk 1 books they can add any enchanted book and it becomes silk 1. If they remove the books after they add them then they get all silk 1 books back instead of various enchants.

I am trying to make a spawn egg shop, but it only lets me put one kind of spawn egg...is there any WorkAround for this?

Hello is it possible to port the PlayerShopsRPG for API7? That would be amazing thank you.

When any listed items hit the itemAmount=0 count it will show out of stock even if the unlimitedStock=true is set, however if the itemAmount=-1 or below, it will act as a true unlimited stock.

Sponge: 1.12.2-2555-7.1.0-BETA-2844
Forge:14.23.1.2590
PlayerShopsRPG: 2.1.0

I've been getting these errors popping up in my console recently:
https://gist.github.com/Big-Deaddy/bfa45d4ceeb31e7a9bb5b945e5f768fd

In the first group of errors, the playershopsrpg-S-13xx will range from 1355 to 1370, going through each number in order. It occurs less often than the second error though, which seems to continuously spam console. Sometimes it will post all four errors at the same time, and others just one.

Please let me know if you need any more information. :)

Hi,
I can't destroy items from my shop(/shop item destroy [1-2-3 ...], an error occured and tells me that : Error occured while executing command : Invalid UUID string: [index of my item]

and if i look at the command helper, it sayd this : Usage : /shop item destroy itemIndex [shopUUID]

I'm a bit confused, do i have to add the UUID of my shop ?

Thanks for your answer

SPONGEAPI: 7.10-ff990df
SPONGEFORGE: 1.1.2-2705-7.10-BETA-3481
Plugin Version: 2.1.1

Hello again! I've noticed something going on in our logs that is spamming them up, and preventing the server from closing down properly? Or... something weird! Shops are also not being saved properly because of that, I'm guessing.

At start up it does:

[12:23:30] [Server thread/INFO] [com.zaxxer.hikari.HikariDataSource]: HikariPool-5 - Start completed.
[12:23:31] [pool-3-thread-4/INFO] [playershopsrpg]: Saving Shops to DB
[12:23:31] [Server thread/INFO] [coloranvil]: ColorAnvil version 1.2.0 enabled!
[12:23:31] [pool-3-thread-4/ERROR] [playershopsrpg]: The database is read only; SQL statement:
MERGE INTO SHOP VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?) [90097-196]
[12:23:31] [pool-3-thread-4/ERROR] [playershopsrpg]: The database is read only; SQL statement:
MERGE INTO SHOP_REGION VALUES (?, ?, ?, ?, ?) [90097-196]
[12:23:31] [pool-3-thread-4/ERROR] [playershopsrpg]: The database is read only; SQL statement:
MERGE INTO SHOP VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?) [90097-196]

and repeats

And this when I try to close the server:

java.lang.Exception: Apparent connection leak detected
	at io.github.zerthick.playershopsrpg.utils.config.sql.SQLUtil.executeUpdate(SQLUtil.java:125) ~[SQLUtil.class:?]
	at io.github.zerthick.playershopsrpg.utils.config.sql.SQLDataUtil.saveShop(SQLDataUtil.java:222) ~[SQLDataUtil.class:?]
	at io.github.zerthick.playershopsrpg.utils.config.sql.SQLDataUtil.saveShopContainter(SQLDataUtil.java:280) ~[SQLDataUtil.class:?]
	at io.github.zerthick.playershopsrpg.utils.config.sql.SQLDataUtil.saveShopContainers(SQLDataUtil.java:304) ~[SQLDataUtil.class:?]
	at io.github.zerthick.playershopsrpg.utils.config.ConfigManager.lambda$saveShops$1(ConfigManager.java:111) ~[ConfigManager.class:?]
	at java.util.HashMap.forEach(HashMap.java:1289) ~[?:1.8.0_222]
	at io.github.zerthick.playershopsrpg.utils.config.ConfigManager.saveShops(ConfigManager.java:111) ~[ConfigManager.class:?]
	at io.github.zerthick.playershopsrpg.PlayerShopsRPG.onServerStop(PlayerShopsRPG.java:217) ~[PlayerShopsRPG.class:?]
	at org.spongepowered.common.event.listener.GameStoppedServerEventListener_PlayerShopsRPG_onServerStop73.handle(Unknown Source) ~[?:?]
	at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:383) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.mod.event.SpongeModEventManager.extendedPost(SpongeModEventManager.java:443) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:404) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:231) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.mod.SpongeMod.onStateEvent(SpongeMod.java:271) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_222]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_222]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_222]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_222]
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.EventBus.post(EventBus.java:217) ~[minecraft_server.1.12.2.jar:?]
	at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219) ~[minecraft_server.jar:?]
	at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197) ~[minecraft_server.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_222]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_222]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_222]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_222]
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.EventBus.post(EventBus.java:217) ~[minecraft_server.1.12.2.jar:?]
	at net.minecraftforge.fml.common.LoadController.redirect$onPost$zza000(LoadController.java:560) ~[LoadController.class:?]
	at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136) ~[LoadController.class:?]
	at net.minecraftforge.fml.common.Loader.serverStopped(Loader.java:847) ~[Loader.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.handleServerStopped(FMLCommonHandler.java:508) ~[FMLCommonHandler.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:587) ~[MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222] 

In the logs it's just this over and over generally?

[00:00:08] [pool-3-thread-534/ERROR] [playershopsrpg]: HikariPool-6 - Connection is not available, request timed out after 30000ms. 

& On the Debug file is similar:
[06:20:38] [pool-3-thread-599/DEBUG] [com.zaxxer.hikari.pool.HikariPool]: HikariPool-6 - Timeout failure stats (total=17, active=17, idle=0, waiting=10)
repeated
Along with:

java.lang.Exception: Apparent connection leak detected
	at io.github.zerthick.playershopsrpg.utils.config.sql.SQLUtil.executeUpdate(SQLUtil.java:125) ~[SQLUtil.class:?]
	at io.github.zerthick.playershopsrpg.utils.config.sql.SQLDataUtil.saveShop(SQLDataUtil.java:222) ~[SQLDataUtil.class:?]
	at io.github.zerthick.playershopsrpg.utils.config.sql.SQLDataUtil.saveShopContainter(SQLDataUtil.java:280) ~[SQLDataUtil.class:?]
	at io.github.zerthick.playershopsrpg.utils.config.sql.SQLDataUtil.saveShopContainers(SQLDataUtil.java:304) ~[SQLDataUtil.class:?]
	at io.github.zerthick.playershopsrpg.utils.config.ConfigManager.lambda$saveShops$1(ConfigManager.java:111) ~[ConfigManager.class:?]
	at java.util.HashMap.forEach(HashMap.java:1289) ~[?:1.8.0_222]
	at io.github.zerthick.playershopsrpg.utils.config.ConfigManager.saveShops(ConfigManager.java:111) ~[ConfigManager.class:?]
	at io.github.zerthick.playershopsrpg.PlayerShopsRPG.onServerStop(PlayerShopsRPG.java:217) ~[PlayerShopsRPG.class:?]
	at org.spongepowered.common.event.listener.GameStoppedServerEventListener_PlayerShopsRPG_onServerStop73.handle(Unknown Source) ~[?:?]
	at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:383) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.mod.event.SpongeModEventManager.extendedPost(SpongeModEventManager.java:443) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:404) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:231) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at org.spongepowered.mod.SpongeMod.onStateEvent(SpongeMod.java:271) ~[spongeforge-1.12.2-2705-7.1.0-BETA-3481.jar:1.12.2-2705-7.1.0-BETA-3481]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_222]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_222]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_222]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_222]
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.EventBus.post(EventBus.java:217) ~[minecraft_server.1.12.2.jar:?]
	at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219) ~[minecraft_server.jar:?]
	at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197) ~[minecraft_server.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_222]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_222]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_222]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_222]
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116) ~[minecraft_server.1.12.2.jar:?]
	at com.google.common.eventbus.EventBus.post(EventBus.java:217) ~[minecraft_server.1.12.2.jar:?]
	at net.minecraftforge.fml.common.LoadController.redirect$onPost$zza000(LoadController.java:560) ~[LoadController.class:?]
	at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136) ~[LoadController.class:?]
	at net.minecraftforge.fml.common.Loader.serverStopped(Loader.java:847) ~[Loader.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.handleServerStopped(FMLCommonHandler.java:508) ~[FMLCommonHandler.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:587) ~[MinecraftServer.class:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222]

I've also tried a few earlier backups I've made of this config folder, but they produce the same sort of errors sadly. I don't think they did that before, but, I can't confirm or remember, they're several months old. I can't trace or pinpoint when it started sadly.

It doesn't produce these errors or hangups at all with a fresh config folder, but I was hoping to find a way to save the shops already done. So any help would be super appreciated! Thanks in advance!

Hello it seems that the plugin is not loading anymore on the server. I have put everything I could find in error in my fml log in a pastebin.
https://pastebin.ubuntu.com/23766327/

SpongeForge
Minecraft: 1.10.2
SpongeAPI: 5.1.0-SNAPSHOT-428c0b2
SpongeForge: 1.10.2-2202-5.1.0-BETA-2022
Minecraft Forge: 12.18.3.2185

Any clue what I can do about this?

I havent really changed anything (Besides maybe the sponge version) and it just happend out of nowhere. I just heard from my players that it doesnt work anymore. The whole plugin isnt even loaded. I can't do any commands.

Hey, so i've got an Admin rank using "Luckperms" (on a sponge server 1.10.2) and the rank has the "*" perms, my admins can't use any of the /shop commands unless i explicitly give them the permissions for each command (Not that hard, but i doubt that's the intended use) i also tried

• playershopsrpg.*
• playershopsrpg.commands.*
  but neither worked to give the commands

PlayerShopsRPG version: 2.0.1 by Zerthick

Hello! I am staff on a Minecraft server that uses PlayerShopsRPG, and one of my duties is to help get a whole bunch of shops set up everywhere. I'd like to make two suggestions that could make this a little easier.

The first suggestion is to when you're adding the item into the shop with the command, to be able to set the price in that command as well, rather than having to click each item and set the price one by one on each page after it's added into the shop.

If that is not possible, then the other suggestion is to not have the shop revert to page 1 when you place in a price. What I mean is that when you put in a set/buy price on any page that isn't page 1, it reverts you back to page 1. This means that you have to keep scrolling through the multiple shop pages over and over to keep putting prices, which spams my chat and gets a bit tedious. If it could be made that it stays on the page you were on before rather than reverting back to the first page, it would be very helpful.

Thank you for reading and considering these suggestions!

Basically what the title says, nothing is left of any shop if I restart my server.

Hey,

Sorry I didnt get back to you about the unlimited money/stock thing I totally forgot about it, that bug was fixed and I really thank you for it, but now I have more of a request then a bug. I would like to see if it would be possible to add spaces between items when you do /shop browse, because as it is now item text seems to be inside each other sometimes.

Thanks,
Nova

Hi.

I have an error when I'm doing /shop set unlimited money true test2 or /shop balance deposit 500 test2, cause I can't find the UUID of the Shop.

I tried with the simple name (test2 in the exemple) but seems not working...

Help ?

Any chance you could move the plugin version details to a /shop version command rather than having it display when running /shop?

Many players use /shop rather than /shop browse, would it be better to have /shop default to /shop browse instead perhaps?
Or add a config option to change the message when /shop is ran? Just were having to explain to alot of players how to use the /shop browse command.

Everything else is working great mind, very impressed with all the features and especially the excellent documentation!

When working with a mod called CustomNPCs it is impossible to use this shop plugin as the commands must be executed by the player which custom NPCs cannot do.

Could you add the ability to use the server console and target a player to use a command?
Ex. shop browse general Hellbringer616

With the latest version the command for

/shop item set buy/sell index amount

does not seem to work and gives a weird error when trying: [CHAT] Error occurred while executing command: Invalid UUID string: 0

representation of what I did: http://recordit.co/kX5mCIJyEu

Has the command changed or is there a problem or something?

Edit: Note that it works perfectly fine when using the 'Manager' in the /shop browse and clicking on the prices to change them

Environment

Sponge version: spongeforge-1.12.2-2555-7.1.0-BETA-2831
Plugin version: PlayerShopsRPG-2.1.0

Feature request

Pls add MySQL support. It is an important point in view to performance, also for making changes in shops quick and easy.

I don't have any logs as there's no crashing, just the fact that some of my shops keep disappearing? Not all of them at times, but they seem to disappear for no reason, no matter the owner of it, or location sometimes, what items are in it - modded or not , or even how close it is to other shops! This has happened a few times now, even with a complete wipe of the plugin, and I'm not sure what to do. I don't know how to check the database either, so I'm not sure if they're still really there or not?
I'm sorry I don't have more to give! It just happens randomly, with random shops. Please let me know if there's anything I can offer, or give, or if I can check the databases? Thank you in advance.

I'm on 2.1.0 - SpongeAPI: 7.1.0-SNAPSHOT-06016f2 / SpongeForge: 1.12-2611-7.1.0-BETA-2990

I got an exception if I stop the server and everything saves.
Please look at attached files.
playershopsrpg_bug.txt

Greetz,
yololetsplay

Hello,

I've had this plugin on my server for a while and recently (probably because I updated sponge) the permissions are not working anymore. Could this be something on playershopsrpg's side? Because I doubt its something with luckyperms seeing as all other permissions still seem to work.

Also when players use a negative value it seems they can get free money from it.

Thanks for the plugin

Cheers!

• Whazaaaaa

I'm attempting to create shops for players to rent, when a player rented a shop from me using /shop rent # it would rent it to the player for the specified number of hours and then take money from me and give it to him instead of taking money from him. The player also couldn't destroy the item from the shop, it said in valid argument /shop item destroy.

Are you able to make it so the shops can be owned by the server as well? On the server im running we have the server with shops and allow the player to rent them in a designated area. This lets us keep them together and clear out old ones that are no longer used.

Is it possible to paginate the items the shops sell if they take up more then one screen of text?

Can you add a config setting to allow us to change the time a player rents for from hour to day/week/month.

Updated to the latest PlayerShopsRPG with Sponge 7, for version 1.12.2.
The usual /shop options only bring up: /shop b, buy s, stock - which is from I suspect, the Total Economy plugin, as they've recently added chest shops - I couldn't see a way to disable it either.

I can get around that by specifying the plugin of course like:
/playershopsrpg:shop browse & such

Which works for making/ browsing/ destroying/ adding items to the shop- but not when it comes to interaction with the shop part. As in, I cannot : Buy, Sell, Manage, or do Owner stuff with it.

I'm not sure if this is a bug, or something I'm doing wrong, but is there a way around this?
Thank you in advance.

When you use the command /shop set unlimited stock. It does show up that it has unlimited in the shop chat, but when you try to buy one of the items it just tells you the shop doesnt have any of those items to sell.