Comments (11)
@amitsgh You'd be most welcome to do so! Let us know if you have any questions about the scope etc, and please make sure to follow our contributor's guide (esp the part about basing your branch and PR off the develop
branch of your fork). Thanks!
from zenml.
@amitsgh sure. We use the assignments a bit differently at ZenML but I assigned you anyway since it seems it's important to you!
from zenml.
@strickvl, I apologize for the delay in addressing the GitHub issue. Unfortunately, I'm currently unable to dedicate time to it. I'm sorry for any inconvenience this may cause. Additionally, I will unassign myself from the issue to allow someone else to take over.
from zenml.
@Ashwin143 https://docs.zenml.io/user-guide/production-guide/understand-stacks
from zenml.
though this is not related to this issue i just want to bring it to your notice, when i click on the docs it is leading to error link instead of leading to correct hyperlink you gave above
![Screenshot 2024-04-20 at 6 39 40 PM](https://private-user-images.githubusercontent.com/53100634/324179401-54db2bb3-8432-401f-ac4f-463792269ca4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg0NTk2MTcsIm5iZiI6MTcxODQ1OTMxNywicGF0aCI6Ii81MzEwMDYzNC8zMjQxNzk0MDEtNTRkYjJiYjMtODQzMi00MDFmLWFjNGYtNDYzNzkyMjY5Y2E0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE1VDEzNDgzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVmOTdlYmI2NzI3NGIyZDMwMGU3NjZlYzA1ZGQ2OGIzMWM1M2QzNzFhOWY2NGEwOWYxYjI0ZWE2YWNmMzdlYTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kShdqoH6Ew1tKVBoe7mNP6UscD4TExFvUpORCC-R-p8)
from zenml.
Hello @strickvl, I'm interested in working on this issue.
from zenml.
Let's say the current validation logic looks something like this (simplified for illustration):
def is_duplicate_name(existing_names, new_name):
"""Check if the new stack name already exists (case-insensitive)."""
return new_name.lower() in (name.lower() for name in existing_names)
To make it case-sensitive, you would update the function like this:
def is_duplicate_name(existing_names, new_name):
"""Check if the new stack name already exists (case-sensitive)."""
return new_name in existing_names
Additionally, you'll need to ensure that the rest of the ZenML stack management system aligns with this case-sensitive approach. This includes areas where stacks are listed, retrieved, and stored.
For the testing part, you would write unit tests to verify the behavior:
import unittest
class TestStackRenaming(unittest.TestCase):
def test_case_sensitive_renaming(self):
existing_names = ['Stack', 'TestStack', 'Example']
self.assertFalse(is_duplicate_name(existing_names, 'stack'))
self.assertTrue(is_duplicate_name(existing_names, 'Stack'))
self.assertFalse(is_duplicate_name(existing_names, 'example'))
self.assertTrue(is_duplicate_name(existing_names, 'Example'))
if __name__ == '__main__':
unittest.main()
This test suite checks that the renaming logic is now sensitive to case changes. It's a basic example and should be expanded based on the full range of functionality and edge cases in the ZenML stack management system.
from zenml.
Hi! The code snippets you mention don't really have anything to do with the ZenML code base. I'd encourage you to check out the Client
methods involved in stack renaming and the others mentioned in the beginning of the 'Steps to Implement' section. You might also want to take a look at existing tests inside the tests/
folder which cover how stack renaming currently happens. In particular, this test is probably what you want to work against, but it could be reworked for this specific case as follows:
def test_renaming_stack_with_update_method_succeeds(clean_client):
"""Tests that renaming a stack with the update method succeeds."""
stack = _create_local_stack(
client=clean_client, stack_name="My_stack_name"
)
clean_client.activate_stack(stack.id)
new_stack_name = "new_stack_name"
# use the specific exception that gets raised instead of the generic exception
with pytest.raises(Exception):
clean_client.update_stack(
name_id_or_prefix=stack.id, name=new_stack_name
)
assert not clean_client.get_stack(name_id_or_prefix=new_stack_name)
Is that any clearer?
from zenml.
@strickvl, I don't seem to be assigned to this task. Could you please check and assign it to me so that it appears in my assigned list?
from zenml.
Hello @strickvl, I'm interested in working on this issue, if it is not resolved may i check
from zenml.
![Screenshot 2024-04-20 at 2 17 53 PM](https://private-user-images.githubusercontent.com/53100634/324166245-a5e2b1b5-8b3b-4607-b2a0-3d6ad94a8aa2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg0NTk2MTcsIm5iZiI6MTcxODQ1OTMxNywicGF0aCI6Ii81MzEwMDYzNC8zMjQxNjYyNDUtYTVlMmIxYjUtOGIzYi00NjA3LWIyYTAtM2Q2YWQ5NGE4YWEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE1VDEzNDgzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgyNjZhZmQyYzk1MTcwN2E2YTc2MWJkODQ4MDk1ZWZiMTEzYTA4YzQwMTEwMGZhMDU0ZWUzYzE0NDE2MTViZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.fYkDdPChIyFU4orKQxSQJRzAC-i5JZFjpxPYXSpq5lU)
Unable to load this page
from zenml.
Related Issues (20)
- [BUG]: Unable to open the quickstart colab notebook HOT 2
- [BUG]: Node Selector doesn"t work on job HOT 1
- Integrate `safetensors` for model serialization HOT 4
- [BUG]: Integration Materializers links not working (Documentation) HOT 5
- [BUG]: THIS RESULTED FROM USING ZENML WITH ML FLOW HOT 1
- [BUG]: File priviledge changing timing, potential TOCTOU HOT 3
- Check if Juypter is installed HOT 2
- [BUG]: {{date}} and {{time}} placeholders not being replaced HOT 2
- [BUG]: Cannot use `zenml init` with templates even after installing `zenml[templates]` HOT 3
- Add Argilla annotator stack component
- [BUG]: Unable to determine source root HOT 4
- [BUG]: GreatExpectations materializer not automatically selected
- [BUG]: Logs are not working HOT 1
- [BUG]: Switch to old version dashboard from 0.57.0 zenml-server HOT 4
- [BUG/Feature Request]: Reusing a step overwrites artifact names HOT 1
- [BUG]: "zenml go" broken for me HOT 6
- [BUG]: Copying stack fails after updating zenml server version HOT 2
- [BUG]: mt5 tokenizer spiece.model saving issue HOT 5
- Test for Jira June 7
- [BUG]: Failed to load model: File /mnt/models/model_metadata.yaml is outside of artifact store bounds HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zenml.