Giter Club home page Giter Club logo

Comments (4)

strickvl avatar strickvl commented on May 29, 2024 1

Correct.

from zenml.

Dev-Khant avatar Dev-Khant commented on May 29, 2024

Hi @strickvl I want to work on this task.

By reading your detailed description I found out that safetensors could be used for Huggingface, PyTorch, PyTorch Lightning and Tensorflow integrations. And we could change the current method to use safetensors to store the model. Please correct me if I'm wrong here.

Here I could add a new materialize named for eg. SafetensorsMaterializer similar to CloudPickleMaterializer.

But I'm struggling with figuring out how can we show users both the option of pickle and safetensors, I mean where can we make this change? As I'm new to this repo, please can you guide me a little on this? Thanks :)

from zenml.

strickvl avatar strickvl commented on May 29, 2024

Hi @Dev-Khant good question!

I think what would be the best first place to start would be simply to add new materializers that use safetensors. Then we can allow users to specify them as a custom materializer for their chosen outputs. (See here for more details on that).

We can keep the new materializers as part of the standard library, but they just wouldn't be the default. (The alternative would be to have a config option on the materializer itself, but that's a big / complicated feature to implement and I think we shouldn't start there).

So, don't change the existing materializers but add new ones that use safetensors and update the docs so that people know how to use these parallel options. Hope that makes sense!

from zenml.

Dev-Khant avatar Dev-Khant commented on May 29, 2024

@strickvl Totally Understood. As you said we will have parallel options for materialized, so correct if me I am wrong, we will have let's say two HFPTModelMaterializer one would be with the current approach and another one with safetensors.

from zenml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.