Giter Club home page Giter Club logo

Comments (3)

zenangst avatar zenangst commented on May 18, 2024

Made an initial implementation for this here - https://github.com/hyperoslo/Spots/pull/408

from spots.

zenangst avatar zenangst commented on May 18, 2024

The idea was to give focus to the last focused Spotable component using the new SpotsFocusDelegate. However, seeing as we are replacing the composite when we reload it, the focusedSpot on SpotsFocusDelegate gets set to nil.

If we can solve the issue that I mentioned in the PR. Then I think it can be solved.

Reference #408

I also attempted to improve how composites are reloaded. Right now the composite spots get replaced when ever a composite container is changed. There is potential for improvement here. However I ran into a weird crash related to tableView(_ tableView: UITableView, didEndDisplaying cell: UITableViewCell, forRowAt indexPath: IndexPath).
The stack trace can be found here.
https://gist.github.com/zenangst/1a7662f81e4abb0071a1bc88493e9fac

This happens when I try to get the prepared items from the temporary spot and add them to the already existing one.

The odd thing is, if you remove the delegate implementation, it reloads just fine.

from spots.

zenangst avatar zenangst commented on May 18, 2024

I just tested this on master. If the indexPath still exists after the updated then it will keep the selection. I'll go ahead and close this issue now :)

from spots.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.