Comments (3)
Made an initial implementation for this here - https://github.com/hyperoslo/Spots/pull/408
from spots.
The idea was to give focus to the last focused Spotable
component using the new SpotsFocusDelegate
. However, seeing as we are replacing the composite when we reload it, the focusedSpot
on SpotsFocusDelegate
gets set to nil
.
If we can solve the issue that I mentioned in the PR. Then I think it can be solved.
Reference #408
I also attempted to improve how composites are reloaded. Right now the composite spots get replaced when ever a composite container is changed. There is potential for improvement here. However I ran into a weird crash related to tableView(_ tableView: UITableView, didEndDisplaying cell: UITableViewCell, forRowAt indexPath: IndexPath).
The stack trace can be found here.
https://gist.github.com/zenangst/1a7662f81e4abb0071a1bc88493e9fac
This happens when I try to get the prepared items from the temporary spot and add them to the already existing one.
The odd thing is, if you remove the delegate implementation, it reloads just fine.
from spots.
I just tested this on master
. If the indexPath
still exists after the updated then it will keep the selection. I'll go ahead and close this issue now :)
from spots.
Related Issues (20)
- Add a test for checking the new `clean` property in `prepareItems`. HOT 1
- Method does not override any method from its superclass
- Improve naming of `itemsPerRow` HOT 12
- Update Example apps HOT 8
- CryptoSwift requirement 0.6.0 does not work with Xcode 9. HOT 4
- Building Scheme Spots-tvOS exit error 65 HOT 6
- no ad was available Apple TV os HOT 4
- Cant Play add HOT 1
- Item with uilabel not expanding with text after sizeToFit HOT 14
- Event handling HOT 3
- Enable linting HOT 1
- func configure(_ item: inout Item) change. HOT 5
- please add more visual example projects just like the cover image implied HOT 1
- Feature Request: Migration from HUB to Spots?
- ComponentDelegate is nil HOT 3
- compile error with Xcode 9.3
- weird problem on pop. HOT 1
- Documentation
- Child components
- Crash on iOS 13 Beta 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spots.