zen4ever / django-authorizenet Goto Github PK

Since I saw there has been a bunch of PEP 8 related work lately, there is a bit more as pep8 tells us:

 sa@wks:~$ alias acsn; acsn pep8
 alias acsn='apt-cache search --names-only'
 pep8 - Python PEP 8 code style checker
 sa@wks:~/0/python/django/django-authorizenet/authorizenet$ pep8 *py
 cim.py:52:80: E501 line too long (80 characters)
 utils.py:15:20: E202 whitespace before ']'
 sa@wks:~/0/python/django/django-authorizenet/authorizenet$ pep8 migrations/*py
 migrations/0001_initial.py:7:1: E302 expected 2 blank lines, found 1
 migrations/0001_initial.py:10:1: W291 trailing whitespace
 migrations/0001_initial.py:13:80: E501 line too long (83 characters)
 migrations/0001_initial.py:59:5: E303 too many blank lines (2)
 migrations/0001_initial.py:109:83: E202 whitespace before '}'
 sa@wks:~/0/python/django/django-authorizenet/authorizenet$ 

It would be nice/useful if django-authorizenet would be made pip installable.

Currently the cim.add_profile, cim.get_profile, and similar CIM functions return a tuple of mixed types. This helper function return method is flawed because:

1. Some of the values in these tuples may be unused in many use cases but are necessary in others (shipping_profile_ids)
2. If the CIM API is extended or more features are added to django-authorizenet more values may be added to this tuple which could break existing code that unpacks this tuple

I think a more flexible data structure should be returned. A dict or a custom class object would allow new values to be added without breaking existing code.

Any ideas regarding this issue are welcome.

Authorize.net is mandating support for partial authorizations for Discover and MasterCard transactions. Does django-authorizenet support these partial authorizations?

(I know an issue tracker isn't the best place to ask this question, but I couldn't find a mailing list for the project, and email addresses for its authors are not listed on the AUTHORS page.)

When using "Make direct payment" the credit card number is sent via POST request to the customers server. This means that your customer needs a PCI DSS certification. I can't imagine that this is the intended usage for this module.

CreateTransactionRequest require 'amount' parameter for all type of transactions. As described here http://www.authorize.net/support/CIM_XML_guide.pdf 'amount' not needed for 'void' transaction. But CreateTransactionRequest create '<amount>...</amount>' tags for 'void' also. Because of this, authorize.net return the error message:

"The element 'profileTransVoid' in namespace 'AnetApi/xml/v1/schema/AnetApiSchema.xsd' has invalid child element 'amount' in namespace 'AnetApi/xml/v1/schema/AnetApiSchema.xsd'. List of possible elements expected: 'customerProfileId, customerPaymentProfileId, customerShippingAddressId, transId' in namespace 'AnetApi/xml/v1/schema/AnetApiSchema.xsd" .
And transaction doesn't pass.