Light

zemdalk / ip Goto Github PK

View Code? Open in Web Editor NEW

This project forked from nus-cs2113-ay2223s2/ip

0.0 0.0 1.0 1.4 MB

NUS CS2113 iP

Shell 2.03% Java 96.49% Batchfile 1.48%

ip's People

Contributors

Forkers

ip's Issues

(overall) the curly brackets are not following the coding standard specified (including function declaration, if-else blocks)

(line 18 of `Duke.java`) Long if-else block, consider using switch-case block

iP code review for Lyu Xingyu

Here are my comments on your iP progress thus far!

(Duke.java) consider making the various string messages (printContent, logo, enteGreet, exitPrompt) as constants
#2
#3
(line 106 of Duke.java) Leave a white space around the operator (a + b instead of a+b)
(line 7 of TodoList.java) please list the imported classes explicitly
(line 161, line 190 of TodoList.java) kindly removed commented dead code
(line 119 to line 124 of TodoList.java) inconsistent indentation
(line 119 to line 124, line 145 to line 149 of TodoList.java) code duplication, consider abstracting it!

Good work! Be careful about the curly brackets as they are not consistent throughout the codebase. Nonetheless great effort! 💪

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.