zeldamods / objmap-totk Goto Github PK

How do you feel about putting AI group in a <details> like Generation group?
e.g.

• Requires putting a boolean into static.json
• Suggestions on better visualization / UI is welcome. Specifically on the Shrine Marker.

Mockups:

Will need to use the correct map area map for the current layer (sky/surface/depths).

In the BotW map repository, the "About" box at the top right has the link to the BotW object map: https://github.com/zeldamods/objmap

I was expecting to see a similar link for this repository, but I couldn't find it. I assumed that meant the map was still not publicly usable. I only recently learned that it's already available for public use. Please add a link to the repository main page as right now it's not visible anywhere!

Satori Mountain Foothill Cave
i see stick lizard and fairy on this place but no appear on your map.

ArmorOfLambda_[01,04,07] should be "X" markers not Location markers.

The icon should be a sword rather than a shirt

This is more of a suggestion (sorry for making so many lol) but could these lines maybe show up on the map? Perhaps search for the relevant KorokCarryProgressKeeper and then the ID of its friend in the placement code? This probably wouldn't look good on a zoom-out so maybe keeping the lines when the map is zoomed in?

LocationsArea have Scale and Rotation parameters. Some have a RigidBodyShapeType with values 0, 2, or 3.

Probably similar to
https://code.botw.link/uking/uking/src/KingSystem/Physics/RigidBody/Shape/physShape.h.html#ksys::phys::ShapeType

0 - Sphere
2 - Box
3 - Cylinder

I would assume empty values should be boxes

The 8 cave entrances on the Great Sky Island are still shown on the surface and all caves are marked in the depths.

via Paperzlel

e.g. Small/Large Dungeons

Just an annoying thing every time I have to reset the cookiesfor the map to show updates (or they take a while to be pushed to the site, probably me being impatient) the message shows up every time and it just bugs me it's not TOTK's decomp or just not there.

Messages from an ancient era

So this one's more of a suggestion but would it be worth having a feature by which an object (such as a weapon in a chest) can only be seen on its respective layer, so that, say, a tree branch on GSI doesn't show up on the surface at Riverside Stable?

Which objects, how do you track them, use localStorage?
When are objects shown or not shown?

The map_name in the permalink is incomplete for Korok markers.

Two possible fixes:

• fix the Korok marker data to contain the correct map_name
• add a fallback in the ?id= parsing function to try looking up an object by hash ID if the (map_type, map_name, hash_id) lookup fails

Just a thing so folks can confirm if a korok is in the sky or on the surface, same for shrines, and eventually dungeons if/when they are implemented.
Also, for the lines, when going between layers perhaps a lighten/darken effect would be a good idea? Just a side thought. Great job as well for getting this up so quickly!

This is specific to ZonauRelief_04, ZonauRelief_05 and ZonauRelief_07, where the location markers are shown on the surface rather than in the sky. This is probably due to the code seeing its y-level and deciding it is on the ground rather than in the sky.

This will require having the FieldMapArea map + the ecosystem data for the depths.

For objects that have several rails (e.g. Light Dragon), it might be worth showing a list of rails in the sidebar and allowing the user to toggle their visibility.

This is purely hypothetical, but what if there was a way to find the location of an object (i.e. a dragon) on its respective rail at X time in the cycle? This probably isn't all that possible due to shrines delaying objects, but if a position could be determined from the time since the map was loaded (when the game loads the shrine of awakening for the first time) to the current time in-game (determined in seconds of the cycle not accounting for time in shrines) so that dragon positions could be easy-ish to determine?

This is a firefox exclusive feature tm, but it's annoying me a great deal. Basically, whenever I try to draw a line, the placement is fine, but when I drag to pan the map, it places a point where my cursor was. This is just on firefox though, not sure if it's specfic to other browsers as well

I had a purple polyline on the map which I'd updated the colour with the "change colour to current polyline colour" setting, but when opening the polyline options menu (the one with all the lines listed) it was displaying as the default one and when I tried to change it but didn't save the changes to match with the one displayed, it reset to the colour shown originally (the default polyline colour). This may be due to the colour shown and the colour pictured not being shared by the programmes, but I couldn't say for certain.

This is probably a very tricky thing to do, but perhaps hiding lines made on different layers so that routes become less confusing to look at? If that's hard maybe try a system that allocates X line to the sky, surface or depths, and then that line is hidden when that area is not selected. This mostly goes for when routing around lightroots/shrines, since both lines are shown and it often looks like going from shrine to shrine when that often isn't the case.

For accuracy and consistency with how the game handles bancs, we should:

• remove the merged "Totk" map type and use the actual map type (e.g. MainField or MinusField)
  • we'll need to modify the object map to search for objects on MainField or MinusField if the user is on the overworld map
  • there are various map_name checks that make assumptions about the format of the map_name; those will need to be fixed
• import MainField/Sky bancs as map_type=MainField, map_name=Sky__{bancName} (or map_type=MainField__Sky, map_name={bancName})

This will allow us to make Show All Objects work in a more intuitive way for sky islands:

• have Radar compute the convex hull of every Sky banc
• add a Radar endpoint to turn a position into the name of its Sky banc (by checking which convex hull the point falls into - hopefully we don't have overlaps?)
• when doing "Show All Objects" on the Sky layer, the objmap asks Radar for the name of the Sky banc, and then proceeds to add a search group as usual

A variant of this idea should also work for caves, though we might need to add a "Show nearby cave objects" option.

e.g. Presence: {FlagName: AncientIsland13_Fallen,IsCheckLazy: true,IsNegation: true} should produce a warning indicating that the object is only spawned if the flag ${obj.Presence.FlagName} is not set. ("not" because IsNegation is true)

Unlike botw, totk temple uses a flat map
I think it should be better to displayed them on the "correct" map

When 'show map tower areas' is enabled, Upland Zorana's label reads Upload Zorana. Similarly, Thyphlo Ruins' label says Typhlo Ruins.

Two chasms (Hyrule Ridge and East Gerudo) are incorrectly marked as caves.

This is an extremely small issue, but searching by map unit won't work unless an en dash is used. For example I must type map:B–8 and not map:B-8. It would be nice if hyphens were also supported, because at first I didn't realize the distinction was necessary and thought it wasn't working. (Note: this applies to the BotW map too.)

Kind of hard to explain, but I was clicking around on a korok and it said it was a surface korok, but had the cloud icon next to it. This persisted on all the koroks I looked at until I clicked on a chest in the sky, and the tag for all the koroks reset to the sky. I then clicked on a surface korok and it had a "sky" tag but a tree icon. I'm not usre what's going on here but it seems that the object tags to say whether it's in the sky, on the surface or in the depths isn't working as intended.

Essesntially so that when routin,g I can have all the korok types (race, buddy, chase etc.) appear with their lines on the map permanently so that routing between them is a bit faster than clicking and identifying the start for each.