zegocover / git-diff-conditional-buildkite-plugin Goto Github PK

Background

Description

When a pipeline uses a wait step like the below, it will cause the plugin to blow up:

steps:
  - wait: ~
    continue_on_failure: true

Steps to Reproduce

• Have a template pipeline that contains the wait step which is a dict

Desired Change

wait steps with continue_on_failure to work with the plugin

Pushing a build with any commit message that contains the string "BUILDKITE" will cause the command hook to fail with:

docker: poorly formatted environment: variable 'the line containing the string BUILDKITE' contains whitespaces.
See 'docker run --help'.

Background

Description

For a better description of what git-mirrors is, refer to this: https://github.com/buildkite/agent/blob/master/EXPERIMENTS.md

When running a build from an agent configured to use git-mirrors. The path setup isn't mounted into the container, this results in errors when checking for git diff.

Steps to Reproduce

• Have a buildkite-agent use git-mirrors and observe errors when running git commands

Desired Change

The ability to pass an optional git-mirrors path to the plugin, so that it gets mounted into the docker container as well as the current working directory

Description

We've been using this plugin for awhile without issue, but just started consistently running into this error Error: The command exited with status 100. I suspect it might be related to a recent (and faulty) change to the python:3.7-slim docker image - issue here.

I'm not sure if we need to bump the plugin to use a different docker image or just wait for this to be patched, but wanted to report for anyone else seeing this.

Background

Description

When passing a pipeline file containing a block errors are thrown

steps:

  - block: "Are you sure you want to continue?"
     branches: "master"

  - label: ":terraform: :man-running:"
    command:
      make awesome
    branches: "master"

Steps to Reproduce

• Run a pipeline file through the plugin which contains a block

StackTrace

[2020-03-31T15:30:42Z] Traceback (most recent call last):
[2020-03-31T15:30:42Z]   File "/usr/local/bin/generate_pipeline.py", line 239, in <module>
[2020-03-31T15:30:42Z]     handler()
[2020-03-31T15:30:42Z]   File "/usr/local/bin/generate_pipeline.py", line 230, in handler
[2020-03-31T15:30:42Z]     dynamic_pipeline, conditions
[2020-03-31T15:30:42Z]   File "/usr/local/bin/generate_pipeline.py", line 128, in generate_pipeline_from_conditions
[2020-03-31T15:30:42Z]     step["skip"] = self.check_if_skip(conditions, step)
[2020-03-31T15:30:42Z]   File "/usr/local/bin/generate_pipeline.py", line 137, in check_if_skip
[2020-03-31T15:30:42Z]     label = step["label"]
[2020-03-31T15:30:42Z] KeyError: 'label'
[2020-03-31T15:30:43Z] 🚨 Error: The command exited with status 1

Desired Change

A pipeline file which has steps containing block don't throw errors for a missing label (Labels are not used for block)

Background

Description

When using the plugin, it is unable to locate the python file

Steps to Reproduce

• Add the plugin to your buildkite pipeline
• Observe error:

[2020-03-31T10:55:24Z] $ /BUILDKITE_PLUGIN_PATH/github-com-Zegocover-git-diff-conditional-buildkite-plugin-v0-1-0/hooks/command
[2020-03-31T10:55:47Z] python3: can't open file 'scripts/generate_pipeline.py': [Errno 2] No such file or directory
[2020-03-31T10:55:47Z] 🚨 Error: The command exited with status 2

Desired Change

For this error to not happen

Background

Description

The current method used to detect the master branch diff, relies heavily on the assumption that merge commits are being used. If this is not the case, then it should be possible to pass a setting to the plugin to set how the master branch is detected in order to check for diff.

Whilst it is possible to pass in your own diff_command, this doesn't allow for detecting diff on a PR vs running on master as easily as it should.

Desired Change

• master branch detection is improved for various merge commit strategies