RangeError: "size" argument must not be larger than 2147483647 about node-id3 HOT 6 CLOSED

Fixed d16530a and published to npm with 0.1.6

from node-id3.

Hello,
would you mind sending me the .mp3 file you're having troubles with to the email in the package.json?

from node-id3.

@Zazama - I sent the MP3 file. I also did some digging and found the culprit to be the cover art.

The file I sent has two cover art photos. The first is the true cover art which is 1 MB @ 1400x1400, the second is a wave pattern added by Beatport Pro which is 51 KB @ 1200x200.

If I remove either of the cover art, the script works fine.

Maybe something is getting multiplied? The max buffer size should be 2GB.

from node-id3.

Yeah, I took a small look at it.
Seems like there are two bugs:

1. the second cover art frame isn't read at its start (maybe it's even trying to read in the middle of the first cover art frame)
2. due to this, it reads random 4 bytes which can hold an extremly high number for the frame size, but the library should check if this size of a frame is bigger than the rest of the ID3-Tag.

I'm a bit sick right now, so I won't dig deeper until I'm better, but a fix shouldn't be too complicated when I'm on it. I could speculate and say it might be because of two present APICs (cover arts) which I've never tested before.

Sorry for the wait, hope it's not urgent.

from node-id3.

@Zazama Hope you are ok now. Is it possible to avoid reading the cover art data to prevent this issue as I am not utilizing cover arts in my app.

from node-id3.

Great! Thanks for the quick fix :)

from node-id3.