Giter Club home page Giter Club logo

Comments (5)

pbricout avatar pbricout commented on August 23, 2024

That looks correct, could you please give a bit more details.
What tags are you giving?
What does not work?
What are you observing in logs?
Are you observing any error?
Is the issue with the write or read?
Thanks

from node-id3.

24jr avatar 24jr commented on August 23, 2024

@pbricout I am just trying to get a few tags to work to see evidence of it changing like artist tag before changing cover photo but trying to add tags like this as well as with image commented out

const tags = {
    title: "Test Title",
    artist: "Test Artist",
    album: "Test Album",
    image: {
      mime: "image/jpeg",
      type: {
        id: 3, // Front cover
      },
      description: "image description",
      imageBuffer: null,
    },
  }

The server function logs

start set tags
[
  [ 'file', Blob { size: 10240, type: 'audio/mpeg' } ],
  [
    'tags',
    '{"title":"Test Title","artist":"Test Artist","album":"Test Album","image":{"mime":"image/jpeg","type":{"id":3},"description":"image description","imageBuffer":{"0":255,"1":216,"2":25....

updatedAudioBuffer <Buffer 49 44 33 03 00 00 00 00 00 00 ff fb 50 c4 00 00 05 dc 01 21 20 84 60 21 48 8e e3 e0 91 0e c0 00 06 10 3e fa de 50 bb de e7 9c 3e 96 0e ac f9 79 70 c4 ... 10200 more bytes>
readtags:  { raw: {} }

The read tags return seems like there are no tags on the file. The result on the client does change the name to Test Title, but when I open apple music and use get info, the other fields are unchanged and still empty. Also, there is no cover art

Screen Shot 2023-05-10 at 10 54 03 AM

I put up a dev site where you can see what happens https://audiotagtest.vercel.app/

from node-id3.

24jr avatar 24jr commented on August 23, 2024

I've found success using https://www.npmjs.com/package/browser-id3-writer#browser to write, but that doesn't do read, so I could use both that lib and this lib, but if I get this one working, then I'd only need to use this one. At least I have stuff working either way

from node-id3.

Zazama avatar Zazama commented on August 23, 2024

"imageBuffer":{"0":255,"1":216,"2":25...

It looks to me like the tags are in the wrong format on the server, this should be a buffer, not an object. Maybe that's the problem?

from node-id3.

24jr avatar 24jr commented on August 23, 2024

@Zazama oh ok yeah so i think the issue was due to me putting the image arrayBuffer in the JSON on the client which I stringified in the form which apparently screws up the arrayBuffer so now I'm just passing the image as a file separately and getting buffer on server

from node-id3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.