Giter Club home page Giter Club logo

Comments (5)

kbuffington avatar kbuffington commented on July 21, 2024

This would be super useful to me as well.

from node-id3.

kbuffington avatar kbuffington commented on July 21, 2024

@Zazama I've been working on this for the last few days, and my fork now has support for reading TXXX frames, and also true handling of multi-value frames (instead of just concatentation). I expect to have the write portion for TXXX and multi-value done in the next day or two. I'm also considering bumping the write to v2.4. Anyway, in the process of this work and without thinking too much about it, I converted the entire project to Typescript and used the linting rules I'm used to, so even though the actual code is almost identical it's morphed into a radically different project. I can submit a PR if you like, but I have a feeling you wouldn't want to approve.

How should I handle this? Would you prefer I create my own true fork with a different name? I could leave it as just a regular fork of this project, but discoverability would suffer and there's not an easy way to npm install it. I don't want you to step on your toes, but my guess is others could benefit from the work I've done as well.

from node-id3.

Zazama avatar Zazama commented on July 21, 2024

Hey @kbuffington, I completely agree with you that others could and should benefit from the work you've done here. Of course the situation is kinda problematic, because I don't think converting the project to typescript is an option for me right now. In addition to that, you may have noticed that node-id3's development is kinda slow from my side. I feel like there are three options:

  1. Me/You porting your changes to this project, but (for me) right now I don't know when.
  2. You letting it stay a fork which, like you said, is problematic.
  3. You creating a whole new package. It's not like I'd be mad, I'd even post a note into my README.md for users searching an alternative. Yet, I see another problem with this solution, which is fragmentation. I think two growing slightly different libraries won't be as good as a single one with different contributions.

But in the end, I'll leave the decision to you. I think your work should be recognized, so decide what you think is best.

from node-id3.

TheBrenny avatar TheBrenny commented on July 21, 2024

Bump. 🤷‍♂️ I would absolutely love the ability to put some minified JSON in the ID3 tag, but I haven't got the time to flick through the code.

from node-id3.

Zazama avatar Zazama commented on July 21, 2024

ad719c1 Would you mind trying the new index.js from the repository?

Usage:

TXXX: [{
  description: "txxx name",
  value: "TXXX value text"
}, {
  description: "txxx name2",
  value: "TXXX value text 2"
}]

from node-id3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.