Comments (5)
This would be super useful to me as well.
from node-id3.
@Zazama I've been working on this for the last few days, and my fork now has support for reading TXXX frames, and also true handling of multi-value frames (instead of just concatentation). I expect to have the write portion for TXXX and multi-value done in the next day or two. I'm also considering bumping the write to v2.4. Anyway, in the process of this work and without thinking too much about it, I converted the entire project to Typescript and used the linting rules I'm used to, so even though the actual code is almost identical it's morphed into a radically different project. I can submit a PR if you like, but I have a feeling you wouldn't want to approve.
How should I handle this? Would you prefer I create my own true fork with a different name? I could leave it as just a regular fork of this project, but discoverability would suffer and there's not an easy way to npm install
it. I don't want you to step on your toes, but my guess is others could benefit from the work I've done as well.
from node-id3.
Hey @kbuffington, I completely agree with you that others could and should benefit from the work you've done here. Of course the situation is kinda problematic, because I don't think converting the project to typescript is an option for me right now. In addition to that, you may have noticed that node-id3's development is kinda slow from my side. I feel like there are three options:
- Me/You porting your changes to this project, but (for me) right now I don't know when.
- You letting it stay a fork which, like you said, is problematic.
- You creating a whole new package. It's not like I'd be mad, I'd even post a note into my README.md for users searching an alternative. Yet, I see another problem with this solution, which is fragmentation. I think two growing slightly different libraries won't be as good as a single one with different contributions.
But in the end, I'll leave the decision to you. I think your work should be recognized, so decide what you think is best.
from node-id3.
Bump.
from node-id3.
ad719c1 Would you mind trying the new index.js from the repository?
Usage:
TXXX: [{
description: "txxx name",
value: "TXXX value text"
}, {
description: "txxx name2",
value: "TXXX value text 2"
}]
from node-id3.
Related Issues (20)
- [feature] Add support for React Native HOT 5
- length/TLEN HOT 2
- Not working with typescript HOT 2
- (Existing) tag for 'year' not returned HOT 5
- ImageBuffer returns undefined after editing other tags HOT 2
- Explain in docs that `write` doesn't create new file =) HOT 4
- "releaseTime" tag not read from AIFF file HOT 6
- Duration not supported HOT 1
- Add constants for obscure tag values HOT 7
- update function does not take v4 tags into account
- Changes and fixes for new API release
- Updating tags in AIFF files makes tags/audio unreadable by other applications HOT 5
- Incorrect timestamps on Syncronized lyrics HOT 16
- Setting synchronisedLyrics to undefined throws an error HOT 4
- [BuG] MP3 File is corrupted HOT 8
- Not reading id3v1 HOT 1
- Support for audio formats other than mp3 HOT 4
- Support large files HOT 2
- Issues with metadata being read by certain players HOT 2
- Basic adding tags not working HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-id3.