Comments (7)
I am using an ESP8266. It seems to me that the EEPROM will be used. Am I confused?
If it is being used, what prevents another library from using the same address space in the EEPROM?
from ina.
I will look into the first issue, but changing the functionality of the begin() call in the manner you suggest is not possible, as it would break existing code.
To address the second question - there is nothing to prevent another library or the programmer from using the same address space. The library allows the EEPROM to be relocated, but there is no mechanism to prevent any other code from accessing the same locations.
from ina.
I don't see the point of using the EEPROM. I just need to store the maxamps and ohms for my devices and do so whenever the user changes them. The other values that the INA lib uses are all derived at run time and thus don't need to be EEPROMed.
I modified my instance to not use the EEPROM, instead using the array. I also sized the array to my max number of devices.
I suggest that there be a version of begin that takes a pointer to a array of inaEE and max size parameter, and returns the # of devices. And add a setXXX function to set each devices' maxamps and ohms.
These changes will not affect any existing code that depends on the begin(x,y) version. Note that nobody is using the begin(x,y,z) version, because it does not work.
from ina.
Also the code that mods _DeviceCount back to 0 when more devices are found than there is space makes no sense (See: // start again at 0 if overflow). Change that to a simple _DeviceCount++; and it will work fine.
from ina.
would be a good option to release a 2.0 version with optional parameter to use EEPROM or not. I could test it with ESP32. I got a little confused about the EEPROM at the beginning too
from ina.
Sorry for taking so long to address this issue. I will look into making the use of EEPROM for storing the memory structure optional - but I'll open up a separate issue for that
from ina.
Fixed as of v1.0.13
from ina.
Related Issues (20)
- Allow an option for the library to not use EEPROM storage for INA-Structure information HOT 3
- INA3221 is supported, how to configure? HOT 7
- Settings for Shunt_Micro_Ohms and Max_Amps HOT 2
- {"One-Line descriptive question title"=>"INA233"} HOT 1
- INA228 Support HOT 50
- Hi Zanduino, Is it Possible to Integrate the INA237 ? Our requirement is to support 85V . HOT 4
- typo HOT 1
- Copy & paste error in Wiki HOT 4
- Max expected amps < 1A HOT 4
- Try to avoid EEPROM footprint HOT 1
- Use 0b111 instead of B111 HOT 5
- Power does not show negative values. HOT 4
- add support for INA239 HOT 1
- Wrong voltage reading with INA226
- Support for Atmega 4809
- Multiple devices does not work properly HOT 3
- Shunt voltage of 0.2mV when there's no load
- Shunt voltage calculation for INA260 uses wrong value
- Ina3221 alerts implementation
- INA233 Addition
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ina.