Giter Club home page Giter Club logo

Comments (4)

michael-brade avatar michael-brade commented on July 3, 2024

Actually, while I'm at it: INA.cpp, line 902:

...when the bus current goes aboe...

should be

...when the bus voltage goes above...

from ina.

SV-Zanshin avatar SV-Zanshin commented on July 3, 2024

Both errors corrected -thanks!

from ina.

michael-brade avatar michael-brade commented on July 3, 2024

Thanks, but I don't think so 😝

The first issue in the wiki still says "shunt voltage" instead of "bus voltage" in the second paragraph.

Actually, looking at the alert pages, they all say:

The state will remain set until the voltage on the shunt goes below the threshold limit.

But the *Under-pages should say "goes above" and the shunt needs to be replaced with bus or power.

And all the alertOn*Voltage-wiki pages have the ; after the true.

Second issue had the typo that you fixed, but that wasn't the important bit -- it was s/current/voltage/, and it still says current instead of voltage in INA.cpp, line 902.

from ina.

SV-Zanshin avatar SV-Zanshin commented on July 3, 2024

I missed this one until now. I've updated the files to reflect the correct program code in the Wiki and comments in the source code.

from ina.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.